admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
45,345 Commits 15 Branches 471 Tags
Commit Graph

330 Commits

Author SHA1 Message Date
Markus Reiter
f0a512ace4 Don’t use Style/StderrPuts. 2017-10-24 19:39:40 +02:00
Gautham Goli
7b2fab8ec5 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 13:53:44 +05:30
Gautham Goli
bdc7eba4b3 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 01:48:00 +05:30
Mike McQuaid
76cd7c7949 Merge pull request #3319 from reitermarkus/squiggly-heredocs 
Use “squiggly” heredocs.
 2017-10-20 14:10:50 +01:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Mike McQuaid
558299b039 rubocop.yml: ignore length of manpage comments. 2017-10-18 10:29:36 +01:00
Gautham Goli
7fa51f71f1 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-13 19:50:46 +05:30
Markus Reiter
30b84ac6f3 Merge pull request #3303 from reitermarkus/special-file-names 
Properly handle special characters in file names.
 2017-10-12 19:56:06 +02:00
Markus Reiter
04363b25a3 Properly handle special characters in file names. 2017-10-11 17:43:54 +02:00
Markus Reiter
71b6e239d7 Set RuboCop maximum to current maximum. 2017-10-10 17:00:04 +02:00
Mike McQuaid
9eb51db400 Rubocop 0.50 and target 2.3. 2017-09-24 21:23:59 +01:00
Gautham Goli
4295a4ca78 audit: Port rules from line_problems to rubocop part 4(WIP-2) 2017-08-10 19:57:53 +05:30
Gautham Goli
086e540231 Add a rubocop config file to control cops' execution in audit and style 2017-07-18 20:23:03 +05:30
Gautham Goli
5b3231ea0a style: disable NewFormulaAudit cops' execution by default unless specified 2017-07-15 22:40:26 +05:30
Mike McQuaid
207ffd6d4f rubocop: disable NewFormulaAudit/Options. 
This is activated on every formula otherwise.
 2017-07-15 17:09:35 +01:00
Gautham Goli
a8f1b02be9 audit: Port audit_options rules for new formulae to rubocop and add test 2017-07-15 17:35:10 +05:30
Gautham Goli
f3923f23ef audit: Port audit_options strict rules to rubocop and add tests 2017-07-14 21:43:16 +05:30
Gautham Goli
b8adc1a8aa audit: Port audit_options non-strict rules to rubocop and add tests 2017-07-13 12:41:43 +05:30
Gautham Goli
4ed34f91c2 audit: Port audit_conflicts method to rubocop and add tests 2017-07-07 20:46:57 +05:30
Gautham Goli
e6938d9201 Enable LegacyPatches cop 2017-06-30 20:25:18 +05:30
Mike McQuaid
76ed7898d0 rubocop: bump PerceivedComplexity max. 2017-06-29 10:31:38 +01:00
Gautham Goli
0e1c88e7ae Refactor Checksum cop to add autocorrect method 2017-06-16 19:45:16 +05:30
Gautham Goli
4d7a983415 audit: Port audit_checksum method to rubocop and add tests 2017-06-16 19:45:16 +05:30
Mike McQuaid
ed9942fbd1 Merge pull request #2769 from MikeMcQuaid/rubocop-no-perl-backrefs 
rubocop: don’t allow Perl regex backrefs.
 2017-06-12 16:47:28 +01:00
Mike McQuaid
22c431d221 Merge pull request #2767 from MikeMcQuaid/rubocop-no-special-global-vars 
rubocop: don’t allow special global variables.
 2017-06-12 16:16:37 +01:00
Mike McQuaid
564b03aa01 rubocop: don’t allow Perl regex backrefs. 
Even if shell/perl users recognise these variables the explicit versions
are significantly more readable for everyone.
 2017-06-10 20:20:02 +03:00
Mike McQuaid
c21abf0e3a rubocop: don’t allow special global variables. 
Even if shell/perl users recognise these variables the English
versions are significantly more readable for everyone.
 2017-06-10 20:01:59 +03:00
Mike McQuaid
139f44f013 rubocop: don’t allow %x. 
It’s confusing for non-Rubyists (and some Rubyists) and that’s a major
number of our current and future contributors.
 2017-06-10 20:01:53 +03:00
Mike McQuaid
113a7a81d0 Revert "audit: Port audit_checksum method to rubocop and add tests" 2017-06-09 11:16:11 +03:00
Gautham Goli
d09d5ecc55 audit: Port audit_checksum method to rubocop and add tests 2017-06-08 21:53:46 +05:30
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Gautham Goli
51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Mike McQuaid
4356016b4a Use parallel RuboCop 
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
 2017-05-29 18:42:02 +01:00
Mike McQuaid
ea8be174f6 Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop 
audit: Port audit_homepage method to rubocop and add tests
 2017-05-15 10:02:47 +01:00
Gautham Goli
91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Mike McQuaid
0fb1fb51be rubocop: don't always care about module length. 
We don't care about this in external taps as this is more about code
architecture than code style.
 2017-05-09 12:58:49 +01:00
Gautham Goli
fed668b330 Add --only-cops,--except-cops options for brew style and simplify cop names 2017-05-03 14:49:23 +05:30
Gautham Goli
c3330c289d Add --only-cops,--except-cops options for brew audit 
Also refactor audit cops into two "departments"
 - FormulaAudit
 - FormulaAuditStrict
 2017-05-02 23:26:12 +05:30
Gautham Goli
413a7e5dae Port audit_components method to rubocops and add corresponding tests 2017-04-22 21:53:16 +05:30
Gautham Goli
a693ca332e Wrap rubocop specific code into methods inside FormulaCop 2017-03-26 15:26:41 +05:30
Gautham Goli
d32978b859 Create FormulaCop base class to reuse helper functions in custom cops 2017-03-08 11:44:35 +05:30
Alyssa Ross
9e97eadccb rubocop: trailing comma in multiline method calls 
Discussed in
https://github.com/Homebrew/brew/pull/1987/files#r100693581.

This was originally ommitted because it wasn't compatible with Ruby 1.8.
(See https://github.com/Homebrew/legacy-homebrew/pull/48144#r49928971).
 2017-02-12 15:11:38 +00:00
Gautham Goli
5dc358c1b7 Update rubocop config 2017-02-12 14:52:13 +05:30
Gautham Goli
483c40fb03 Add custom cop to refactor revision to rebuild in bottle block 2017-01-18 15:54:47 +05:30
Mike McQuaid
726045b2f4 rubocop: exclude more files. 
We never want to check these for any e.g. taps that use them.
 2016-11-26 21:29:02 +00:00
Markus Reiter
c648518f35 Rename single line block parameters to acc/elem. 2016-11-13 23:36:04 +01:00
Markus Reiter
e9391481a8 Update RuboCop to 0.45.0. 2016-11-13 23:18:08 +01:00
Mike McQuaid
f796fe794d rubocop: exclude more tap dirs from hash rockets. 
This is useful for e.g. homebrew/bundle that doesn't live in just
`cmd`.
 2016-11-02 21:49:05 -04:00
Markus Reiter
13e3272e37 Remove Cask’s RuboCop configuration. 2016-10-23 14:13:16 +02:00