- Most usages of this were in the `pretty_duration` method, where "s"
is better described as "seconds" since we're calculating a duration.
- I also took the executive decision to do the same to "m" which refers
to "minutes".
- I originally thought this was short for "function", but upon closer
inspection all its usages are to do with filenames. So, use "filename",
it's clearer.
- These are already included in
6136ffd91e/config/default.yml (L2834-L2862)
upstream default allowed method names, so we don't need them here too.
- Practically this makes no difference since the `inherit_mode` is
`merge` it'll just merge the two, but for tidiness I thought I'd do
this anyway since the duplication annoyed me.
- These had a lot of offenses that were marked as "try to enable".
- A lot of the "describe class" ones were for tests for cmds or dev-cmds,
`brew typecheck` or `brew --env`, and the cop would only pass if I
changed these "describe"s to `BrewTypecheck` or `Brew__Env` which
seemed unhelpful.
- The usefulness of the stubbed mocks cop is
[disputed](https://github.com/rubocop/rubocop-rspec/issues/ 1271), and
fixing the offenses (not autocorrectable) would involve us doing a
fair number of changes since changing `expect` to `allow` would then
force us to make each of the affected tests have `expect` assertions
at the end, where they sometimes don't currently.
- Other occurrences of `@@` and `$` variables are individually disabled
in-line in other files.
- So let's follow the same pattern for Homebrew/homebrew-cask developer
scripts, since there are only a few.
- `Include` and `Exclude` are ubiquitous but `AllowedMethods` less so.
- Move the inheritance to the single cop configuration that it's used
in. Like we do with some other cop configs where they have default
paths/settings that we want to add to, not replace.
- We've disabled metrics cops for method length and complexity since we were
fighting them a lot and the numbers were arbitrary and growing. It feels like
these RSpec metrics numbers are arbitrary too.
- The Actions logs link for the Homebrew/formula-analytics CI failure is long expired.
- I removed the excludes, ran `brew tap homebrew/formula-analytics` and then
`brew style $(brew --repo homebrew/formula-analytics)` and there were no
errors.
- Hence, I think we can clean this stanza up entirely.
