Update RuboCop to 0.45.0.

Library/.rubocop.yml

@@ -6,6 +6,9 @@ AllCops:
 Metrics/AbcSize:
   Enabled: false
 
+Metrics/BlockLength:
+  Enabled: false
+
 Metrics/ClassLength:
   Enabled: false
 

Library/Homebrew/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 100`
-# on 2016-09-28 22:26:33 +0200 using RuboCop version 0.43.0.
+# on 2016-10-24 17:14:14 +0200 using RuboCop version 0.44.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -66,7 +66,7 @@ Metrics/BlockNesting:
 # Offense count: 19
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 400
+  Max: 367
 
 # Offense count: 2
 # Configuration parameters: CountKeywordArgs.
@@ -85,89 +85,12 @@ Style/BarePercentLiterals:
     - 'test/test_patch.rb'
     - 'test/test_string.rb'
 
-# Offense count: 134
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# IgnoredMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'caveats.rb'
-    - 'cleaner.rb'
-    - 'cleanup.rb'
-    - 'cmd/deps.rb'
-    - 'cmd/desc.rb'
-    - 'cmd/fetch.rb'
-    - 'cmd/help.rb'
-    - 'cmd/info.rb'
-    - 'cmd/linkapps.rb'
-    - 'cmd/list.rb'
-    - 'cmd/outdated.rb'
-    - 'cmd/reinstall.rb'
-    - 'cmd/search.rb'
-    - 'cmd/tap-info.rb'
-    - 'cmd/unlinkapps.rb'
-    - 'cmd/update-report.rb'
-    - 'cmd/upgrade.rb'
-    - 'cmd/uses.rb'
-    - 'compilers.rb'
-    - 'debrew.rb'
-    - 'descriptions.rb'
-    - 'dev-cmd/aspell-dictionaries.rb'
-    - 'dev-cmd/audit.rb'
-    - 'dev-cmd/bottle.rb'
-    - 'dev-cmd/edit.rb'
-    - 'dev-cmd/man.rb'
-    - 'diagnostic.rb'
-    - 'exceptions.rb'
-    - 'extend/ARGV.rb'
-    - 'extend/ENV/shared.rb'
-    - 'extend/ENV/std.rb'
-    - 'extend/fileutils.rb'
-    - 'extend/os/mac/formula_cellar_checks.rb'
-    - 'extend/pathname.rb'
-    - 'formula.rb'
-    - 'formula_assertions.rb'
-    - 'formula_cellar_checks.rb'
-    - 'formula_installer.rb'
-    - 'formulary.rb'
-    - 'global.rb'
-    - 'keg.rb'
-    - 'language/haskell.rb'
-    - 'language/node.rb'
-    - 'language/python.rb'
-    - 'migrator.rb'
-    - 'os/mac/linkage_checker.rb'
-    - 'os/mac/xquartz.rb'
-    - 'patch.rb'
-    - 'readall.rb'
-    - 'software_spec.rb'
-    - 'tap.rb'
-    - 'test/lib/config.rb'
-    - 'test/test_ARGV.rb'
-    - 'test/test_cleanup.rb'
-    - 'test/test_dependency_collector.rb'
-    - 'test/test_formula_installer.rb'
-    - 'test/test_formula_installer_bottle.rb'
-    - 'test/test_formulary.rb'
-    - 'test/test_gpg.rb'
-    - 'test/test_migrator.rb'
-    - 'test/test_pathname.rb'
-    - 'test/test_tap.rb'
-    - 'test/test_utils.rb'
-    - 'test/testing_env.rb'
-    - 'utils.rb'
-    - 'utils/github.rb'
-
-# Offense count: 7
+# Offense count: 6
 Style/ClassVars:
   Exclude:
     - 'dev-cmd/audit.rb'
     - 'formula_installer.rb'
     - 'test/testing_env.rb'
-    - 'utils.rb'
 
 # Offense count: 13
 # Configuration parameters: AllowedVariables.
@@ -176,12 +99,11 @@ Style/GlobalVars:
     - 'diagnostic.rb'
     - 'utils.rb'
 
-# Offense count: 2
+# Offense count: 1
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: module_function, extend_self
 Style/ModuleFunction:
   Exclude:
-    - 'global.rb'
     - 'os/mac/xcode.rb'
 
 # Offense count: 8

Library/Homebrew/cask/lib/hbc/cli/style.rb

@@ -23,7 +23,7 @@ module Hbc
         $CHILD_STATUS.success?
       end
 
-      RUBOCOP_CASK_VERSION = "~> 0.10.4".freeze
+      RUBOCOP_CASK_VERSION = "~> 0.10.5".freeze
 
       def install_rubocop
         Utils.capture_stderr do

Library/Homebrew/cmd/style.rb

@@ -47,7 +47,7 @@ module Homebrew
 
   def check_style_impl(files, output_type, options = {})
     fix = options[:fix]
-    Homebrew.install_gem_setup_path! "rubocop", "0.43.0"
+    Homebrew.install_gem_setup_path! "rubocop", "0.45.0"
 
     args = %w[
       --force-exclusion