17311 Commits

Author SHA1 Message Date
Mike McQuaid
d53176fe13
formulary: fix typo.
"an commit" is not valid English.
2020-03-11 13:12:49 +00:00
Mike McQuaid
d0848a512d
Merge pull request #7155 from MikeMcQuaid/formulary-url-warning
formulary: strengthen commit URL warning.
2020-03-11 13:07:39 +00:00
Mike McQuaid
40b4eaff05
Merge pull request #7143 from MikeMcQuaid/shell_output_assert_output
formula_assertions: print output on assertion failed.
2020-03-11 13:07:29 +00:00
Mike McQuaid
2afeffc91b
man: include full help from external commands.
Inspired by https://github.com/Homebrew/brew/issues/7148
2020-03-11 12:22:46 +00:00
Mike McQuaid
7a08691100
commands: helper for official external commands. 2020-03-11 12:17:25 +00:00
Mike McQuaid
f63d2d7887
man: be more exact about global options.
Make clear these don't necessarily apply to all subcommands
(see https://github.com/Homebrew/brew/issues/7121).
2020-03-11 12:16:47 +00:00
Mike McQuaid
60ec0881fe
Merge pull request #7153 from MikeMcQuaid/uninstall-test-fix
cmd/uninstall: handle unparsed arguments.
2020-03-11 11:54:07 +00:00
Mike McQuaid
dbbf824393
formulary: strengthen commit URL warning.
Inspired by https://github.com/Homebrew/brew/issues/7154
2020-03-11 11:51:12 +00:00
Mike McQuaid
c88d07eb5a
Merge pull request #7152 from MikeMcQuaid/tap-issue
Clarify tap issues should not be reported to Homebrew.
2020-03-11 11:32:28 +00:00
Mike McQuaid
40432d86f9
cmd/uninstall: handle unparsed arguments.
If `Homebrew.args` hasn't yet been populated then `named` will return
`nil`. Instead, ensure it is an array before we try to `join` it.

This is pretty much only a test-time problem but has been causing flaky
builds.
2020-03-11 11:21:28 +00:00
Mike McQuaid
b5165ed7e8
Clarify tap issues should not be reported to Homebrew.
Instead, direct people to the actual tap.
2020-03-11 10:57:36 +00:00
EricFromCanada
d068d87b1d desc: fix search options 2020-03-10 23:18:40 -04:00
Michka Popoff
30c4383e86
Merge pull request #7141 from iMichka/regex
rewrite_python_shebang: make version part optional
2020-03-10 22:29:54 +01:00
Michka Popoff
a0cdfe176e
Merge pull request #7146 from Bo98/virtualenv
language/python: fix virtualenv symlinks for versioned Python
2020-03-10 22:29:34 +01:00
Michka Popoff
cccd8d3655 rewrite_python_shebang: make version part optional
We forgot about the simplest case:
/usr/bin/env python
2020-03-10 22:11:45 +01:00
Dawid Dziurla
e097dcedb4
os/linux: implement sdk_path_if_needed 2020-03-10 16:24:17 +01:00
Bo Anderson
2594e7093e language/python: fix virtualenv symlinks for versioned Python 2020-03-10 14:17:30 +00:00
Chris Tompkinson
af3010758a appease rubocop 2020-03-10 10:51:20 +00:00
Chris Tompkinson
160b2c40d0 Add covering test for headers 2020-03-10 10:47:18 +00:00
Chris Tompkinson
38da4dcac0 Add headers option to URLs in forumlas 2020-03-10 10:16:25 +00:00
Mike McQuaid
115aafb9eb
formula_assertions: print output on assertion failed.
When doing `brew test --verbose` (as `brew test-bot` does) ensure that
the output is printed when an assertion fails to more easily debug the
test failure.
2020-03-10 09:21:30 +00:00
Mike McQuaid
e4d520e840
Merge pull request #7140 from Bo98/sdk
formula: ensure CMake uses the desired SDK
2020-03-10 09:07:09 +00:00
Bo Anderson
2592b93770 formula: ensure CMake uses the desired SDK 2020-03-09 22:40:02 +00:00
Mike McQuaid
cb99abe230
Merge pull request #7132 from Bo98/patch-dir
patch: add support for changing directory
2020-03-09 20:10:56 +00:00
Mike McQuaid
82f5b510c1
Merge pull request #7134 from Bo98/sdk
Fix SDK issues on Mojave and High Sierra
2020-03-09 19:52:11 +00:00
Bo Anderson
43d6caf0e3 patch: add support for changing directory 2020-03-09 19:51:10 +00:00
Bo Anderson
26f185b76f os/mac/xcode: only use SDK for system headers on >= Mojave 2020-03-08 20:32:35 +00:00
Issy Long
9f80a7bce2
rubocops/patches: Make more GitHub patch locations enforce revisions
- We recently deleted a load of old Homebrew/formula-patches patches for
  non-existent core formulae
  (https://github.com/Homebrew/formula-patches/pull/283). This is a good
  action to take. Users should always be able to retrieve the patch once
  it's been deleted from the repo, if the formula they continue to use
  specifies a git revision to pull from, not just `master`.
- The code to detect `master` formulae was already here, so this adds
  another GitHub host to the detection: `raw.githubusercontent.com` as
  that's what the current patches that use `master`
  (https://github.com/Homebrew/homebrew-core/pull/51329) link to.
- Fixes https://github.com/Homebrew/homebrew-core/issues/51313.
2020-03-08 20:21:43 +00:00
Bo Anderson
1f29f70929 os/mac: prefer CLT SDK over Xcode 2020-03-08 20:09:06 +00:00
Bo Anderson
20d9f436ca os/mac/sdk: prioritise SDK matching OS version 2020-03-08 20:08:33 +00:00
Mike McQuaid
19050bd738
Merge pull request #6974 from athas/cabal-v2
formula: add std_cabal_v2_args
2020-03-07 13:27:02 +00:00
Troels Henriksen
76afad82be formula: add std_cabal_v2_args 2020-03-06 15:35:30 +01:00
Mike McQuaid
78140cef4a
Merge pull request #7073 from alexreg/issue-7068
audit: ignore group write bit
2020-03-06 14:08:45 +00:00
Alexander Bayandin
9bab086967 rewrite_python_shebang: move loop invariants out of loop 2020-03-05 23:20:16 +00:00
Alexander Regueiro
68047abc0e audit: ignore group write bit 2020-03-05 23:01:41 +00:00
EricFromCanada
b75b39097d update: highlight currently-installed casks 2020-03-05 11:26:55 -05:00
Mike McQuaid
d5a785374e
Merge pull request #7126 from MikeMcQuaid/rubocop-line-length
rubocop.yml: reduce Max LineLength.
2020-03-05 13:33:53 +00:00
Mike McQuaid
c7c9f83ff6
rubocop.yml: reduce Max LineLength.
Fixed the formulae in homebrew/core. Slowly but surely...
2020-03-05 12:22:40 +00:00
Mike McQuaid
67d7697165
Merge pull request #7120 from MikeMcQuaid/args-tweaks
cli/parser: add and use more helpers.
2020-03-05 12:21:24 +00:00
Mike McQuaid
e3ac94fc5d
dev-cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
Mike McQuaid
a7fe0ed847
cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
Mike McQuaid
42477a1aaa
Merge pull request #7125 from Bo98/make-regex
extend/string: match multiline make variables
2020-03-05 09:29:52 +00:00
Mike McQuaid
677e6c972a
Merge pull request #7123 from dawidd6/resource-build-and-test
dependency_collector: make resource dep available at test-time too
2020-03-05 09:29:17 +00:00
Mike McQuaid
ad32d387e9
exceptions: fix case for UsageError subclasses. 2020-03-05 09:25:14 +00:00
Mike McQuaid
495daf0aee
extend/ARGV: remove/private unused methods. 2020-03-05 09:25:14 +00:00
Mike McQuaid
66155ea370
cli/parser: add named/min_named helpers. 2020-03-05 09:25:14 +00:00
Bo Anderson
d0896d641a extend/string: match multiline make variables 2020-03-05 04:11:35 +00:00
Dawid Dziurla
59ce122e90
dependency_collector: make resource dep available at test-time too
There are formulae that use resource blocks for stuff that is needed in
test blocks. If a resource is a `.zip` archive, one needs `unzip`
utility in `PATH` to extract it, but its only available at build-time,
so one observes an error like that for example:

```
==> brew test psftools --verbose
Testing psftools
==> Downloading https://www.zone38.net/font/pc8x8.zip
Already downloaded: /github/home/.cache/Homebrew/downloads/ea5f6a485687368ff5bc99e4cc43a49b06e081baa51a97ee6ddcd8d1b82d7963--pc8x8.zip
==> Verifying ea5f6a485687368ff5bc99e4cc43a49b06e081baa51a97ee6ddcd8d1b82d7963--pc8x8.zip checksum
unzip -o /github/home/.cache/Homebrew/downloads/ea5f6a485687368ff5bc99e4cc43a49b06e081baa51a97ee6ddcd8d1b82d7963--pc8x8.zip -d /tmp/d20200304-21389-ui0wr0
Error: psftools: failed
undefined method `shelljoin' for nil:NilClass
```

Of course this issue affects Linux the most, because of higher
probability that the system lacks `unzip` for example.

With this commit, all resource guessed dependencies should be available
at build and test time.
2020-03-04 22:49:54 +01:00
Mike McQuaid
f13b0513ea
cli/parser: avoid using remaining. 2020-03-04 17:27:01 +00:00
Mike McQuaid
4d9e117430
args: avoid using remaining. 2020-03-04 17:26:38 +00:00