rewrite_python_shebang: move loop invariants out of loop

2020-03-05 20:57:53 +00:00 · 2020-03-05 20:57:53 +00:00 · 9bab086967
commit 9bab086967
parent 97b7099ef2
1 changed files with 2 additions and 2 deletions
--- a/Library/Homebrew/language/python.rb
+++ b/Library/Homebrew/language/python.rb
@ -88,9 +88,9 @@ module Language
    end

    def self.rewrite_python_shebang(python_path)
+      regex = %r{^#! ?/usr/bin/(env )?python([23](\.\d{1,2})?)$}
+      maximum_regex_length = 28 # the length of "#! /usr/bin/env pythonx.yyy$"
      Pathname(".").find do |f|
-        regex = %r{^#! ?/usr/bin/(env )?python([23](\.\d{1,2})?)$}
-        maximum_regex_length = "#! /usr/bin/env pythonx.yyy$".length
        next unless f.file?
        next unless regex.match?(f.read(maximum_regex_length))