admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #7152 from MikeMcQuaid/tap-issue

Browse Source 
Clarify tap issues should not be reported to Homebrew.
This commit is contained in:
Mike McQuaid 2020-03-11 11:32:28 +00:00 committed by GitHub
commit c88d07eb5a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/brew.rb
View File

@ -160,7 +160,7 @@ rescue Exception => e # rubocop:disable Lint/RescueException
onoe e
if internal_cmd && defined?(OS::ISSUES_URL) &&
!ENV["HOMEBREW_NO_AUTO_UPDATE"]
$stderr.puts "#{Tty.bold}Please report this bug:#{Tty.reset}"
$stderr.puts "#{Tty.bold}Please report this issue:#{Tty.reset}"
$stderr.puts " #{Formatter.url(OS::ISSUES_URL)}"
end
$stderr.puts e.backtrace

2
Library/Homebrew/formula_installer.rb
View File

@ -368,7 +368,7 @@ class FormulaInstaller
raise if ARGV.homebrew_developer?
$stderr.puts "Please report this to the #{formula.tap} tap!"
$stderr.puts "Please report this issue to the #{formula.tap} tap (not Homebrew/brew or Homebrew/core)!"
false
else # rubocop:disable Layout/ElseAlignment
f.linked_keg.exist? && f.opt_prefix.exist?

2
Library/Homebrew/utils.rb
View File

@ -167,7 +167,7 @@ module Kernel
next unless match = line.match(HOMEBREW_TAP_PATH_REGEX)
tap = Tap.fetch(match[:user], match[:repo])
tap_message = +"\nPlease report this to the #{tap} tap"
tap_message = +"\nPlease report this issue to the #{tap} tap (not Homebrew/brew or Homebrew/core)"
tap_message += ", or even better, submit a PR to fix it" if replacement
tap_message << ":\n #{line.sub(/^(.*\:\d+)\:.*$/, '\1')}\n\n"
break