3156 Commits

Author SHA1 Message Date
EricFromCanada
ddf057f3dd dev-cmd/: edit help text and descriptions. 2018-10-19 13:12:11 -04:00
Mike McQuaid
0c0275771d
Cleanup Requirements
- remove unused NonBinaryOsxfuseRequirement
- import CodeSignRequirement from Homebrew/homebrew-core
- remove unused UnsignedKextRequirement
- don’t allow custom name for X11Requirement
2018-10-19 16:38:41 +01:00
Mike McQuaid
599ecc9b5a
Deprecate unused download strategies
Download the unused, private download strategies. These are a better fit
for being declared in the formulae and/or taps that use them rather than
in Homebrew/brew where they are unused by Homebrew maintainers or
official taps/formulae.
2018-10-19 10:48:52 +01:00
commitay
0a3ad268a0 audit: check versioned formulae for keg_only :versioned_formula 2018-10-17 23:52:42 +10:00
Markus Reiter
a838b372de Fix brew cask style with relative paths. 2018-10-17 13:51:51 +02:00
Jan Viljanen
96e5b8d9b1 fix rubocop offences 2018-10-16 22:44:07 +02:00
Mike McQuaid
1621eb0b9d
description_cache_store: handle empty database.
Don't perform an incremental update from a report or list of formulae if
the cache is currently empty.

Also, remove some accidentally remaining debugging output.
2018-10-15 22:51:43 -07:00
Mike McQuaid
4def45f499
utils/github_spec: use author that exists. 2018-10-15 14:15:08 -07:00
Mike McQuaid
800853a28d
Vendor rubocop-rspec
We aren't going to vendor its dependencies because we already require
a systemwide installation of `rubocop` to work in your editor. This
avoids requiring users to manually do another
`gem install rubocop-rspec` to have their editor integration behave as
expected.
2018-10-14 12:11:54 -07:00
Mike McQuaid
a2074f01a2
Merge pull request #4922 from MikeMcQuaid/azure-coverage
Generate Cobertura coverage data for Azure Pipelines
2018-10-14 02:19:06 +01:00
Mike McQuaid
100e85dda1
Generate Cobertura coverage data for Azure Pipelines
These can be used and displayed directly in the Azure Pipelines GUI.

It may not end up replacing CodeCov but it's easy enough so: why not.
2018-10-13 17:55:04 -07:00
Mike McQuaid
9a144fe0bd
Merge pull request #5095 from EricFromCanada/cli-parser-help
cli_parser: improve help text formatting
2018-10-14 00:27:38 +01:00
Markus Reiter
2cb0050a99
Merge pull request #5099 from alecclarke/fix-style-in-uninstall_zap_shared_examples
Use the `all` matcher to check the existence of each path.
2018-10-13 23:27:43 +02:00
Mike McQuaid
65b44f2f57
Merge pull request #5098 from Homebrew/dependabot/bundler/Library/Homebrew/test/mustache-1.1.0
Bump mustache from 1.0.5 to 1.1.0 in /Library/Homebrew/test
2018-10-13 19:54:52 +01:00
Mike McQuaid
5118fe2503
Merge pull request #5096 from MikeMcQuaid/descriptions-cache
Use cache_store for descriptions
2018-10-13 19:54:25 +01:00
Mike McQuaid
fe6b78a3f3
Use cache_store for descriptions
This makes use of both the existing interfaces and could use the
existing cache file but we'll create a new one and cleanup the old one
to avoid issues and use a more consistent name.
2018-10-13 08:22:52 -07:00
Alec Clarke
3a8e87134b Use the all matcher to check the existence of each path.
This change allows us to remove the `RSpec/IteratedExpectation` rule from `.rubocop_todo.yml` as we no longer iterate over each path to check existence.

Note: We this PR didn't change the subsequent test checking for the negative expectations as this isn't part of the rule (see: https://github.com/rubocop-hq/rubocop-rspec/issues/278).
2018-10-13 07:23:57 -07:00
dependabot[bot]
e19a0fe719
Bump mustache from 1.0.5 to 1.1.0 in /Library/Homebrew/test
Bumps [mustache](https://github.com/mustache/mustache) from 1.0.5 to 1.1.0.
- [Release notes](https://github.com/mustache/mustache/releases)
- [Changelog](https://github.com/mustache/mustache/blob/master/HISTORY.md)
- [Commits](https://github.com/mustache/mustache/compare/v1.0.5...v1.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-13 14:17:44 +00:00
EricFromCanada
6b8724431f cli_parser: improve help text formatting
- reduce desc_line_length so `brew help` output fits in 80 columns
- support special formatting across line breaks
- support emphasis using asterisks
- add missing depends_on: tests
2018-10-12 13:38:14 -04:00
Mike McQuaid
778e0dbdb1
Merge pull request #5043 from javian/rubocopadjustment
rubocop: only use config if style is testing specified file(s)
2018-10-12 11:02:28 +01:00
commitay
c2bf97bdee audit: use core_tap instead of official_tap 2018-10-12 09:12:12 +10:00
L. E. Segovia
70fc2af647
Cask: fix all homepages now that they are audited 2018-10-10 21:36:06 +00:00
dependabot[bot]
b666aa407f
Bump rspec-expectations from 3.8.1 to 3.8.2 in /Library/Homebrew/test
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.8.1...v3.8.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-09 20:49:19 +00:00
Jan Viljanen
ce530fd0f5 move rspec pattern 2018-10-09 22:10:25 +02:00
Mike McQuaid
cf1c951e2f
Merge pull request #5063 from Homebrew/dependabot/bundler/Library/Homebrew/test/codecov-0.1.13
Bump codecov from 0.1.11 to 0.1.13 in /Library/Homebrew/test
2018-10-09 10:32:23 +01:00
commitay
5024efa506
Merge pull request #5059 from commitay/remove-checkpoint
remove appcast checkpoint audit
2018-10-09 15:21:24 +10:00
Jan Viljanen
aa6912425e rubocop: move rspec include to root config file
To avoid confusion and bugs in rubocop robucop-spec should be required
from the root config.
2018-10-08 20:08:38 +02:00
Markus Reiter
711bb4977f
Merge pull request #5056 from reitermarkus/accessibility_access
Remove the `accessibility_access` stanza.
2018-10-08 18:24:18 +02:00
Markus Reiter
7a951fe5a8
Merge pull request #5062 from Homebrew/dependabot/bundler/Library/Homebrew/test/rubocop-rspec-1.30.0
Bump rubocop-rspec from 1.29.1 to 1.30.0 in /Library/Homebrew/test
2018-10-08 15:16:49 +02:00
dependabot[bot]
ef5ddc6bfb
Bump codecov from 0.1.11 to 0.1.13 in /Library/Homebrew/test
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.1.11 to 0.1.13.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.1.11...v0.1.13)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-08 12:43:11 +00:00
dependabot[bot]
11f0851622
Bump rubocop-rspec from 1.29.1 to 1.30.0 in /Library/Homebrew/test
Bumps [rubocop-rspec](https://github.com/rubocop-hq/rubocop-rspec) from 1.29.1 to 1.30.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-rspec/compare/v1.29.1...v1.30.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-08 06:48:33 +00:00
commitay
da7d46aa14 remove appcast checkpoint audit 2018-10-08 10:54:30 +10:00
Markus Reiter
16618d0fc7 Use ActiveSupport’s #pluralize and #to_sentence. 2018-10-07 23:10:56 +02:00
Markus Reiter
c4d418e126 Use ActiveSupport’s #second. 2018-10-07 23:10:56 +02:00
Markus Reiter
a9128c543c Use ActiveSupport’s #days. 2018-10-07 23:10:56 +02:00
Markus Reiter
b7cf925da8 Remove unused methods in Staged module. 2018-10-07 22:00:07 +02:00
Markus Reiter
59e3a532ff Remove the accessibility_access stanza. 2018-10-07 21:53:31 +02:00
dependabot[bot]
cc7bf45d37
Bump codecov from 0.1.10 to 0.1.11 in /Library/Homebrew/test
Bumps [codecov](https://github.com/codecov/codecov-ruby) from 0.1.10 to 0.1.11.
- [Release notes](https://github.com/codecov/codecov-ruby/releases)
- [Changelog](https://github.com/codecov/codecov-ruby/blob/master/CHANGELOG.md)
- [Commits](https://github.com/codecov/codecov-ruby/compare/v0.1.10...v0.1.11)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-05 16:57:31 +00:00
Mike McQuaid
3cba4737a8
Merge pull request #5028 from MikeMcQuaid/setup_remote_tap_symlink
setup_remote_tap: use system taps.
2018-10-03 19:45:52 +01:00
Mike McQuaid
ac2aabf287
setup_remote_tap: use system taps.
This saves recloning the taps we use multiple times when already done by
the user.
2018-10-03 19:14:04 +01:00
Gautham Goli
b5b988cbb1
help_spec: fix and generate help text in help.rb 2018-10-03 21:12:44 +05:30
Markus Reiter
2308f0c571 Skip quitting applications when not logged into GUI. 2018-10-02 16:27:45 +02:00
Mike McQuaid
1f53099020
Merge pull request #4991 from javian/moverubocopoption
rubocop: move requirement to configuration file
2018-10-01 14:19:11 +01:00
Markus Reiter
bec5272c77
Merge pull request #5000 from reitermarkus/7z
Don’t treat `.7z` as part of a version.
2018-10-01 10:25:41 +02:00
Shaun Jackman
47fdc3dfc9 test/compiler_selector: :gcc was renamed to :gcc_4_2 2018-09-30 11:20:35 -07:00
Jan Viljanen
e5b3b7e326 further updates 2018-09-30 15:35:49 +02:00
Markus Reiter
c430baaee8 Don’t treat .7z as part of a version. 2018-09-29 10:32:18 +02:00
Mike McQuaid
bb177b3055
Merge pull request #4970 from MikeMcQuaid/keg-more-dirs-cleanup
keg: further tweak directory constants.
2018-09-26 09:14:57 +01:00
Mike McQuaid
9a698d2130
keg: further tweak directory constants.
- ensure that `HOMEBREW_CELLAR` is always created on `install`.
- remove the need for a special `PRUNEABLE_DIRECTORIES` variable
- reuse values from existing variables and get `uniq`s.
2018-09-25 22:03:29 +01:00
Mike McQuaid
8b5f64881c
cache_store: use JSON.
After all our recent troubles with DBM I figured I'd benchmark the
performance of DBM vs. JSON. At read time (what we care more about) the
performance is pretty much identical and JSON is only 1.5x slower at
write time. This seems worth it for the reliability increases to avoid
messing with unreliable native code.
2018-09-25 21:07:01 +01:00