Merge pull request #4991 from javian/moverubocopoption

rubocop: move requirement to configuration file

Library/Homebrew/.rubocop.yml

@@ -1,6 +1,5 @@
 inherit_from:
   - ../.rubocop.yml
-  - .rubocop_todo.yml
 
 AllCops:
   Include:

Library/Homebrew/.rubocop_todo.yml

@@ -1,141 +0,0 @@
-# This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2018-09-20 09:03:52 +0100 using RuboCop version 0.59.1.
-# The point is for the user to remove these configuration records
-# one by one as the offenses are removed from the code base.
-# Note that changes in the inspected code, or installation of new
-# versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/LeadingCommentSpace:
-  Exclude:
-    - 'style.rb'
-
-# Offense count: 27
-RSpec/AnyInstance:
-  Exclude:
-    - 'test/cask/cmd/create_spec.rb'
-    - 'test/cask/cmd/edit_spec.rb'
-    - 'test/cask/cmd/outdated_spec.rb'
-    - 'test/cask/cmd/upgrade_spec.rb'
-    - 'test/caveats_spec.rb'
-    - 'test/cleanup_spec.rb'
-    - 'test/download_strategies_spec.rb'
-    - 'test/formatter_spec.rb'
-    - 'test/os/linux/dependency_collector_spec.rb'
-    - 'test/utils/analytics_spec.rb'
-    - 'test/utils/git_spec.rb'
-
-# Offense count: 139
-# Configuration parameters: Prefixes.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Enabled: false
-
-# Offense count: 69
-RSpec/DescribeClass:
-  Enabled: false
-
-# Offense count: 573
-# Configuration parameters: Max.
-RSpec/ExampleLength:
-  Max: 133
-
-# Offense count: 16
-RSpec/ExpectActual:
-  Exclude:
-    - 'spec/routing/**/*'
-    - 'test/missing_formula_spec.rb'
-
-# Offense count: 21
-RSpec/ExpectInHook:
-  Exclude:
-    - 'test/cache_store_spec.rb'
-    - 'test/cask/audit_spec.rb'
-    - 'test/cmd/reinstall_spec.rb'
-    - 'test/download_strategies_spec.rb'
-    - 'test/linkage_cache_store_spec.rb'
-    - 'test/migrator_spec.rb'
-    - 'test/os/mac/java_requirement_spec.rb'
-
-# Offense count: 32
-# Configuration parameters: CustomTransform, IgnoreMethods.
-RSpec/FilePath:
-  Enabled: false
-
-# Offense count: 6
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'test/download_strategies_spec.rb'
-    - 'test/support/helper/spec/shared_context/integration_test.rb'
-    - 'test/utils/git_spec.rb'
-    - 'test/version_spec.rb'
-
-# Offense count: 113
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: have_received, receive
-RSpec/MessageSpies:
-  Enabled: false
-
-# Offense count: 1
-RSpec/MissingExampleGroupArgument:
-  Exclude:
-    - 'test/cask/depends_on_spec.rb'
-
-# Offense count: 23
-RSpec/MultipleDescribes:
-  Enabled: false
-
-# Offense count: 544
-# Configuration parameters: AggregateFailuresByDefault.
-RSpec/MultipleExpectations:
-  Max: 26
-
-# Offense count: 929
-RSpec/NamedSubject:
-  Enabled: false
-
-# Offense count: 99
-RSpec/NestedGroups:
-  Max: 5
-
-# Offense count: 11
-RSpec/RepeatedDescription:
-  Exclude:
-    - 'test/inreplace_spec.rb'
-    - 'test/migrator_spec.rb'
-    - 'test/rubocops/dependency_order_cop_spec.rb'
-    - 'test/rubocops/lines_cop_spec.rb'
-    - 'test/tab_spec.rb'
-
-# Offense count: 10
-RSpec/RepeatedExample:
-  Exclude:
-    - 'test/compiler_selector_spec.rb'
-    - 'test/utils/shell_spec.rb'
-
-# Offense count: 31
-RSpec/SubjectStub:
-  Exclude:
-    - 'test/cache_store_spec.rb'
-    - 'test/cmd/update-report/reporter_spec.rb'
-    - 'test/download_strategies_spec.rb'
-    - 'test/formula_installer_spec.rb'
-    - 'test/java_requirement_spec.rb'
-    - 'test/language/python_spec.rb'
-    - 'test/os/mac/java_requirement_spec.rb'
-
-# Offense count: 64
-# Configuration parameters: IgnoreSymbolicNames.
-RSpec/VerifiedDoubles:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty, nil, both
-Style/EmptyElse:
-  Exclude:
-    - 'style.rb'

Library/Homebrew/style.rb

@@ -23,7 +23,6 @@ module Homebrew
       require "rubocops"
 
       args = %w[
-        --require rubocop-rspec
         --force-exclusion
       ]
       if fix

Library/Homebrew/test/.rubocop.yml

@@ -0,0 +1,5 @@
+inherit_from: 
+  - ../.rubocop.yml
+  - .rubocop_todo.yml
+
+require: rubocop-rspec

Library/Homebrew/test/.rubocop_todo.yml

@@ -0,0 +1,127 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-09-30 14:57:59 +0200 using RuboCop version 0.59.2.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 27
+RSpec/AnyInstance:
+  Exclude:
+    - 'cask/cmd/create_spec.rb'
+    - 'cask/cmd/edit_spec.rb'
+    - 'cask/cmd/outdated_spec.rb'
+    - 'cask/cmd/upgrade_spec.rb'
+    - 'caveats_spec.rb'
+    - 'cleanup_spec.rb'
+    - 'download_strategies_spec.rb'
+    - 'formatter_spec.rb'
+    - 'os/linux/dependency_collector_spec.rb'
+    - 'utils/analytics_spec.rb'
+    - 'utils/git_spec.rb'
+
+# Offense count: 139
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Enabled: false
+
+# Offense count: 69
+RSpec/DescribeClass:
+  Enabled: false
+
+# Offense count: 573
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Enabled: false
+
+# Offense count: 16
+RSpec/ExpectActual:
+  Exclude:
+    - 'spec/routing/**/*'
+    - 'missing_formula_spec.rb'
+
+# Offense count: 21
+RSpec/ExpectInHook:
+  Exclude:
+    - 'cache_store_spec.rb'
+    - 'cask/audit_spec.rb'
+    - 'cmd/reinstall_spec.rb'
+    - 'download_strategies_spec.rb'
+    - 'linkage_cache_store_spec.rb'
+    - 'migrator_spec.rb'
+    - 'os/mac/java_requirement_spec.rb'
+
+# Offense count: 31
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Enabled: false
+
+# Offense count: 6
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'download_strategies_spec.rb'
+    - 'support/helper/spec/shared_context/integration_test.rb'
+    - 'utils/git_spec.rb'
+    - 'version_spec.rb'
+
+# Offense count: 116
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: have_received, receive
+RSpec/MessageSpies:
+  Enabled: false
+
+# Offense count: 1
+RSpec/MissingExampleGroupArgument:
+  Exclude:
+    - 'cask/depends_on_spec.rb'
+
+# Offense count: 24
+RSpec/MultipleDescribes:
+  Enabled: false
+
+# Offense count: 544
+# Configuration parameters: AggregateFailuresByDefault.
+RSpec/MultipleExpectations:
+  Max: 26
+
+# Offense count: 936
+RSpec/NamedSubject:
+  Enabled: false
+
+# Offense count: 99
+RSpec/NestedGroups:
+  Max: 5
+
+# Offense count: 11
+RSpec/RepeatedDescription:
+  Exclude:
+    - 'inreplace_spec.rb'
+    - 'migrator_spec.rb'
+    - 'rubocops/dependency_order_cop_spec.rb'
+    - 'rubocops/lines_cop_spec.rb'
+    - 'tab_spec.rb'
+
+# Offense count: 10
+RSpec/RepeatedExample:
+  Exclude:
+    - 'compiler_selector_spec.rb'
+    - 'utils/shell_spec.rb'
+
+# Offense count: 31
+RSpec/SubjectStub:
+  Exclude:
+    - 'cache_store_spec.rb'
+    - 'cmd/update-report/reporter_spec.rb'
+    - 'download_strategies_spec.rb'
+    - 'formula_installer_spec.rb'
+    - 'java_requirement_spec.rb'
+    - 'language/python_spec.rb'
+    - 'os/mac/java_requirement_spec.rb'
+
+# Offense count: 64
+# Configuration parameters: IgnoreSymbolicNames.
+RSpec/VerifiedDoubles:
+  Enabled: false