3156 Commits

Author SHA1 Message Date
Jonathan Chang
3ce4caeb1a Add tests for language/python 2018-09-24 17:13:51 -04:00
Mike McQuaid
f99f1b611f
cache_store_spec: fix bad rebase.
https://github.com/Homebrew/brew/pull/4948#discussion_r219276137
2018-09-21 14:36:38 +01:00
Mike McQuaid
359fb27cfe
Manually fix RuboCop RSpec autofix failures. 2018-09-20 13:40:38 +01:00
Mike McQuaid
78eba5b815
Autofix RuboCop RSpec failures 2018-09-20 13:36:42 +01:00
Mike McQuaid
da404fcb4e
Install and use RuboCop RSpec by default. 2018-09-20 13:36:41 +01:00
Mike McQuaid
a11fe57cd2
cache_store: handle corrupt DBM database.
When the DBM database cannot be read by the current version of Ruby's
DBM library (due to corruption or another incompatibility) it segfaults
or freezes which takes down the entire Homebrew Ruby process.

This isn't desirable so instead perform a shell out with the Homebrew
Ruby to see if it can read the DBM database before we try to use the
information. If this hangs or crashes: silently delete the database and
recreate it.
2018-09-20 10:57:27 +01:00
Markus Reiter
e5aaf36f7d Add spec for FormulaInstaller#audit_installed. 2018-09-19 20:07:15 +02:00
Markus Reiter
7a991985a4 Run tests with HOMEBREW_DEVELOPER unset. 2018-09-19 19:43:45 +02:00
Mike McQuaid
59c858a8e8
Cleanup Travis and CI configuration.
Use the environment variables set by `brew test-bot`. Eventually we'll
disable Travis CI running CodeCov so move `TRAVIS` references to
`HOMEBREW_TRAVIS_CI` so it doesn't need whitelisted.

Also, fix `azure-pipelines.yml` so it's testing the correct version of
Homebrew/brew (the one checked out in the `pwd`).
2018-09-19 15:01:33 +01:00
Markus Reiter
91b0794329 Add SystemCommand::Result#merged_output. 2018-09-19 04:02:59 +02:00
Markus Reiter
f1a2fa5601
Merge pull request #4935 from reitermarkus/gemfile
Update `Gemfile.lock`.
2018-09-19 03:58:20 +02:00
Markus Reiter
9b667af552
Merge pull request #4915 from alexbostock/code-coverage
Improve code coverage
2018-09-19 03:46:59 +02:00
Markus Reiter
846fa45c03 Update Gemfile.lock. 2018-09-19 03:35:11 +02:00
commitay
02219f91d1
Merge pull request #4862 from commitay/dependency-order
make dependency_order_cop a regular audit
2018-09-19 07:51:42 +10:00
Mike McQuaid
49273c1997
test/Gemfile: add ronn.
This now gets installed into the same place with or without a Bundler
installation but this saves an extra install for `brew test-bot` or
people running `brew man` after `brew tests`.
2018-09-18 21:23:43 +01:00
Mike McQuaid
ead23d1f4c
Use ActiveSupport File.atomic_write
nd delete our own implementation.
2018-09-18 09:20:40 +01:00
alexbostock
188aca1075 Remove blank line 2018-09-17 21:13:19 +01:00
alexbostock
122738709a Add a_json_string matcher and improve tests 2018-09-17 20:49:43 +01:00
alexbostock
e733657f04 Separate and improve tests 2018-09-17 09:50:02 +01:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
05b71b80e4 Update RuboCop to 0.58.2. 2018-09-17 00:43:39 +02:00
alexbostock
a4020db526 Add test for brew info --json=v1 2018-09-16 22:06:42 +01:00
alexbostock
193b5aa07a Add test for brew commands --quiet 2018-09-16 21:54:19 +01:00
alexbostock
6e1374bef9 Add multiple arguments test for brew cat 2018-09-16 21:41:50 +01:00
dependabot[bot]
68abb62c66
Bump parallel_tests from 2.22.1 to 2.23.0 in /Library/Homebrew/test
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.22.1 to 2.23.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.22.1...v2.23.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-09-15 01:48:47 +00:00
Markus Reiter
943e227ca1 Retry all specs with :needs_network. 2018-09-14 16:57:14 +02:00
Mike McQuaid
7c056124e5
Merge pull request #4767 from amyspark/upgrade-relink
Upgrade: implement linkage repair
2018-09-13 14:29:58 +01:00
Mike McQuaid
44bcf69d1f
cmd/shellenv: use Bash.
This speeds up execution by 3x on my machine and the script is simple
enough to warrant this.
2018-09-13 09:27:44 +01:00
Markus Reiter
1130e1d24e
Merge pull request #4812 from alecclarke/increase-messages-unit-test-coverage
Increase the unit test coverage of messages.rb
2018-09-13 05:20:30 +02:00
L. E. Segovia
d442905719
Upgrade: implement linkage repair
After upgrading existing kegs, we now search and upgrade their
dependents as well. If any are detected that have broken linkage, they
are reinstalled from source.

If there are any formulae in the dependents tree that are pinned, they
are only reinstalled if they're not outdated; in all cases, a suitable
message is printed detailing the kegs that will be acted upon.
2018-09-12 19:28:02 +00:00
Alec Clarke
e6409f6a09 Increase the unit test coverage of messages.rb
This increases the messages.rb unit test coverage to 100%.
2018-09-12 06:11:38 -07:00
Mike McQuaid
23da378dd8
Merge pull request #4882 from Homebrew/dependabot/bundler/Library/Homebrew/test/parser-2.5.1.2
Bump parser from 2.5.1.0 to 2.5.1.2 in /Library/Homebrew/test
2018-09-12 08:31:37 +01:00
Mike McQuaid
3983db700f
Merge pull request #4881 from Homebrew/dependabot/bundler/Library/Homebrew/test/rspec-expectations-3.8.1
Bump rspec-expectations from 3.8.0 to 3.8.1 in /Library/Homebrew/test
2018-09-12 08:31:23 +01:00
Mike McQuaid
9e9845a5d4
Merge pull request #4879 from Homebrew/dependabot/bundler/Library/Homebrew/test/docile-1.3.1
Bump docile from 1.3.0 to 1.3.1 in /Library/Homebrew/test
2018-09-12 08:30:57 +01:00
dependabot[bot]
727b1e5ec8
Bump ruby-progressbar from 1.9.0 to 1.10.0 in /Library/Homebrew/test
Bumps [ruby-progressbar](https://github.com/jfelchner/ruby-progressbar) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/jfelchner/ruby-progressbar/releases)
- [Changelog](https://github.com/jfelchner/ruby-progressbar/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jfelchner/ruby-progressbar/compare/releases/v1.9.0...releases/v1.10.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-09-12 05:26:09 +00:00
dependabot[bot]
1ce9c3841c
Bump parser from 2.5.1.0 to 2.5.1.2 in /Library/Homebrew/test
Bumps [parser](https://github.com/whitequark/parser) from 2.5.1.0 to 2.5.1.2.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v2.5.1.0...v2.5.1.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-09-12 05:26:07 +00:00
dependabot[bot]
e75ed35a44
Bump rspec-expectations from 3.8.0 to 3.8.1 in /Library/Homebrew/test
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations) from 3.8.0 to 3.8.1.
- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.8.0...v3.8.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-09-12 05:26:05 +00:00
dependabot[bot]
0c1fea35ff
Bump docile from 1.3.0 to 1.3.1 in /Library/Homebrew/test
Bumps [docile](https://github.com/ms-ati/docile) from 1.3.0 to 1.3.1.
- [Release notes](https://github.com/ms-ati/docile/releases)
- [Changelog](https://github.com/ms-ati/docile/blob/master/HISTORY.md)
- [Commits](https://github.com/ms-ati/docile/compare/v1.3.0...v1.3.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-09-12 05:25:41 +00:00
Shaun Jackman
f6093961ef Add Homebrew::DEFAULT_PREFIX for Linux
The default prefix is /usr/local on macOS
and /home/linuxbrew/.linuxbrew on Linux.
2018-09-11 09:57:08 -07:00
commitay
6053b6dc5b make dependency_order_cop a regular audit 2018-09-09 08:30:57 +10:00
Claudia
45bbf043c3
Merge pull request #4852 from amyspark/quarantine-per-install
Cask: fixes for quarantining
2018-09-08 22:47:50 +02:00
Markus Reiter
7bb35e1683
Merge pull request #4847 from reitermarkus/range-support
Check for range support instead of rescuing error.
2018-09-08 15:50:03 +02:00
Shaun Jackman
922843f047
Merge pull request #4849 from jamescostian/shellenv
Add brew shellenv - see #4780
2018-09-07 13:28:42 -07:00
James Costian
18d38d7b76
Add brew shellenv - see #4780 2018-09-07 11:37:14 -05:00
L. E. Segovia
ab31af2b4b
Cask: fixes for quarantining
Gatekeeper's Path Randomization is currently making automated
installation a nightmare. Let's manually toggle the (undocumented) app
translocation bit in the `com.apple.quarantine` extended attribute.

While we're at it, let's also toss in some fixes:

- zip downloads with improper permissions that prevent us from
quarantining
- quarantine/release/skip downloads as requested by the user
2018-09-07 15:37:31 +00:00
Mike McQuaid
7615d3a812
Improve writable directory handling
Consolidate the handling of which directories need to exist and which
need to be writable. Additionally, add a fatal check for formula
installations to ensure that any directories that need to be writable
are so before attempting an installation.

Fixes #4626.
2018-09-06 18:38:43 +01:00
Markus Reiter
072127197a Check for range support instead of rescuing error. 2018-09-06 16:25:22 +02:00
Markus Reiter
a84a1c63db Rename Hbc module to Cask. 2018-09-06 09:30:52 +02:00
Markus Reiter
78d4db2755 Use classes for instance doubles. 2018-09-06 09:13:21 +02:00
Markus Reiter
cf49788d3a Rename test/cask/cli to test/cask/cmd. 2018-09-06 08:33:51 +02:00