L. E. Segovia
eaae7f3a5b
Fix last remaining style issues
2017-11-02 09:56:51 -03:00
L. E. Segovia
7f398d01b8
Turn ifs into multiple lines
2017-11-01 22:35:41 -03:00
Isabell Long
5cbb414797
formula_desc_cop: Fix the 'full stop at end of description' autocorrect
...
- It wasn't working because desc strings end in quotes, not just full
stops.
2017-11-01 19:50:56 +00:00
Isabell Long
0786d41693
formula_desc_cop: If desc ends with 'etc.', it's not a violation
2017-11-01 19:50:56 +00:00
Dominyk Tiller
6ecf269f93
doc/Xcode: update for Xcode 9.1 release
2017-11-01 04:49:47 +00:00
Dominyk Tiller
50c09f8c57
xcode: expect Xcode 9.1 on Sierra & High Sierra
2017-11-01 04:48:52 +00:00
Dominyk Tiller
6937f6fa55
mac: update for Xcode 9.1
2017-11-01 04:46:23 +00:00
Hassan F
af161082dd
Capitalized words
...
Capitalized beginning of each bullet point to match style of README.md
2017-10-31 20:21:03 -07:00
Dominyk Tiller
bdc7657456
xquartz: mark 2.7.11 as latest release
2017-10-31 16:21:03 +00:00
Dominyk Tiller
eb950644c5
xquartz: add 2.7.10 & 2.7.11 releases
2017-10-31 16:20:47 +00:00
L. E. Segovia
c636be07f9
Separate do end into multiple lines
2017-10-31 09:54:30 -03:00
Markus Reiter
302bc8be22
Merge pull request #3362 from reitermarkus/system-command
...
Fix `SystemCommand` without arguments.
2017-10-31 04:58:38 +01:00
L. E. Segovia
7f2e4f583a
Finalize metadata handling and uninstall logic
2017-10-30 23:29:00 -03:00
Dominyk Tiller
bff4762d36
text_cop_spec: update go get tests
2017-10-31 01:01:42 +00:00
Dominyk Tiller
883fee78ad
text_cop: warn against go_resource usage for strict audit
2017-10-31 00:55:00 +00:00
Dominyk Tiller
8fd18eab21
text_cop: drop go_resource recommendation
2017-10-31 00:47:57 +00:00
L. E. Segovia
917c138eeb
Add tests for uninstall_* and zap stanzas
2017-10-30 20:47:40 -03:00
L. E. Segovia
9b6b0bfed7
Use #count, rewrite warning, and add pre/postflight checks too
2017-10-30 20:47:22 -03:00
Markus Reiter
2eb366ff38
Fix SystemCommand
without arguments.
2017-10-30 22:04:54 +01:00
Mike McQuaid
2d5bb029a5
Merge pull request #3387 from MikeMcQuaid/env-std-homebrew-paths
...
ENV/std: fully extend from HOMEBREW_PATH.
2017-10-30 16:09:01 +00:00
Mike McQuaid
6c9ff7f642
Merge pull request #3398 from MikeMcQuaid/hub-no-browse
...
bump-formula-pr: add --no-browse option.
2017-10-30 09:39:54 +00:00
Mike McQuaid
6ddf3f8796
bump-formula-pr: add --no-browse option.
...
If `--no-browse` is passed, don't pass the `--browse` argument to `hub`
which opens the pull request URL in a browser. Instead, output it to the
command line.
2017-10-30 09:14:53 +00:00
Mike McQuaid
7a0fdc3d03
Merge pull request #3393 from MikeMcQuaid/with_env_tweaks
...
Tweak use of with_env
2017-10-30 08:17:06 +00:00
L. E. Segovia
55727b7895
Hack a first working version of upgrade
2017-10-29 17:34:53 -03:00
Mike McQuaid
4c44266aa5
Merge pull request #3394 from MikeMcQuaid/sh-no-ps1
...
cmd/sh: set working PS1 for zsh
2017-10-29 19:17:26 +00:00
Gautham Goli
f648dd03ff
lines_cop: Update regex patterns to prevent false positives
2017-10-29 23:40:04 +05:30
Mike McQuaid
3549377478
cmd/sh: set working PS1 for zsh.
...
The `bash`, default one is broken on `zsh`.
2017-10-29 17:23:05 +00:00
Mike McQuaid
c59c0d6820
Merge pull request #3376 from tomjonandy/fix/keychain-credentials
...
Fix issue where keychain github credentials wouldn't work
2017-10-29 16:57:21 +00:00
Mike McQuaid
215f49684b
Merge pull request #2795 from issyl0/desc_no_full_stops
...
formula_desc_cop: ensure no full stops at the end of desc
2017-10-29 16:56:00 +00:00
Isabell Long
640b1e9dcb
formula_desc_cop: ensure no full stops at the end of desc
...
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
description PR. Based on ilovezfs's incantation `grep -r -E 'desc
".*\."' *.rb`, some formulae descriptions do end in full stops. (My
initial assessment of this failed to account for the fact that
descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
2017-10-29 15:19:31 +00:00
Mike McQuaid
ca189437e4
Tweak use of with_env
...
- Use it in more places where it saves code
- Allow using symbolic keys for a cleaner interface
- Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
2017-10-29 14:44:43 +00:00
Mike McQuaid
f72aba548d
ENV/std: fully extend from HOMEBREW_PATH.
...
Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add
everything from HOMEBREW_PATH. This works well with or without
environment filtering being enabled but with environment filtering it
ensures that ENV/std just builds on the original user environment.
2017-10-29 13:41:51 +00:00
Mike McQuaid
9dbff4ebbe
Merge pull request #3388 from MikeMcQuaid/bump-formula-pr-env-filtering
...
bump-formula-pr: always use HOMEBREW_PATH.
2017-10-29 13:33:16 +00:00
Mike McQuaid
e94810950d
Merge pull request #3386 from MikeMcQuaid/config-homebrew-path
...
system_config: get perl/ruby from HOMEBREW_PATH.
2017-10-29 13:32:52 +00:00
L. E. Segovia
809e820388
Check that a single uninstall_* and zap stanzas is defined
2017-10-28 20:36:41 -03:00
Mike McQuaid
e88fd4a868
bump-formula-pr: always use HOMEBREW_PATH.
...
Fixes this when using environment filtering.
2017-10-28 21:46:30 +01:00
Mike McQuaid
3448335a14
system_config: get perl/ruby from HOMEBREW_PATH.
...
This is the actual user path when env filtering is enabled.
2017-10-28 20:38:00 +01:00
Mike McQuaid
7caca57073
Merge pull request #3380 from jmsundar/apfs_tap-info
...
tap-info: handle APFS returning hash order
2017-10-28 13:08:12 +01:00
Jayendra Minakshisundar
ea7d356e08
style changes
2017-10-28 14:56:51 +05:30
Mike McQuaid
b2e2e4b917
Merge pull request #3381 from iMichka/flock
...
lock.sh: suppress error output when looking for flock
2017-10-27 16:19:05 +01:00
Mike McQuaid
4209275a58
Merge pull request #3382 from MikeMcQuaid/lines_cop_clang++
...
lines_cop: add missing e.g. clang++ regex SOL.
2017-10-27 15:56:46 +01:00
Mike McQuaid
d985838428
lines_cop: add missing e.g. clang++ regex SOL.
...
You need a start of line check in this regex (like was added in the
others) to allow things like `#{bin}/clang++`.
2017-10-27 14:58:07 +01:00
Michka Popoff
b93ed4124c
lock.sh: suppress error output when looking for flock
...
Fixes (on centos6):
which: no flock in (/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
2017-10-27 15:54:24 +02:00
Mike McQuaid
2be11f6040
Merge pull request #3373 from MikeMcQuaid/max-line-length
...
rubocop.yml: reduce tap maximum line length.
2017-10-27 14:44:18 +01:00
Mike McQuaid
47bfad64b0
rubocop.yml: re-add Homebrew metrics maximums.
2017-10-27 14:20:37 +01:00
Mike McQuaid
5a8d2352c2
rubocop.yml: reduce tap maximum line length.
2017-10-27 14:20:33 +01:00
Mike McQuaid
8aa697363b
test.flac: add flac fixture.
2017-10-27 09:33:37 +01:00
Mike McQuaid
32ce927cae
Merge pull request #3372 from MikeMcQuaid/rubocop-length-taps
...
rubocop: disable length checks.
2017-10-27 08:45:58 +01:00
Mike McQuaid
25d8771518
Merge pull request #3368 from MikeMcQuaid/unhide-readall-update-reset
...
Unhide readall and update-reset from manpage.
2017-10-27 08:45:47 +01:00
Jayendra Minakshisundar
590f06187f
tap-info: sort taps by name to handle APFS
2017-10-27 11:41:00 +05:30