14765 Commits

Author SHA1 Message Date
Mike McQuaid
ed28ed78d1 Merge pull request #3304 from richiethomas/refactor_uses
In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods
2017-10-20 18:10:31 +01:00
L. E. Segovia
95a3d53125 Fix ternary condition style 2017-10-20 13:54:58 -03:00
richiethomas
43cbf08018 Remove memoization from uses.rb, as it doesn't result in the expected time complexity savings 2017-10-20 09:42:30 -04:00
L. E. Segovia
ec92cf6498 Print only the offending command instead of the whole Cask command 2017-10-20 10:35:13 -03:00
Mike McQuaid
76cd7c7949 Merge pull request #3319 from reitermarkus/squiggly-heredocs
Use “squiggly” heredocs.
2017-10-20 14:10:50 +01:00
Claudia
e0bb978cc9 Add tests for FormulaAuditor#audit_deps
These tests cover a few aspects of the `FormulaAuditor#audit_deps`
method. The main focus is the part where FormulaAuditor checks for
dependencies on formulas which are tagged `keg_only` with the
`:provided_by_macos` reason.

For this particular kind of `keg_only` formulas, we expect
`brew audit --new-formula` to fail with a problem message like:

> Dependency 'bc' may be unnecessary as it is provided by
> macOS; try to build this formula without it.

For more details, see the relevant discussion:

[1] https://github.com/Homebrew/homebrew-core/pull/14067#issuecomment-335046151

[2] https://github.com/Homebrew/brew/pull/3290#issuecomment-335052140
2017-10-20 14:08:22 +02:00
Mike McQuaid
a2374cba6c Merge pull request #3334 from DomT4/ds_store_is_not_a_command
commands: filter out dotfiles from output
2017-10-20 11:01:27 +01:00
Mike McQuaid
59238cd343 commands: tweak find_internal_commands.
Use a more typical Ruby style.
2017-10-20 10:19:11 +01:00
Mike McQuaid
460048bcb6 Merge pull request #3302 from maxim-belkin/readall-multiple-taps
readall: allow readall-ing multiple taps at once
2017-10-20 10:16:32 +01:00
Maxim Belkin
70005859b1
build_environment: Linux env vars 2017-10-19 15:24:30 -05:00
JCount
a064751060 xcode: update to Xcode 9.0.1 on 10.12 and 10.13 2017-10-19 11:03:17 -04:00
richiethomas
b135a70c57 Fix brew style warnings 2017-10-18 20:21:49 -04:00
richiethomas
e5e84eec7d PR feedback- replace '#{HOMEBREW_LIBRARY}/Homebrew/**/*.rb' with '#{HOMEBREW_LIBRARY_PATH}/**/*.rb' 2017-10-18 18:20:44 -04:00
richiethomas
99bccaae13 Remove /cask/ from readall file filter 2017-10-18 17:44:09 -04:00
Mike McQuaid
15096e7289 Merge pull request #3279 from sjackman/pull
Support `brew pull --bottle` for taps in organizations other than Homebrew
2017-10-18 21:16:24 +01:00
Maxim Belkin
ad3886b462
readall: update documentation 2017-10-18 14:50:44 -05:00
Mike McQuaid
0ae6d2ab2f Merge pull request #3332 from sjackman/setup-ruby-path
setup-ruby-path: Ensure that Ruby is installed
2017-10-18 16:38:17 +01:00
Markus Reiter
487bec9570 Move String#undent to compat. 2017-10-18 14:39:09 +02:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
L. E. Segovia
16faf6fca9 Shorten HOMEBREW_HELP set/unset 2017-10-18 08:47:52 -03:00
L. E. Segovia
098305e679 Correct setting and deleting HOMEBREW_HELP
(and also delete the extra help_flag case, it's no longer needed)
2017-10-18 08:37:24 -03:00
L. E. Segovia
fd2b0d21c4 Only unset HOMEBREW_HELP before issuing the tap 2017-10-18 08:30:26 -03:00
Dominyk Tiller
2063e0fc52
commands: filter out dotfiles from output 2017-10-18 11:44:12 +01:00
Mike McQuaid
270b752f5d Merge pull request #3326 from sjackman/portable-ruby
portable-ruby: use rebuild with coverage support for Linux.
1.3.6
2017-10-18 11:04:56 +01:00
Mike McQuaid
3a606abaa1 Merge pull request #3229 from BenMusch/check-for-master-no-refactor
doctor: Check for branch of core tap (take 2)
2017-10-18 10:59:59 +01:00
Mike McQuaid
1d541804c8 Merge pull request #3316 from DomT4/handle_apfs_love_of_hash_order
Handle APFS returning hash order.
2017-10-18 10:55:22 +01:00
Mike McQuaid
1e4581ff85 Merge pull request #3330 from MikeMcQuaid/vendor-install-shasum
vendor-install: use full shasum PATH.
2017-10-18 10:54:20 +01:00
Mike McQuaid
dc9ea9c786 Merge pull request #3315 from maxim-belkin/linux-caveats-plist
caveats.rb: empty method on Linux
2017-10-18 10:48:19 +01:00
Mike McQuaid
1d40061c69 Merge pull request #3291 from JCount/lines-cop-fix-wine-universal-binary
lines_cop: add ENV.universal_binary audit exemption for wine
2017-10-18 10:32:34 +01:00
Mike McQuaid
558299b039 rubocop.yml: ignore length of manpage comments. 2017-10-18 10:29:36 +01:00
Mike McQuaid
a5c8628ffb Merge pull request #3333 from DomT4/java_versioning
java_requirement: fix Java 9 version detection
2017-10-18 10:03:39 +01:00
Mike McQuaid
c7d21dadfe Merge pull request #3270 from sjackman/os-requirement
Add depends_on :linux and :macos
2017-10-18 09:43:45 +01:00
Markus Reiter
c4e8c7906d Merge pull request #3329 from ashfurrow/messaging
Specifies which errant version of Ruby is used in raise.
2017-10-18 08:15:48 +02:00
Dominyk Tiller
19790679bc
java_requirement: fix detection of new Java versioning scheme
Closes https://github.com/Homebrew/brew/issues/3331.
2017-10-18 07:13:33 +01:00
richiethomas
dfaaada8b6 Memoize recursive dependency checks; reduces calls to 'f.recursive_dependencies' by an order of magnitude 2017-10-17 20:52:18 -04:00
Shaun Jackman
3ee3b78fbd pull: Move test_bot_user to a new module GitHub
Address the style issue:
C: Module has too many lines. [364/360]
2017-10-17 17:11:26 -07:00
Shaun Jackman
a7b4a4572b Regenerate Manpage.md and brew.1 2017-10-17 16:53:12 -07:00
Shaun Jackman
9cd4fff051 pull: Add --test-bot-user
Infer the name of the test-bot GitHub user if it is not provided.
2017-10-17 16:53:12 -07:00
Shaun Jackman
76021db602 pull: Add --bintray-org
Infer the name of the Bintray organization if it's not provided.
2017-10-17 16:53:12 -07:00
Shaun Jackman
230c87aff0 Rename MinimumMacOSRequirement to MacOSRequirement
Move MinimumMacOSRequirement to compat.
2017-10-17 16:16:44 -07:00
Shaun Jackman
95e144a1c8 Add depends_on :linux and :macos 2017-10-17 16:16:12 -07:00
Shaun Jackman
7a0488e803 setup-ruby-path: Ensure that Ruby is installed
Fix the error:
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.sh: line 372:
exec: : not found
2017-10-17 15:14:58 -07:00
Ash Furrow
11572c749b
Specifies which errant version of Ruby is used in raise. 2017-10-17 17:24:04 -04:00
Markus Reiter
cf349018d5 Merge pull request #3323 from reitermarkus/edit-invalid-cask
Allow editing invalid Casks.
2017-10-17 22:51:19 +02:00
Mike McQuaid
69d28f9d8f Merge pull request #3294 from DomT4/an_empty_string_is_a_naughty_desc
formula_desc_cop: empty string is not a valid desc
2017-10-17 21:29:24 +01:00
Mike McQuaid
77f3fcf254 Merge pull request #3293 from DomT4/predicate_audit
audit: more *_predicate nudging/tweaks
2017-10-17 21:12:21 +01:00
Mike McQuaid
5f64d0fdcc Merge pull request #3298 from vszakats/pull302
pull: fix bintray verification failing due to redirection
2017-10-17 21:00:14 +01:00
Mike McQuaid
d601edaf57 vendor-install: use full shasum PATH.
Otherwise things can explode if there's a random `shasum`.

See #3281.
2017-10-17 20:51:32 +01:00
Shaun Jackman
90ca552ba6 portable-ruby: use rebuild with coverage support for Linux.
This will allow `simplecov` to generate coverage by rebuilding portable
Ruby with coverage support.
2017-10-16 12:26:55 -07:00
Maxim Belkin
dd9415c8d3
remove sneaky empty line 2017-10-16 12:23:27 -05:00