Merge pull request #3376 from tomjonandy/fix/keychain-credentials

Fix issue where keychain github credentials wouldn't work
2017-10-29 16:57:21 +00:00 · 2017-10-29 16:57:21 +00:00 · c59c0d6820
commit c59c0d6820
parent 215f49684b 0e991095f1
1 changed files with 2 additions and 2 deletions
--- a/Library/Homebrew/utils/github.rb
+++ b/Library/Homebrew/utils/github.rb
@ -87,8 +87,8 @@ module GitHub
  def api_credentials_type
    token, username = api_credentials
    return :none if !token || token.empty?
-    return :keychain if !username || username.empty?
-    :environment
+    return :environment if !username || username.empty?
+    :keychain
  end

  def api_credentials_error_message(response_headers, needed_scopes)