admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
14,427 Commits 15 Branches 471 Tags
Commit Graph

14427 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike McQuaid
b69d71edea system_config: handle new non-string Xcode version 2017-11-05 15:39:43 +00:00
Mike McQuaid
77e3e7e4d9 version: support to_i. 
This is needed for existing MacOS::Xcode.version calls that relied on
this returning a string. It mirrors similar behaviour for to_f.
 2017-11-05 15:39:43 +00:00
Mike McQuaid
389188ac4f mac/xquartz: compare with existing Version class. 2017-11-05 15:39:43 +00:00
Mike McQuaid
600d58f4ca mac/xcode: compare with existing Version class. 
Additionally, return null versions when it makes sense to do so. This
means that comparisons on the Xcode/CLT version do not need to be
guarded on whether Xcode/CLT is installed.
 2017-11-05 15:39:43 +00:00
Mike McQuaid
5bf0584308
Merge pull request #3420 from MikeMcQuaid/config-env-output 
system_config: output most HOMEBREW_* variables.
 2017-11-05 15:36:06 +00:00
Mike McQuaid
265797bf9e
Merge pull request #3417 from MikeMcQuaid/curl-unset-ssl-cert 
curl: unset SSL_CERT_FILE.
 2017-11-05 15:35:29 +00:00
Mike McQuaid
4892465fc4 system_config: output most HOMEBREW_* variables. 
Exclude the boring ones and exclude some that are already printed that
are just using their default values. HOMEBREW_PREFIX is the only one
where we’re always interested in the output to quickly communicate it.
 2017-11-05 14:45:36 +00:00
Mike McQuaid
1b69848119 system_config: output curl path and version. 2017-11-05 14:45:36 +00:00
Mike McQuaid
b369593cbd utils: correctly handle empty user gem env. 2017-11-05 14:45:36 +00:00
Mike McQuaid
f999a57620 brew.sh: cleanup some environment pollution. 2017-11-05 14:45:36 +00:00
Mike McQuaid
a7d74e0f53 curl: unset SSL_CERT_FILE. 2017-11-05 14:45:26 +00:00
Mike McQuaid
c3006f0f12
Merge pull request #3424 from MikeMcQuaid/services_spec_leak 
spec_helper: fix etc leak.
 2017-11-05 14:44:17 +00:00
Mike McQuaid
40af9e6f9f travis.yml: always use Homebrew Ruby. 2017-11-05 14:11:09 +00:00
Mike McQuaid
b9d9e63743 spec_helper: fix etc leak. 
Fix the `etc/bash_completion.d/_brew_services` leak from the new
bash completion in the Homebrew/homebrew-services tap.
 2017-11-05 13:20:08 +00:00
Mike McQuaid
2af98133ba
Merge pull request #3407 from DomT4/x11 
xquartz: add new versions + mark latest
 2017-11-03 18:28:46 +00:00
Mike McQuaid
872bd4f703
Merge pull request #3395 from GauthamGoli/parameters-audit-regex-fix 
lines_cop: Update regex patterns to prevent false positives
 2017-11-03 17:48:09 +00:00
Mike McQuaid
c6f40d5864
Merge pull request #3385 from MikeMcQuaid/path-fixes-cleanup 
Fix and cleanup some PATH usage.
 2017-11-03 17:45:57 +00:00
Mike McQuaid
29f81812cc brew.rb: cleanup PATH setup. 
Avoid adding all the tap commands to the PATH when not necessary.
 2017-11-03 14:50:17 +00:00
Mike McQuaid
f0b25b5482 requirement: convert Cellar path to opt path. 2017-11-03 14:50:17 +00:00
Mike McQuaid
5de7ec394b requirement: don't add /usr/local/{bin,sbin}. 
This should be considered a requirement bug if it's added.
 2017-11-03 14:50:17 +00:00
Mike McQuaid
c843fd2f12 requirement: prepend rather than append PATH. 
Otherwise this ends up behind e.g. `/usr/bin` so is pretty useless.
 2017-11-03 14:50:17 +00:00
Markus Reiter
4eeac6f884
Merge pull request #3389 from amyspark/hacktoberfest-single-zap 
Check that a single uninstall_* and zap stanza is defined
 2017-11-03 13:23:08 +01:00
ilovezfs
0ac55875c5
Merge pull request #3414 from ilovezfs/safe-navigation 
formula: fix safe navigation bug
 2017-11-02 08:15:15 -07:00
ilovezfs
3769bcc523 formula: fix safe navigation bug 
Safe navigation needs to be chained to preserve equivalence.

Fixes a bug introduced by 01e9ec9a in #3183.
 2017-11-02 07:26:00 -07:00
L. E. Segovia
eaae7f3a5b Fix last remaining style issues 2017-11-02 09:56:51 -03:00
L. E. Segovia
7f398d01b8 Turn ifs into multiple lines 2017-11-01 22:35:41 -03:00
Dominyk Tiller
bdc7657456
xquartz: mark 2.7.11 as latest release 2017-10-31 16:21:03 +00:00
Dominyk Tiller
eb950644c5
xquartz: add 2.7.10 & 2.7.11 releases 2017-10-31 16:20:47 +00:00
L. E. Segovia
c636be07f9 Separate do end into multiple lines 2017-10-31 09:54:30 -03:00
Markus Reiter
302bc8be22
Merge pull request #3362 from reitermarkus/system-command 
Fix `SystemCommand` without arguments.
 2017-10-31 04:58:38 +01:00
L. E. Segovia
917c138eeb Add tests for uninstall_* and zap stanzas 2017-10-30 20:47:40 -03:00
L. E. Segovia
9b6b0bfed7 Use #count, rewrite warning, and add pre/postflight checks too 2017-10-30 20:47:22 -03:00
Markus Reiter
2eb366ff38 Fix SystemCommand without arguments. 2017-10-30 22:04:54 +01:00
Mike McQuaid
2d5bb029a5
Merge pull request #3387 from MikeMcQuaid/env-std-homebrew-paths 
ENV/std: fully extend from HOMEBREW_PATH.
 2017-10-30 16:09:01 +00:00
Mike McQuaid
6c9ff7f642
Merge pull request #3398 from MikeMcQuaid/hub-no-browse 
bump-formula-pr: add --no-browse option.
 2017-10-30 09:39:54 +00:00
Mike McQuaid
6ddf3f8796 bump-formula-pr: add --no-browse option. 
If `--no-browse` is passed, don't pass the `--browse` argument to `hub`
which opens the pull request URL in a browser. Instead, output it to the
command line.
 2017-10-30 09:14:53 +00:00
Mike McQuaid
7a0fdc3d03
Merge pull request #3393 from MikeMcQuaid/with_env_tweaks 
Tweak use of with_env
 2017-10-30 08:17:06 +00:00
Mike McQuaid
4c44266aa5
Merge pull request #3394 from MikeMcQuaid/sh-no-ps1 
cmd/sh: set working PS1 for zsh
 2017-10-29 19:17:26 +00:00
Gautham Goli
f648dd03ff lines_cop: Update regex patterns to prevent false positives 2017-10-29 23:40:04 +05:30
Mike McQuaid
3549377478 cmd/sh: set working PS1 for zsh. 
The `bash`, default one is broken on `zsh`.
 2017-10-29 17:23:05 +00:00
Mike McQuaid
c59c0d6820
Merge pull request #3376 from tomjonandy/fix/keychain-credentials 
Fix issue where keychain github credentials wouldn't work
 2017-10-29 16:57:21 +00:00
Mike McQuaid
215f49684b
Merge pull request #2795 from issyl0/desc_no_full_stops 
formula_desc_cop: ensure no full stops at the end of desc
 2017-10-29 16:56:00 +00:00
Isabell Long
640b1e9dcb formula_desc_cop: ensure no full stops at the end of desc 
- This was a suggestion by Mike McQuaid in my `homebrew-core` audit
  description PR. Based on ilovezfs's incantation `grep -r -E 'desc
  ".*\."' *.rb`, some formulae descriptions do end in full stops. (My
  initial assessment of this failed to account for the fact that
  descriptions are strings and so end in `"`.)
- Add an autocorrect for this cop, too.
 2017-10-29 15:19:31 +00:00
Mike McQuaid
ca189437e4 Tweak use of with_env 
- Use it in more places where it saves code
- Allow using symbolic keys for a cleaner interface
- Use `HOMEBREW_GEM_*` instead of `GEM_OLD_*`
 2017-10-29 14:44:43 +00:00
Mike McQuaid
f72aba548d ENV/std: fully extend from HOMEBREW_PATH. 
Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add
everything from HOMEBREW_PATH. This works well with or without
environment filtering being enabled but with environment filtering it
ensures that ENV/std just builds on the original user environment.
 2017-10-29 13:41:51 +00:00
Mike McQuaid
9dbff4ebbe
Merge pull request #3388 from MikeMcQuaid/bump-formula-pr-env-filtering 
bump-formula-pr: always use HOMEBREW_PATH.
 2017-10-29 13:33:16 +00:00
Mike McQuaid
e94810950d
Merge pull request #3386 from MikeMcQuaid/config-homebrew-path 
system_config: get perl/ruby from HOMEBREW_PATH.
 2017-10-29 13:32:52 +00:00
L. E. Segovia
809e820388 Check that a single uninstall_* and zap stanzas is defined 2017-10-28 20:36:41 -03:00
Mike McQuaid
e88fd4a868 bump-formula-pr: always use HOMEBREW_PATH. 
Fixes this when using environment filtering.
 2017-10-28 21:46:30 +01:00
Mike McQuaid
3448335a14 system_config: get perl/ruby from HOMEBREW_PATH. 
This is the actual user path when env filtering is enabled.
 2017-10-28 20:38:00 +01:00