14395 Commits

Author SHA1 Message Date
Dominyk Tiller
075f818118
formula_desc_cop: empty string is not a valid desc
Just a slightly tweaked version of https://github.com/Homebrew/brew/issues/3286#issuecomment-334983011
2017-10-14 02:48:55 +01:00
Markus Reiter
e1808bf0e3 Merge pull request #3309 from reitermarkus/system-command
Refactor `SystemCommand`.
2017-10-14 00:03:14 +02:00
Maxim Belkin
5140c741f3
caveats.rb: empty method on Linux 2017-10-13 13:26:14 -05:00
Markus Reiter
c3ff748609 Merge pull request #3314 from davidchall/patch-1
Update docs: homebrew/livecheck
2017-10-13 19:28:02 +02:00
Gautham Goli
7fa51f71f1 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-13 19:50:46 +05:30
David C Hall
8fc559f319 Update docs: homebrew/livecheck 2017-10-13 09:47:39 -04:00
ilovezfs
64270ed85c Merge pull request #3312 from ilovezfs/remove-rake-dsl
fileutils: deprecate rake DSL
2017-10-13 03:24:19 -07:00
ilovezfs
82afe5d7f7 fileutils: deprecate rake DSL
superenv and the `:ruby` requirement make a `rake` DSL unnecessary.
2017-10-13 02:01:28 -07:00
Richie Thomas
9ef82ae1e2 In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods 2017-10-12 17:38:02 -04:00
Markus Reiter
c931a1be38 Refactor SystemCommand. 2017-10-12 23:33:05 +02:00
Markus Reiter
30b84ac6f3 Merge pull request #3303 from reitermarkus/special-file-names
Properly handle special characters in file names.
2017-10-12 19:56:06 +02:00
Markus Reiter
04801a2824 Merge pull request #3295 from reitermarkus/code-style
Set RuboCop maximum to current maximum.
2017-10-12 19:55:01 +02:00
L. E. Segovia
0998e16e81 Fix mistaken &
I meant to verify that both a cmd and a help flag were received from the
shell
2017-10-12 11:20:04 -03:00
L. E. Segovia
cc8e455911 Remove unknown_command variable 2017-10-12 07:39:53 -03:00
L. E. Segovia
d1262868a9 Fixes help querying
- If a non-existent command with a flag is queried to Cask, the latter
is printed instead of the command
 - If the help from a not-yet-tapped cask's command is queried, it
prints brew tap's help infinitely

Fixes caskroom/homebrew-cask#28977
2017-10-12 00:11:11 -03:00
Markus Reiter
04363b25a3 Properly handle special characters in file names. 2017-10-11 17:43:54 +02:00
Maxim Belkin
4c0e623bd4
readall: allow readall-ing multiple taps at once 2017-10-10 17:54:42 -05:00
Markus Reiter
5b8a3d381b Refactor MacOS::languages. 2017-10-10 17:11:22 +02:00
Markus Reiter
71b6e239d7 Set RuboCop maximum to current maximum. 2017-10-10 17:00:04 +02:00
Dominyk Tiller
0865ab0d1b audit: nudge to use predicate for 'executable?' as well 2017-10-10 15:45:41 +01:00
Viktor Szakats
811f5fd145 pull: fix bintray verification failing due to redirection 2017-10-10 13:35:49 +00:00
Dominyk Tiller
a0f4861934
audit: broaden refute_predicate nudge 2017-10-09 16:46:01 +01:00
Mike McQuaid
56458f03fc Merge pull request #3277 from sjackman/audit-notable
audit: Silence not notable on non-Homebrew taps
2017-10-08 13:41:15 -07:00
Markus Reiter
b806a53d88 Merge pull request #3278 from reitermarkus/code-style
Clean up code style and remove `.rubocop_todo.yml`.
2017-10-08 20:38:32 +02:00
Shaun Jackman
53dd0e3f28 audit: Silence not notable on non-Homebrew taps
Silence "GitHub repository not notable" on non-Homebrew taps.
2017-10-08 10:35:53 -07:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Markus Reiter
91ab116ace Merge pull request #3289 from reitermarkus/cask-loader
Fix regexes in `CaskLoader`.
1.3.5
2017-10-08 16:07:09 +02:00
Markus Reiter
c56a968128 Merge pull request #3288 from reitermarkus/fix-rubocop-tests
Fix comment location.
2017-10-08 15:57:47 +02:00
Markus Reiter
efbc1b0cb4 Add specs for CaskLoader. 2017-10-08 15:48:54 +02:00
Markus Reiter
cbd9715e5b Fix regexes in CaskLoader. 2017-10-08 15:21:04 +02:00
Markus Reiter
69e2be832c Fix comment location. 2017-10-08 14:14:24 +02:00
ilovezfs
b568179222 Merge pull request #3287 from DomT4/assert_predicate_audit
audit: tweak assert/refute_predicate audit
2017-10-08 00:05:24 -07:00
Dominyk Tiller
2a25825a12
audit: tweak assert/refute_predicate audit
Addresses some of the issues I raised in https://github.com/Homebrew/homebrew-core/pull/19127#issue-263566817.
Would still like to work out a way to check `File.exist?`-style language
inside the `test do` block exclusively but for now it's better to be
too conservative on the audit than to be overly-zealous and flag too
much.
2017-10-08 06:54:49 +01:00
ilovezfs
30ac040865 Merge pull request #3284 from reitermarkus/fix-rubocop-tests
Fix RuboCop tests.
2017-10-07 21:35:59 -07:00
Markus Reiter
bae08d5188 Don’t track files in test and vendor. 2017-10-08 01:47:12 +02:00
Markus Reiter
9795195726 Fix RuboCop tests. 2017-10-07 23:30:47 +02:00
Markus Reiter
5cbf8bdaa7 Merge pull request #3283 from reitermarkus/cask-loader
Add helper method for Cask fixture paths and refactor CaskLoader.
2017-10-07 18:30:32 +02:00
Markus Reiter
97333df4cb Add helper method for Cask fixture paths and refactor CaskLoader. 2017-10-07 16:11:25 +02:00
Markus Reiter
62315e93f8 Merge pull request #3280 from commitay/cask-internal-audit
InternalAuditModifiedCask: audit renamed Casks
2017-10-07 15:55:02 +02:00
Markus Reiter
ee6a2c4e9c Merge pull request #3282 from commitay/abstract-artifact
Cask AbstractArtifact: fix install order
2017-10-07 15:50:58 +02:00
commitay
4fde8f56ce add pkg / binary comment 2017-10-07 23:10:59 +10:00
commitay
a7cf6c1ff0 Cask AbstractArtifact: fix install order 2017-10-07 22:06:39 +10:00
commitay
d5cc68fba3 InternalAuditModifiedCask: audit renamed Casks 2017-10-07 12:53:07 +10:00
Markus Reiter
8f43d6b9f7 Merge pull request #3267 from reitermarkus/refactoring
Refactor DSL and Artifact classes.
2017-10-07 00:32:42 +02:00
Mike McQuaid
708c4e0ebd Merge pull request #3273 from MikeMcQuaid/mdfind-reject-backups
os/mac: ignore apps found in Time Machine backups.
2017-10-06 15:20:51 +01:00
ilovezfs
10491e1c30 Merge pull request #3274 from MikeMcQuaid/official-taps-remove-apache
official_taps: remove apache.
2017-10-05 21:00:48 -07:00
Mike McQuaid
3c0162a5ba Merge pull request #3269 from DomT4/assert_predicate
audit: prefer assert/refute_predicate over File.exist?
2017-10-06 04:34:56 +01:00
Mike McQuaid
dd2083d03d Merge pull request #3262 from kabel/version-detect-php
Add version detection support for php URL
2017-10-06 04:34:12 +01:00
Mike McQuaid
0b10596080 Merge pull request #3272 from pseudocody/master
Fixing link to CODE_OF_CONDUCT.md within README.md
2017-10-06 04:33:50 +01:00
Mike McQuaid
1c0f12307b official_taps: remove apache.
It's now deprecated.
2017-10-05 20:33:22 -07:00