14395 Commits

Author SHA1 Message Date
Markus Reiter
f0a512ace4 Don’t use Style/StderrPuts. 2017-10-24 19:39:40 +02:00
Markus Reiter
7e970216a3 Refactor and fix RuboCop specs. 2017-10-24 19:39:40 +02:00
Markus Reiter
fd29511bae Update to RuboCop 0.51. 2017-10-24 19:39:40 +02:00
Mike McQuaid
d067b5f434 lines_cop: fix clang detection.
We only care about e.g. `gcc`/`llvm-gcc`/`clang` being at the beginning
of a `system` call and not anywhere within the string.
2017-10-24 16:03:13 +01:00
L. E. Segovia
09e26b1152 brew style fixes 2017-10-24 10:17:11 -03:00
Mike McQuaid
cd61430bad Merge pull request #3360 from ilovezfs/github-formula-name-in-issue-title
github: require formula name to be in issue title
2017-10-24 13:28:09 +01:00
L. E. Segovia
2bfc7904fb Simplify cask help check 2017-10-24 08:04:49 -03:00
ilovezfs
1937625d86 github: require formula name to be in issue title 2017-10-24 03:07:33 -07:00
Mike McQuaid
7f46dcfa35 Merge pull request #3313 from GauthamGoli/audit_line_rubocop_part_4_rebase_attempt_1
audit: Port line_problems to rubocop and add tests part 4
2017-10-24 10:36:31 +01:00
Mike McQuaid
78b012740c Merge pull request #3345 from maxim-belkin/coffee-leaves
leaves: account for requirements
2017-10-24 10:28:51 +01:00
Mike McQuaid
d5e32300bf Merge pull request #3358 from maxim-belkin/build-env2
build_environment: add Linux-specific environment variables
2017-10-24 10:04:29 +01:00
Jonathan Chang
6554b2595b docs: fix poor visibility in syntax highlighting 2017-10-23 11:22:08 -07:00
Mike McQuaid
357b7bb0b7 Merge pull request #3350 from DomT4/gpg_executable
gpg: a little intentional yak shaving
2017-10-22 19:48:57 +01:00
Mike McQuaid
a1ff34dfad Merge pull request #3351 from DomT4/checksum_doc
Checksum_Deprecation: tweak phrasing/explanation/etc
2017-10-22 19:48:09 +01:00
Mike McQuaid
7e4f42369f Merge pull request #3337 from sjackman/pull
pull: Fix pull --bottle 1234
2017-10-22 19:40:24 +01:00
Shaun Jackman
f9d42659ea pull: Fix pull --bottle 1234
Fix the error:
Error: undefined method `casecmp' for nil:NilClass
2017-10-22 08:52:16 -07:00
Dominyk Tiller
71ef1b091a
Checksum_Deprecation: tweak phrasing/explanation/etc 2017-10-22 05:31:53 +01:00
Dominyk Tiller
1b084b5aa0
gpg2_requirement: use direct 'available?' logic 2017-10-22 05:11:52 +01:00
Dominyk Tiller
dad939c4d1
gpg: make executable a function, not a constant
It's a lot nicer to call `Gpg.executable` rather than
`Gpg::GPG_EXECUTABLE` externally. Also squash some logic.
2017-10-22 05:11:25 +01:00
L. E. Segovia
a8ee54a35f Actually check that the command name was set before adding it to args 2017-10-21 15:43:20 -03:00
Mike McQuaid
ce0e96c320 Merge pull request #3347 from DomT4/apfs_diagnostic
diagnostic: handle APFS returning hash order
2017-10-21 16:52:59 +01:00
Gautham Goli
7b2fab8ec5 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 13:53:44 +05:30
Gautham Goli
ee35d65867 lines_cop: Refactor to multiple cops and fix style violations 2017-10-21 12:50:49 +05:30
L. E. Segovia
10cbc77af9 Fix brew style errors 2017-10-20 20:21:38 -03:00
Markus Reiter
a08f1c6748 Merge pull request #3343 from reitermarkus/rubocop-cask
Update `rubocop-cask` version.
2017-10-20 23:47:03 +02:00
Dominyk Tiller
212367ee7e
diagnostic: handle APFS returning hash order 2017-10-20 22:44:11 +01:00
Gautham Goli
bdc7eba4b3 Merge branch 'master' into audit_line_rubocop_part_4_rebase_attempt_1 2017-10-21 01:48:00 +05:30
L. E. Segovia
75de4db003 Let Cask handle the -h flag 2017-10-20 16:51:26 -03:00
Maxim Belkin
313410035d
leaves: account for requirements 2017-10-20 14:21:21 -05:00
Markus Reiter
44147409e3 Update rubocop-cask version. 2017-10-20 20:28:28 +02:00
Mike McQuaid
6fe7c5fc95 Merge pull request #3335 from JCount/xcode-9.0.1
xcode: update to Xcode 9.0.1 on 10.12 and 10.13
2017-10-20 18:11:32 +01:00
Mike McQuaid
ed28ed78d1 Merge pull request #3304 from richiethomas/refactor_uses
In 'readall.rb', replaced multi-step 'each' loop with one-line method chain of Ruby enumerator methods
2017-10-20 18:10:31 +01:00
L. E. Segovia
95a3d53125 Fix ternary condition style 2017-10-20 13:54:58 -03:00
richiethomas
43cbf08018 Remove memoization from uses.rb, as it doesn't result in the expected time complexity savings 2017-10-20 09:42:30 -04:00
L. E. Segovia
ec92cf6498 Print only the offending command instead of the whole Cask command 2017-10-20 10:35:13 -03:00
Mike McQuaid
76cd7c7949 Merge pull request #3319 from reitermarkus/squiggly-heredocs
Use “squiggly” heredocs.
2017-10-20 14:10:50 +01:00
Mike McQuaid
a2374cba6c Merge pull request #3334 from DomT4/ds_store_is_not_a_command
commands: filter out dotfiles from output
2017-10-20 11:01:27 +01:00
Mike McQuaid
59238cd343 commands: tweak find_internal_commands.
Use a more typical Ruby style.
2017-10-20 10:19:11 +01:00
Mike McQuaid
460048bcb6 Merge pull request #3302 from maxim-belkin/readall-multiple-taps
readall: allow readall-ing multiple taps at once
2017-10-20 10:16:32 +01:00
Maxim Belkin
70005859b1
build_environment: Linux env vars 2017-10-19 15:24:30 -05:00
JCount
a064751060 xcode: update to Xcode 9.0.1 on 10.12 and 10.13 2017-10-19 11:03:17 -04:00
richiethomas
b135a70c57 Fix brew style warnings 2017-10-18 20:21:49 -04:00
richiethomas
e5e84eec7d PR feedback- replace '#{HOMEBREW_LIBRARY}/Homebrew/**/*.rb' with '#{HOMEBREW_LIBRARY_PATH}/**/*.rb' 2017-10-18 18:20:44 -04:00
richiethomas
99bccaae13 Remove /cask/ from readall file filter 2017-10-18 17:44:09 -04:00
Mike McQuaid
15096e7289 Merge pull request #3279 from sjackman/pull
Support `brew pull --bottle` for taps in organizations other than Homebrew
2017-10-18 21:16:24 +01:00
Maxim Belkin
ad3886b462
readall: update documentation 2017-10-18 14:50:44 -05:00
Mike McQuaid
0ae6d2ab2f Merge pull request #3332 from sjackman/setup-ruby-path
setup-ruby-path: Ensure that Ruby is installed
2017-10-18 16:38:17 +01:00
Markus Reiter
487bec9570 Move String#undent to compat. 2017-10-18 14:39:09 +02:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
L. E. Segovia
16faf6fca9 Shorten HOMEBREW_HELP set/unset 2017-10-18 08:47:52 -03:00