Issy Long
81b0e41183
rubocop: Alphabetize list of cops, put Bundler/GemFilename first
2023-03-02 22:13:55 +00:00
Issy Long
e05cd2c542
rubocop: In-line Style/HashAsLastArrayItem disablement
...
- We want to move away from `Excludes:` in the main `.rubocop.yml` config file
containing full file paths, because it's hard to track whether they're still
necessary or not (and other occurrences in the files that you might
legitimately want to improve are unaccounted for).
2023-03-02 22:11:05 +00:00
Douglas Eichelberger
0384b82adc
Merge pull request #14826 from dduugg/no-open-struct
...
Enable Style/OpenStructUse cop
2023-03-02 12:30:28 -08:00
Mike McQuaid
fe89c0ce41
Merge pull request #14842 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-rails-2.18.0
...
build(deps): bump rubocop-rails from 2.17.4 to 2.18.0 in /Library/Homebrew
2023-03-02 20:16:34 +00:00
BrewTestBot
6bca00e542
Update RBI files for rubocop-rails.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-03-02 20:00:16 +00:00
Douglas Eichelberger
ef2baee799
disable false positive
2023-03-02 11:49:09 -08:00
Douglas Eichelberger
a5aef97851
brew style --fix
2023-03-02 11:49:09 -08:00
Douglas Eichelberger
71402a9a41
Disable false positive violation
2023-03-02 11:49:09 -08:00
Douglas Eichelberger
985b0c1b2a
Disable Rails cops in bootsnap
2023-03-02 11:49:09 -08:00
Douglas Eichelberger
6d7ff7afee
Rename rubocop:disable
2023-03-02 11:49:09 -08:00
BrewTestBot
34c51be5bc
Update RBI files for rubocop-rails.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-03-02 11:49:09 -08:00
BrewTestBot
6f5a592217
brew vendor-gems: commit updates.
2023-03-02 11:49:09 -08:00
dependabot[bot]
0fb581b70e
build(deps): bump rubocop-rails in /Library/Homebrew
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.17.4 to 2.18.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.17.4...v2.18.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-03-02 11:49:09 -08:00
Mike McQuaid
62ee6faa58
Merge pull request #14802 from MikeMcQuaid/update_report_handle_formula_names
...
Show New/Deleted Formulae/Casks from `brew update`
2023-03-02 14:16:13 +00:00
Bo Anderson
10dd6a30ca
Merge pull request #14857 from Homebrew/buildpulse
...
dev-cmd/tests: better output for BuildPulse failures
2023-03-01 22:38:25 +00:00
Bo Anderson
c32a1b8104
dev-cmd/tests: ignore BuildPulse failures for now
2023-03-01 22:21:45 +00:00
Mike McQuaid
97fbd89a57
Merge pull request #14845 from samford/livecheck/add-xml-strategy
...
livecheck: Add Xml strategy
2023-03-01 22:21:13 +00:00
Bo Anderson
f4067ac5fe
dev-cmd/tests: better output for BuildPulse failures
2023-03-01 20:42:50 +00:00
Douglas Eichelberger
965b19b30f
Suggest fix
2023-03-01 07:16:24 -08:00
Mike McQuaid
f3cf599971
Merge pull request #14853 from cafferata/docs-tips-and-tricks-remove-atom-editor-plugin
...
Docs: Tips and Tricks - Remove Atom editor plugin
2023-03-01 15:12:45 +00:00
Jeffrey Cafferata
fd5e6e3e47
Docs: Removed the Atom editor plugin because GitHub has archived the Atom project(s).
2023-03-01 15:55:44 +01:00
Mike McQuaid
d43824d49f
Merge pull request #14849 from bayandin/fix-alias-loading
...
formula: fix alias loading
2023-03-01 12:36:17 +00:00
Mike McQuaid
c0bae192e5
Merge pull request #14624 from DenizUgur/service_run_at_load
...
dedicated `run_at_load` property
2023-03-01 12:35:15 +00:00
Mike McQuaid
cae7aad141
Merge pull request #14713 from apainintheneck/cask-to-h-without-api
...
cask: `to_h` without api
2023-03-01 12:34:41 +00:00
Mike McQuaid
a3cc4bcc59
Merge pull request #14850 from issyl0/rubocop-consolidation
...
rubocop: Consolidate more rules into the right files
2023-03-01 12:25:40 +00:00
Mike McQuaid
9296db0c41
Merge pull request #14839 from hyuraku/move-cask/cmd/info-to-cask/info
...
Move `cask/cmd/info` to `cask/info`
2023-03-01 12:25:26 +00:00
Issy Long
d16b241f4c
rubocop: Consolidate Style/BlockDelimiters config into one file
2023-03-01 11:46:54 +00:00
Mike McQuaid
6811559456
Merge pull request #14848 from apainintheneck/missing-version-variable-fix
2023-03-01 11:38:05 +00:00
hyuraku
3e3ba7642c
remove useless method
2023-03-01 20:37:04 +09:00
Alexander Bayandin
9b4f29e47c
formula: fix alias loading
2023-03-01 09:44:57 +00:00
apainintheneck
64ef2f1899
cask/cmd/upgrade: fix missing versions variable
...
This reference to the versions variable is unnecessary.
2023-02-28 22:58:00 -08:00
apainintheneck
9087afba74
Add baseline test for Cask#to_h
...
Also, added a test for loading JSON files in the cask loader.
2023-02-28 21:43:02 -08:00
apainintheneck
c19017c6bd
Make Cask#to_h work without the API
...
Set metadata when we load casks from the source API.
Set `@tap_git_head` manually.
Also, allow `auto_update` to receive false.
This is only done for consistency.
Stop double printing the `kext` caveat.
Handle Array elements correctly when substituting
path elements in artifacts. This affected how the
Uninstall Signal keys were evaluated (they are
represented as arrays of arrays).
2023-02-28 19:36:20 -08:00
apainintheneck
39dd7e987d
stop loading Cask#to_h from api
2023-02-28 18:00:38 -08:00
Issy Long
b1eaf8bbd2
rubocop: Move Style/DocumentationMethod into the other file
2023-03-01 00:02:22 +00:00
Douglas Eichelberger
719f1d6c6e
Refactor some use of OpenStruct
2023-02-28 13:05:43 -08:00
Sam Ford
7d9e1a50e8
livecheck: Add Xml strategy
...
This adds a generic `Xml` strategy to livecheck that requires a
`strategy` block to operate. The XML-parsing code is taken from the
existing approach in the `Sparkle` strategy. As such, `Sparkle` has
been updated to use the `Xml#parse_xml` method instead.
Unlike the `Json` strategy, we don't currently have any `strategy`
blocks in first-party taps that manually parse XML. However, we had a
user request support for something like this and I was already working
on an `Xml` strategy (as a way of extracting the XML-parsing code
from `Sparkle` into something general-purpose), so here we are.
Future strategies that parse simple XML data can potentially use the
`Xml#find_versions` method (similar to how we have strategies that
leverage `PageMatch#find_versions`) instead of having to implement
something bespoke like `Sparkle`.
2023-02-28 14:58:11 -05:00
Douglas Eichelberger
e6ddf8c958
Enable Style/OpenStructUse cop
2023-02-28 11:12:54 -08:00
Mike McQuaid
2451d017f9
update-report: allow additions/deletions from the API.
...
If we're installing from the API: we cannot use Git to check for differences in
packages so instead use `{formula,cask}_names.txt` to do so.
The first time this runs: we won't yet have a base state
(`{formula,cask}_names.before.txt`) to compare against so we don't output
anything and just copy the files for next time.
2023-02-28 16:46:44 +00:00
Mike McQuaid
7c15dce285
Merge pull request #14798 from MikeMcQuaid/deprecate_shell
...
Deprecate `preferred_shell` and `shell_profile`.
2023-02-28 15:18:00 +00:00
Mike McQuaid
32463227ac
Deprecate preferred_shell and shell_profile.
...
I know that we're outside our normal deprecation cycle but: these are
totally broken with the API and it doesn't make sense to support them
only for non-core formulae.
2023-02-28 15:02:06 +00:00
hyuraku
198c6f6b8c
move cask/cmd/info_spec to cask/info_spec
2023-03-01 00:01:28 +09:00
hyuraku
efdef5f26c
move cask/cmd/info to cask/info
2023-03-01 00:00:54 +09:00
Mike McQuaid
5dbf95958b
Merge pull request #14838 from Homebrew/sponsors-maintainers-man-completions
...
Update manpage and completions.
2023-02-28 14:22:13 +00:00
BrewTestBot
26e5768bc9
Update manpage and completions.
...
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml ) workflow.
2023-02-28 14:06:12 +00:00
Carlo Cabrera
1201f18db0
Merge pull request #14667 from carlocab/update-reset-tap-names
...
cmd/update-reset: improve arg parsing
2023-02-28 22:05:10 +08:00
Issy Long
a2b488cd10
Merge pull request #14818 from issyl0/rubocop-documentation
...
rubocop: Only enable `Style/Documentation` for `@api public` code
2023-02-28 13:47:13 +00:00
Carlo Cabrera
e2082f0c53
workflows/tests: avoid resetting homebrew/bundle
...
This command was being called with the wrong relative path, so it
silently did nothing. Now that `update-reset` errors out from invalid
arguments, we know that running `update-reset` here is not needed.
2023-02-28 21:47:08 +08:00
Issy Long
e82869b3ac
ci: Fix working directory for RuboCop filepath step?
2023-02-28 13:30:19 +00:00
Mike McQuaid
70d3417319
Merge pull request #14823 from issyl0/contributions-reviews-approved
...
dev-cmd/contributions: Only count approving reviews
2023-02-28 13:22:52 +00:00