dev-cmd/tests: better output for BuildPulse failures

This commit is contained in:
Bo Anderson 2023-03-01 20:09:27 +00:00
parent f3cf599971
commit f4067ac5fe
No known key found for this signature in database
GPG Key ID: 3DB94E204E137D65

View File

@ -62,11 +62,12 @@ module Homebrew
ohai "Sending test results to BuildPulse"
result = quiet_system Formula["buildpulse-test-reporter"].opt_bin/"buildpulse-test-reporter",
"submit", "#{HOMEBREW_LIBRARY_PATH}/test/junit",
"--account-id", ENV.fetch("HOMEBREW_BUILDPULSE_ACCOUNT_ID"),
"--repository-id", ENV.fetch("HOMEBREW_BUILDPULSE_REPOSITORY_ID")
odie "Failed to send test results to BuildPulse!" unless result
system_command! Formula["buildpulse-test-reporter"].opt_bin/"buildpulse-test-reporter",
args: [
"submit", "#{HOMEBREW_LIBRARY_PATH}/test/junit",
"--account-id", ENV.fetch("HOMEBREW_BUILDPULSE_ACCOUNT_ID"),
"--repository-id", ENV.fetch("HOMEBREW_BUILDPULSE_REPOSITORY_ID")
]
end
def changed_test_files
@ -191,10 +192,11 @@ module Homebrew
else
system "bundle", "exec", "rspec", *bundle_args, "--", *files
end
success = $CHILD_STATUS.success?
run_buildpulse if use_buildpulse?
return if $CHILD_STATUS.success?
return if success
Homebrew.failed = true
end