admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
11,363 Commits 15 Branches 471 Tags
Commit Graph

11363 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike McQuaid
727263e906 development_tools: don't create Versions from nil 
This cause issues when e.g. using `debrew.rb` on a failing `system`
command in a formula.
 2016-11-15 14:43:56 +00:00
Mike McQuaid
c1af8fba55 Merge pull request #1506 from MikeMcQuaid/audit-fix-version-not-decrease-again 
audit: fix "version should not decrease" (again).
 2016-11-15 12:36:06 +00:00
Mike McQuaid
5e0b3d24e5 audit: fix "version should not decrease" (again). 
- output the max version and current version to make the message more
  obvious.
- Don't compare the development spec version to the formula version and
  then complain the formula version is lower (it should always be!)
 2016-11-15 09:02:50 +00:00
Mike McQuaid
484e3e0769 Merge pull request #1498 from alyssais/uninstall_developer_warning 
Warn developers when uninstalling a dependency
 2016-11-15 08:15:42 +00:00
Misty De Meo
30fdbe089b Merge pull request #1435 from mistydemeo/dev_tools_version 
Add "null version" class, and return compiler versions/build versions as Version objects
 2016-11-14 13:44:03 -08:00
Markus Reiter
3a01fbadcd Merge pull request #1362 from reitermarkus/rubocop 
Update RuboCop to 0.45.0.
 2016-11-14 16:50:24 +01:00
Markus Reiter
ee143482e4 Merge pull request #1504 from reitermarkus/exe-cab-containers 
Fix detection of self-extracting `.exe` files.
 2016-11-14 16:49:25 +01:00
Markus Reiter
ff96f7ec26 Fix detection of self-extracting .exe files. 2016-11-14 15:30:48 +01:00
Alyssa Ross
ca3562645c uninstall: style fixes 
Works around Rubycop not liking method names that start with `is_`
by changing convention from singular to plural.

I think it's better that way anyway.
 2016-11-14 13:39:17 +00:00
Alyssa Ross
c77040b346 uninstall: clean up warnings 2016-11-14 13:09:40 +00:00
Alyssa Ross
14099ffaf3 utils: fix capture_stderr style 2016-11-14 12:28:45 +00:00
Alyssa Ross
3c310b2e3d Warn developers when uninstalling a dependency 
Suggested in #1084.

Made the existing warning output entirely to STDERR, because
previously the first line went to STDERR and subsequent ones went
to STDOUT.
 2016-11-14 12:13:34 +00:00
Mike McQuaid
c4c9c6bc0c Merge pull request #1501 from MikeMcQuaid/no-complain-brew-install-args 
Don't warn about unused `brew install` arguments.
 2016-11-14 12:09:44 +00:00
Mike McQuaid
cc3bf7bcb5 Don't warn about unused brew install arguments. 
This is a step closer to better argument handling but for now just
fixes the issue in #1217 where it starts complaining about options like
`--build-from-source` being used.
 2016-11-14 09:28:28 +00:00
Markus Reiter
6c1d42386d Remove flat_map compatibility layer. 2016-11-14 09:45:44 +01:00
Markus Reiter
353b67a6b2 No empty whens. 2016-11-14 09:45:44 +01:00
Mike McQuaid
5294b99d6f Merge pull request #1500 from JCount/formula_versions-devel-fix 
formula_versions: fix erroneous :stable in version_attributes_map
 2016-11-14 08:15:14 +00:00
Mike McQuaid
bffa38308b Merge pull request #1494 from aw1621107/add-frounding-math 
cc: Add -frounding-math to list of ignored flags
 2016-11-14 08:09:55 +00:00
Mike McQuaid
5a5cbe41bd Merge pull request #1497 from alyssais/uninstall_keg_to_formula 
keg: don't rely on #to_formula
 2016-11-14 08:02:51 +00:00
JCount
cfdbe9c645 formula_versions: fix erroneous :stable in version_attributes_map 2016-11-13 22:27:45 -05:00
Alyssa Ross
f7f72093a8 keg: don't rely on #to_formula 
It doesn't always work.
For example, a keg could have been installed with a formula from a
URL, which Homebrew now does not know how to access.

Fixes #1496.
 2016-11-13 23:20:38 +00:00
Markus Reiter
59e2d67721 No if/unless-modifier on multiline blocks. 2016-11-13 23:37:40 +01:00
Markus Reiter
c648518f35 Rename single line block parameters to acc/elem. 2016-11-13 23:36:04 +01:00
Markus Reiter
e9391481a8 Update RuboCop to 0.45.0. 2016-11-13 23:18:08 +01:00
Markus Reiter
84b2276fd8 Use guard clauses. 2016-11-13 23:00:47 +01:00
Alex Wang
d2e2110e80 cc: Add -frounding-math to list of ignored flags 2016-11-13 16:18:19 -05:00
Mike McQuaid
fc3d586584 Merge pull request #1493 from MikeMcQuaid/audit-version-decrease-fix 
audit: fix "version should not decrease" check.
 2016-11-13 14:05:59 +00:00
Mike McQuaid
c78aa43386 audit: fix "version should not decrease" check. 
Fix the "version should not decrease" check so it correctly handles
`version_scheme`s.

Fixes #1489.
 2016-11-13 13:35:25 +00:00
Mike McQuaid
694cc876ef Merge pull request #1415 from robinkunde/semver 
Update macOS Xcode tool checks do use Version class for comparisons
 2016-11-13 10:53:34 +00:00
Mike McQuaid
2a53d14b51 Merge pull request #1217 from MatzFan/invalid_build_option_warnings 
Invalid build option warnings - supersedes #1088
 2016-11-13 10:50:51 +00:00
Mike McQuaid
b34bd4fa12 Merge pull request #1488 from MikeMcQuaid/filter-formula-options 
Filter formula build options based on those that exist.
 2016-11-13 10:50:16 +00:00
Robin Kunde
e97ce7e7ae move semantic version comparisons into separate class 2016-11-12 15:37:32 -05:00
Bruce Steedman
8ebddca0fe fix other 10 failing tests - doh 2016-11-12 12:31:35 +00:00
Mike McQuaid
82aace9844 Merge pull request #1487 from MikeMcQuaid/diagnostic-skip-xcode-select 
diagnostic: skip xcode-select check with no Xcode.
 2016-11-12 12:13:38 +00:00
Bruce Steedman
592905d3da fix test 2016-11-12 12:13:27 +00:00
Mike McQuaid
56124f5963 Filter formula build options based on those that exist. 
If `--with-foo` is provided to a formula through a tab or through
another formula depending on it and this option does not exist it
should be filtered. If it is not (the prior behaviour) then this can
prevent bottles being used unnecessarily.

Fixes #1399.
 2016-11-12 12:11:55 +00:00
Bruce Steedman
098974b2a1 @MikeMcQuaid requested changes 2016-11-12 12:03:04 +00:00
Mike McQuaid
215105a484 diagnostic: skip xcode-select check with no Xcode. 
Skip the `xcode-select` configuration check if there's no CLT or Xcode
installed as in that case neither will be used.

Fixes #1055.
 2016-11-12 11:32:27 +00:00
Mike McQuaid
c4519b030e Merge pull request #1480 from devkhan/patch-1 
Typo: delet -> delete
 2016-11-12 10:49:08 +00:00
Mike McQuaid
f184eba20b Merge pull request #1486 from MikeMcQuaid/lock_dir_permissions 
Check the lock directory is writable.
 2016-11-12 10:38:08 +00:00
Mike McQuaid
fe9ce9ffce Merge pull request #1485 from MikeMcQuaid/less-tap-migrate-warnings 
formulary: don't warn on old formula name from keg/rack.
 2016-11-12 10:38:03 +00:00
Markus Reiter
05acd4202b Merge pull request #1473 from umireon/umireon-fix-cask-tests 
brew-cask tests never fail on BrewTestBot
 2016-11-12 09:52:31 +01:00
Kaito Udagawa
1a4eb14b16 cask-tests: fix cask-tests always fail on the test failure 
`brew cask-tests` collected the test results in an improper way so that it reports a false success in certain situations.
Specially, the session under BrewTestBot always reports success regardless of the test status.
With this update, the exit code of `brew cask-tests` is 1 when the test fails, and then CI preperly works.
 2016-11-12 11:48:12 +09:00
Mike McQuaid
9edf8eb1fe Check the lock directory is writable. 
And, if it isn't, print more helpful debugging messages.

Fixes #1456.
 2016-11-11 22:52:21 +00:00
Mike McQuaid
b32fafa82c formulary: don't warn on old formula name from keg/rack. 
If there’s an old installation of e.g. `apple-gcc42` from when it was
part of `homebrew/core` then the tab will say it was from the
`homebrew/core` tap and then we’ll complain at the user (see #1459 for
an example). Instead, we only want to complain when the user actually
types in `homebrew/core/apple-gcc42` into a `brew` command.

Closes #1459.
 2016-11-11 16:42:29 +00:00
Mike McQuaid
0f6cd9d7a5 Merge pull request #1483 from MikeMcQuaid/uninstall-no-kegs-needed-force 
uninstall: don't need kegs to exist for --force.
 2016-11-11 13:56:05 +00:00
Mike McQuaid
4538d80db1 uninstall: don't need kegs to exist for --force. 
Otherwise there's an error which is a regression on previous
functionality. This mirrors `rm -f` which doesn't fail if a file doesn't
exist.
 2016-11-11 13:15:49 +00:00
Markus Reiter
8241bbb15b Merge pull request #1475 from reitermarkus/fix-locations 
Fix `Hbc::Locations` in tests.
 2016-11-11 13:43:38 +01:00
Markus Reiter
8fea516dcd Merge pull request #1481 from reitermarkus/sudo-askpass 
Support `SUDO_ASKPASS` environment variable in `brew cask`.
 2016-11-11 10:56:05 +01:00
Mike McQuaid
2ce17a1137 Merge pull request #1082 from alyssais/uninstall_dependancy_error 
uninstall: refuse when dependents still installed
 2016-11-11 08:23:57 +00:00