admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
7,981 Commits 15 Branches 471 Tags
Commit Graph

363 Commits

Author SHA1 Message Date
Mike McQuaid
c294ce22a7 audit: also run brew style on --strict. 
Closes Homebrew/homebrew#35465.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-01-04 11:05:34 +00:00
Baptiste Fontaine
81986ee7a7 audit: system check fixed for multiple arguments 
Closes Homebrew/homebrew#35459.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-01-02 10:36:36 +00:00
Jack Nagel
9e335fa0b8 Revert "audit (strict): check for use double-quotes." 
This reverts commit 8fe14451842dea92bca04116ba043421b4f44a6b.

Conflicts:
	Library/Homebrew/cmd/audit.rb
 2014-12-27 17:07:30 -05:00
Mike McQuaid
e1c6a4614f Rename HEAD only tap. 2014-12-27 20:55:21 +00:00
Mike McQuaid
8458540afb audit: simplify test defined check. 2014-12-27 20:46:01 +00:00
Mike McQuaid
13239276f0 audit: improve FileUtils check. 
Match the parens properly and only interpolate once.

Closes Homebrew/homebrew#35288.
Closes Homebrew/homebrew#35291.
 2014-12-27 20:35:26 +00:00
Mike McQuaid
c4f7217811 audit (strict): add require formula check. 2014-12-27 16:31:44 +00:00
Mike McQuaid
f3a5a83452 audit (strict): check a test is present. 2014-12-27 16:31:44 +00:00
Mike McQuaid
d263c73cc4 audit (strict): whitelist 32-bit in options check. 2014-12-27 16:31:43 +00:00
Mike McQuaid
5cd8f62865 audit (strict): check for use double-quotes. 2014-12-27 16:31:43 +00:00
Mike McQuaid
c82e48b904 audit (strict): check for use of spaces in system. 2014-12-27 16:31:43 +00:00
Mike McQuaid
3e3a4cad50 audit: check for use of FileUtils methods. 2014-12-27 16:31:43 +00:00
Mike McQuaid
fca32ee7cc audit: check options when in strict mode. 2014-12-27 12:38:58 +00:00
Mike McQuaid
24f183dd12 audit: add strict mode, argument. 2014-12-27 12:38:04 +00:00
Jack Nagel
7c4324d5ea Fix formula template comment audit 2014-12-22 01:12:44 -05:00
Jack Nagel
cd7004b579 Deprecate appending the CVS module name to the URL string 2014-12-22 00:52:10 -05:00
Jack Nagel
0344d243e4 Deprecate made-up URL schemes 
This deprecates URLs that begin with the following fake URL schemes:
  bzr://
  cvs://
  hg://
  fossil://
  svn+http://

Despite their appearance, they are not actually accepted by the
corresponding tools. They exist only as hints to the download strategy
detection code, and are stripped from the URL before the URL is handed
off to the VCS program.

This is not documented, and may lead one to believe it is a valid URL
that can be used elsewhere, when it actually only works inside Homebrew.

We have a better mechanism for specifying the download strategy that is
straightforward and explicit:
  :using => :hg

Recommend that instead.

Closes Homebrew/homebrew#35114.
 2014-12-19 12:28:18 -05:00
Jack Nagel
ef48a5e7d7 Deprecate UnsafeSubversionDownloadStrategy 2014-12-18 16:45:15 -05:00
Jack Nagel
89dc0b9787 One less place where Formula is reopened 2014-11-12 21:41:14 -06:00
Jack Nagel
16a2220834 Exempt the head-only tap from the head-only audit warning 2014-11-12 21:32:44 -06:00
Jack Nagel
673f08f17e audit: compare file mode directly 2014-10-29 22:47:17 -05:00
Jack Nagel
1195718d0e Rename "f" to "formula" in the installer 2014-10-29 22:41:03 -05:00
Jack Nagel
f8c0c27566 Deprecate insecure download strategies 2014-10-18 17:39:53 -05:00
Jack Nagel
b6631b9a15 audit: call puts once instead of problems.size + 2 times 2014-10-17 00:35:51 -05:00
Jack Nagel
fb30041640 audit: loop over deps once 2014-10-17 00:11:46 -05:00
Jack Nagel
73d08fcc1a Audit devel and head deps 2014-10-17 00:08:17 -05:00
Jack Nagel
b05351d0b2 Reorganize post-install checks so we can share more code 2014-10-13 23:13:01 -05:00
Jack Nagel
b46ebf8a29 Simplify post-install audit output 2014-10-13 23:13:00 -05:00
Jack Nagel
09d53f4fc5 Remove audit whitelist 
This is currently unnecessary.
 2014-10-13 23:13:00 -05:00
Tim D. Smith
9134718f9c Audit formulæ for easy-install.pth files 
Closes Homebrew/homebrew#32860.
 2014-10-02 11:58:13 -07:00
Jack Nagel
c4818394cb Post-install audit for shadowed header files 2014-10-01 23:32:53 -05:00
chdiza
22d8380b05 audit: make has_DATA? ignore commented-out lines 
Before this change, audit would detect commented-out lines
containing the string 'DATA' as if there were no commenting.
Then it could complain, e.g., problem "'DATA' was found, but no
'__END__'", which would be a false alarm in that circumstance.

Closes Homebrew/homebrew#32568.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-09-23 15:19:13 -05:00
Jack Nagel
d7dddc8f08 Audit for outdated devel versions 2014-09-23 13:04:55 -05:00
Jack Nagel
e717508b7b audit: access the homepage attribute once 2014-09-14 15:43:20 -05:00
Mike McQuaid
d3150f3a06 audit: fix line number typo. 
Closes Homebrew/homebrew#32031.
 2014-09-02 11:50:00 +01:00
Jack Nagel
fe1bf57a15 audit: fix line number off-by-one 2014-09-01 23:25:16 -05:00
Jack Nagel
0bf3ec593d Fix false positive audit warning 2014-08-21 15:13:13 -05:00
Jack Nagel
f4ae1c9e1b Hide the options data structure better 2014-07-31 19:59:09 -05:00
Jack Nagel
dc2080bd9f Remove patch hacks from audit 2014-07-29 16:22:06 -05:00
Adam Vandenberg
bb2c9b7ba4 audit 'def test' 
Closes Homebrew/homebrew#31120
 2014-07-27 15:10:15 -07:00
Jack Nagel
72129668f4 audit: warn when using old-style patches 2014-07-11 12:46:41 -05:00
Jack Nagel
330e18bb17 Use predicate methods instead of inspecting the tags array 2014-07-01 21:57:30 -05:00
Jack Nagel
10a1952d2c Only "extend self" once on the Homebrew module 2014-06-19 13:10:36 -05:00
Jack Nagel
5c24876d02 Fix audit suggestion 2014-06-15 23:28:06 -05:00
Jack Nagel
62e79c8d09 audit: read formula text in binmode 2014-06-04 15:37:36 -05:00
Jack Nagel
9f42b6b9c7 Drop emacs dep audit 
cf. Homebrew/homebrew#24802.
 2014-05-04 22:45:57 -05:00
Adam Vandenberg
7fe9413cf1 audit: use .diff instead of .patch for github diffs 2014-04-11 07:31:56 -07:00
Lee Hanxue
af4aff8c13 brew audit: show line number for whitespace 
Closes Homebrew/homebrew#24481.
Closes Homebrew/homebrew#24490.
 2014-04-06 10:30:36 -07:00
Jack Nagel
63da62c6d0 Revert "Audit gnome URLs, prefer download.gnome.org" 
This reverts commit 557ef8df05a8ea28ed903f08b2009ebc0e218f5a.
 2014-04-03 09:29:23 -05:00
Mike McQuaid
bf8ff2dcb7 audit: check the use of Dir[] 
Sometimes `Dir[]` is used with single files/directories unnecessarily.
 2014-03-31 11:52:59 -05:00