audit (strict): add require formula check.

2014-12-27 15:59:16 +00:00 · 2014-12-27 15:59:16 +00:00 · c4f7217811
commit c4f7217811
parent f3a5a83452
1 changed files with 5 additions and 0 deletions
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@ -41,6 +41,7 @@ class FormulaText
    @text = path.open("rb", &:read)
  end

+
  def without_patch
    @text.split("\n__END__").first
  end
@ -565,6 +566,10 @@ class FormulaAuditor
        good_quotes = bad_quotes.gsub "'", "\""
        problem "use double-quotes for `#{good_quotes}` instead of `#{bad_quotes}`"
      end
+
+      if line =~ /(require ["']formula["'])/
+        problem "`#{$1}` is now unnecessary"
+      end
    end
  end