7981 Commits

Author SHA1 Message Date
Dominyk Tiller
6362b5fdba Formula-Cookbook: wording tweaks 2015-08-22 19:49:20 +01:00
Aldrin Piri
6abf63c99b Formula-Cookbook: document strict audit
Providing specific reference to the --strict option for brew audit.

Closes Homebrew/homebrew#43155.
Closes Homebrew/homebrew#43156.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
2015-08-22 19:49:19 +01:00
Xu Cheng
9f20679366 formula_installer: fix when bottle pouring when creating new bottle
Formula#bottle_specification always exists, while Formula#bottle only
exists if the bottle is available and compatible.
2015-08-22 14:19:22 +08:00
Xu Cheng
62be981016 use Pathname#executable? directly 2015-08-22 13:21:13 +08:00
Xu Cheng
a88c40b8c8 core file style update 2015-08-22 13:15:33 +08:00
Misty De Meo
3d1f9e0a9c exceptions: change 10.9 Xcode URL 2015-08-21 11:46:39 -07:00
Dominyk Tiller
bef0c9f37f cctools_requirement: quotes nit 2015-08-21 19:29:07 +01:00
Dominyk Tiller
ff8520e61b exceptions: use xcode frontpage 2015-08-21 19:28:05 +01:00
Misty De Meo
727239e12f Merge bottle install without Xcode branch
Merge branch 'bottle_hooks'
2015-08-21 11:04:22 -07:00
William Woodruff
04a0b2aafe Mark TODO in brew doctor (future PR) 2015-08-21 11:02:33 -07:00
William Woodruff
12b25f59cc Only print dep installation notice when deps will be installed 2015-08-21 11:02:33 -07:00
William Woodruff
56795ec1ed Call check_xcode check for CLT, too 2015-08-21 11:02:33 -07:00
William Woodruff
f108d204f7 Add tests for pouring bottle without Xcode
add testball_bottle formula for upcoming bottle unit testing, as well
as bottles directory containing test bottle (and symlinks)
2015-08-21 11:02:33 -07:00
William Woodruff
8793a68ee4 Add no-Xcode documentation for all classes, methods 2015-08-21 11:02:33 -07:00
William Woodruff
1face808f5 Add guards to calls that would trigger Xcode install requests
add guard in Formula#file_modified? to prevent git popup

add guard in Superenv.bin before calling MacOS::Xcode.version

add guard against missing Xcode/CLT in Xcode.uncached_version

return nil instread of 0 in uncached_version when Xcode/CLT are not present, to distinguish from linuxbrew behavior

checks against pour_bottle? and needs_relocation?, add guard around keg.relocate_install_names to check pour_bottle?/needs_relocation? as well

needs_relocation? becomes skip_relocation?, use cellar attr to indicate relocation instead of does_not_need_relocation

MacOS.can_build? becomes MacOS.has_apple_developer_tools?
2015-08-21 11:02:33 -07:00
William Woodruff
f58506ea6f FormulaInstaller: add prevent_build_flags to eliminate code repetition
remove unneeded definition

change variable in FormulaInstaller.check_build_flags from bf to build_flags
2015-08-21 10:59:35 -07:00
William Woodruff
91e598cf3f Install: add BuildToolsError and BuildFlagsError
Add these new errors, and guards in formula installation and
cmd/{,un,re}install to match, move can_build? to the MacOS module,
flatten conditions, remove redundant can_build? check

reinstate removed (doctor) check
2015-08-21 10:59:09 -07:00
William Woodruff
76dcad7c82 Split compute_and_install_dependencies
This is so so that check_dependencies_bottled can be called when bottles
are being poured; implement check_dependencies_bottled
2015-08-21 10:58:45 -07:00
William Woodruff
85187bf6d3 MacOS: update locate_cctool
This becomes MacOS.{install_name_tool,otool}, only do check_xcode if
xcode is installed, otherwise emit a warning
2015-08-21 10:58:13 -07:00
William Woodruff
8aad523063 Formula_installer: only attempt relocation install once
Check @@attempted for cctools so that we only attempt the relocation
install once, skip cxxstdlib check in cctools to prevent otool
execution prior to installation, skip fixing install names if
relocation is not required
2015-08-21 10:57:48 -07:00
William Woodruff
b46d5de492 Requirements: add CctoolsRequirement
Install it as a dependency unless already satisfied by Xcode.

require cctools_requirement

cctools_requirement should be satisfied by cctools present in opt

add build_env => false to the satify block options in CctoolsRequirement
2015-08-21 10:57:20 -07:00
William Woodruff
4d65b817ec Install: remove check_for_bad_install_name_tool
Until it can be adapted to not call otool on systems w/o XCode/CLT
2015-08-21 10:56:46 -07:00
William Woodruff
dcc394c3f7 add cctools requirement 2015-08-21 10:56:46 -07:00
William Woodruff
dcfac4f571 add install_relocation_tools stub 2015-08-21 10:56:46 -07:00
William Woodruff
ab10ab42fa BottleSpecification: add does_not_need_relocation field
Toggled with does_not_need_relocation method in bottle block.
Also declare needs_relocation? accessors in software/bottle specs.
2015-08-21 10:56:23 -07:00
Xu Cheng
1da2855c0b zsh-completion: add tap-(un)pin
Closes Homebrew/homebrew#43146.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-21 20:08:14 +08:00
Xu Cheng
329358c33c manpage: add doc for tap --list-official and --list-pinned 2015-08-21 20:08:13 +08:00
Xu Cheng
d09d2690ca tap: add --list-pinned 2015-08-21 20:08:13 +08:00
Xu Cheng
ac71386373 test-bot: tap TapDependency recursively
Closes Homebrew/homebrew#43145.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-21 15:17:21 +08:00
Dominyk Tiller
212d0b82fd xcode: update 10.11 clang 2015-08-21 03:10:18 +01:00
Xu Cheng
62d1636144 update: only update renamed when necessary 2015-08-20 20:12:02 +08:00
Vlad Shablinsky
35ef2bc132 update manpages for migrate
Closes Homebrew/homebrew#42801.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-20 19:55:35 +08:00
Vlad Shablinsky
e4480cf6bf update: add formula renames to report 2015-08-20 19:55:35 +08:00
Vlad Shablinsky
896848dd87 migrator: skip check for same taps if --force 2015-08-20 19:55:35 +08:00
Xu Cheng
fe830e4099 Requirement: support tap formula as default_formula
Closes Homebrew/homebrew#43107.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-20 17:31:17 +08:00
Xu Cheng
0bce3b3f36 TapDependency: allow passing arbitrary option_name 2015-08-20 17:31:17 +08:00
Xu Cheng
72a11b7d11 test_migrator: fix lock file leak
Closes Homebrew/homebrew#43025.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-20 15:47:42 +08:00
Xu Cheng
a628c15afd lock keg during migration 2015-08-20 15:47:42 +08:00
Xu Cheng
b6c64ae46a also lock oldname when applied 2015-08-20 15:47:41 +08:00
Xu Cheng
ab363ea1d9 CurlApacheMirrorDownloadStrategy: ignore HOMEBREW_CURL_VERBOSE
Fixes Homebrew/homebrew#43002

Closes Homebrew/homebrew#43058.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-20 15:47:33 +08:00
Xu Cheng
4740d7fad4 uninstall: simplify logic
Also reduce unnecessary disk operations

Closes Homebrew/homebrew#43024.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-18 15:58:07 +08:00
Xu Cheng
4d84ff3b03 allowing rescue https redirect error
It can be useful when implementing custom https mirror strategy such as Homebrew/homebrew#42955.

Closes Homebrew/homebrew#43020.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-18 15:55:36 +08:00
Baptiste Fontaine
8ba0fb9fcf unnecessary calls to .select simplified
These are minor perf optimizations.

Closes Homebrew/homebrew#43028.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-08-18 00:18:22 +02:00
Baptiste Fontaine
f690b54621 Suggest 'brew uninstall' everywhere for consistency
Mixing 'brew remove' with 'brew uninstall' can confuse users.

Closes Homebrew/homebrew#43026.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
2015-08-17 20:36:02 +02:00
Xu Cheng
b4ddaecf75 improve zsh_completion
Closes Homebrew/homebrew#43016.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-17 16:21:09 +08:00
Xu Cheng
502101a2e2 manpage: slight format tweak 2015-08-17 16:12:29 +08:00
Xu Cheng
a380ec636e enable sandbox on test-bot
Closes Homebrew/homebrew#43014.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-17 14:12:11 +08:00
Dominyk Tiller
63a7f29270 cleanup: require thread 2015-08-16 21:01:52 +01:00
Xu Cheng
c4df86eb9d cleanup: speed up rm_DS_Store by multithread
Before

```
$ time brew cleanup -s
brew cleanup -s  0.73s user 3.52s system 58% cpu 7.297 total
```

After

```
$ time brew cleanup -s
brew cleanup -s  0.69s user 2.57s system 139% cpu 2.341 total
```

Closes Homebrew/homebrew#42968.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-17 01:54:03 +08:00
Vlad Shablinsky
dc4feaf56b test_keg: add tests for oldname optlink
Closes Homebrew/homebrew#42998.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-08-17 01:53:58 +08:00