admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
15,907 Commits 15 Branches 471 Tags
Commit Graph

817 Commits

Author SHA1 Message Date
JCount
09a926f449 Merge pull request #2338 from JCount/audit-online-file-download 
audit: online - limit download time based on HTTPS determination
 2017-03-18 16:03:17 -04:00
JCount
5e8a9fa3f3 audit: online - limit download time based on HTTPS determination 
Previously, the http_content_headers_and_checksum method always
downloaded the entire url, including headers. These downloads
periodically hang, outputting false positives or wreaking havoc on
the CI. Therefore, use curl's --max-time arg to prevent this by
setting a hard limit of 600 seconds when the entire file is going
to be used to detect whether the url can be changed to use the HTTPS
protocol instead of HTTP. Otherwise, if the url already is HTTPS, limit
the download time to 25 seconds since only the headers, not contents, matter.
 2017-03-16 17:37:22 -04:00
Mike McQuaid
4d88cc4c41 Merge pull request #2326 from vszakats/sprot 
secure urls + remove -k from in-doc curl command
 2017-03-15 15:11:35 +00:00
Viktor Szakats
cc8f029f22 secure urls + remove -k from in-doc curl command 2017-03-14 17:27:11 +00:00
ilovezfs
45aa7b9a14 Revert "audit: exempt wine's deps from the universal deprecation" 2017-03-12 13:59:43 -07:00
Markus Reiter
c594ffefbc Add Formatter::pluralize. 2017-03-11 21:12:51 +01:00
Mike McQuaid
c4c3588de8 Merge pull request #2252 from zmwangx/audit-no-warn-brew-mirror-url 
audit: do not warn about reachability of `brew mirror`ed URL
 2017-03-08 09:32:37 +00:00
Zhiming Wang
10a235d6ab
pull: check Bintray mirror URLs 2017-03-07 20:45:08 -05:00
Shaun Jackman
0d3e1119a1 bottle: Remove superfluous odie 2017-03-06 11:35:48 -08:00
Mike McQuaid
3aa088dcaf Merge pull request #2272 from EricFromCanada/master 
Add more flags and descriptions to man pages.
 2017-03-06 18:00:39 +00:00
JCount
bd444dda43 Merge pull request #2269 from JCount/audit-conflicts-whitelist-bash-completion 
audit: whitelist bash-completion@* to use conflicts_with
 2017-03-06 12:05:43 -05:00
EricFromCanada
aee23ccb03 Add more flags and descriptions to man pages. 2017-03-05 21:45:15 -05:00
Markus Reiter
18d4220cbf Remove BUNDLE_PATH from brew tests. 2017-03-05 23:33:36 +01:00
JCount
3db3b08d72 audit: freeze versioned_conflicts_whitelist 2017-03-05 15:44:03 -05:00
JCount
460c4a3200 audit: deconstruct versioned_conflicts_whitelist using splat 2017-03-05 15:06:02 -05:00
JCount
4e50562424 audit: whitelist bash-completion@* to use conflicts_with 
this is necessary because they install conflicting scripts into
HOMEBREW_PREFIX/etc/profile.d
 2017-03-05 14:19:32 -05:00
Mike McQuaid
dbf3630a53 Merge pull request #2262 from MikeMcQuaid/subversion-https-audit 
Don't check Subversion HTTPS pre-Sierra.
 2017-03-05 15:30:16 +01:00
ilovezfs
a1da909dea audit: whitelist node@* to use conflicts_with 
Add exceptions for node@* versioned formulae to use conflicts_with
instead of keg_only :versioned_formula since they, and the main node
formula, all currently overwrite npm during postinstall.
 2017-03-05 03:15:22 -08:00
Mike McQuaid
e26cf3a83f Don't check Subversion HTTPS pre-Sierra. 
The system Subversion doesn't handle new certificate authorities (e.g.
Let's Encrypt) well enough for this check to be useful.
 2017-03-05 11:42:59 +01:00
Zhiming Wang
475cade1a3
audit: do not warn about reachability of brew mirrored URL 
A `brew mirror`ed URL is usually not yet reachable at the time of pull request.
 2017-03-04 10:12:45 -05:00
Jonathan Chang
8385f179df audit: reject versions starting with HEAD 
Many parts of Homebrew assume that a version string beginning with
"HEAD" is, in fact, a head build. A stable version that begins with
"HEAD" violates this assumption and causes problems, as it's treated
as a head build in some places and as a stable build in others.
 2017-03-02 21:27:12 -08:00
Gautham Goli
19f693d25b Port audit_desc rules to cop 2017-03-02 12:50:05 +05:30
ilovezfs
e022239608 Merge pull request #2241 from ilovezfs/bump-formula-pr-die-without-version 
bump-formula-pr: check for version presence.
 2017-03-01 05:41:35 -08:00
ilovezfs
baf7ba6316 bump-formula-pr: check for version presence. 
If it's not there, error out rather than fetching to avoid creating
versionless cache files, which cause `brew cleanup` to crash.
 2017-03-01 04:25:10 -08:00
Markus Reiter
487294f815 Remove Minitest. 2017-02-28 22:48:57 +01:00
Misty De Meo
f332bf4a76 brew tests: filter out vendor/bundle 2017-02-28 22:42:41 +11:00
Misty De Meo
e3f4701f38 audit: fix audit on formulae without homepages 2017-02-27 08:24:44 +11:00
Misty De Meo
177aefdf55 xcodebuild audit: match xcodebuild with no args 
Closes #2199.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
 2017-02-26 21:16:43 +11:00
EricFromCanada
afc539f86e Update brew's man page formatting and grammar 
Also update command specifications to match descriptions.
 2017-02-25 17:37:57 -05:00
EricFromCanada
6cb5629737 Work around man page generator bug for pull.rb 
To work around ronn's [issue with nested
lists](https://github.com/rtomayko/ronn/issues/35), treat each item as
a separate paragraph with alternate list markers.
 2017-02-25 17:27:08 -05:00
Mike McQuaid
d0a965e2ab Merge pull request #2107 from MikeMcQuaid/audit-version-aliases 
audit: check for version aliases.
 2017-02-25 14:13:35 +00:00
ilovezfs
75724c5b5d audit: whitelist more unstable versions already in core 
These were imported from homebrew/games.
 2017-02-25 03:03:37 -08:00
Mike McQuaid
1284f29561 audit: don't try to HTTP check non-HTTP content. 2017-02-24 08:51:15 +00:00
Mike McQuaid
b984be675d audit: use using for HTTPS detection. 2017-02-24 08:45:39 +00:00
Mike McQuaid
9fa014710d audit: further refactor http content checks. 
Check homepages and don’t check mirrors unless `—strict`.
 2017-02-23 10:16:27 +00:00
Mike McQuaid
96a8f8f172 audit: check for version aliases. 
Current version aliases should be provided for versioned formulae so
people can `brew install foo@1.2` to provide pin-like behaviour.
 2017-02-23 09:14:54 +00:00
Mike McQuaid
1a436b4d24 Merge branch 'master' into mirror_audit 2017-02-23 09:12:18 +00:00
Mike McQuaid
5e90575004 audit: handle redirects in get_content_details. 2017-02-23 09:09:58 +00:00
Mike McQuaid
5390897883 audit: refactor http content checks. 2017-02-23 09:09:33 +00:00
Markus Reiter
3f8e52e574 Merge pull request #2091 from reitermarkus/spec-exclude-needs_macos 
Exclude specs with `:needs_macos` tag when not on macOS.
 2017-02-23 09:34:17 +01:00
Markus Reiter
48a211fc90 Convert os/mac/language test to spec. 2017-02-23 02:47:33 +01:00
Mike McQuaid
ac5b6b6eea Revert "audit: fix revision should be removed." 2017-02-22 08:49:24 +00:00
ilovezfs
4e34f7b60e Merge pull request #2086 from MikeMcQuaid/audit-revision-remove-fix 
audit: fix revision should be removed.
 2017-02-21 14:09:58 -08:00
Markus Reiter
168a96d919 Exclude specs with :needs_macos tag when not on macOS. 2017-02-21 21:55:16 +01:00
ilovezfs
b59bf2ff64 Revert "audit: check for version aliases." 2017-02-21 11:31:18 -08:00
Mike McQuaid
2f42dfc68a audit: fix revision should be removed. 
Regression introduced in #1754 which meant that (due to storing the
current formula revision in `attributes_map`) `stable_revisions.empty?`
would never be `true`.
 2017-02-21 18:50:07 +00:00
Mike McQuaid
606790d062 audit: check for version aliases. 
Current version aliases should be provided for versioned formulae so
people can `brew install foo@1.2` to provide pin-like behaviour.
 2017-02-21 15:36:49 +00:00
Mike McQuaid
96a695bc6d Merge pull request #2054 from zmwangx/bump-formula-pr-smarter-dupe 
bump-formula-pr: improve duplicate detection
 2017-02-20 22:54:51 +00:00
Mike McQuaid
125a6eee21 audit: fix brew style. 2017-02-20 22:48:03 +00:00
David Broder-Rodgers
55bc2a3019 Merged 404 and security mirror auditing logic 2017-02-20 19:24:35 +00:00