admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: fix revision should be removed.

Browse Source 
Regression introduced in #1754 which meant that (due to storing the
current formula revision in `attributes_map`) `stable_revisions.empty?`
would never be `true`.
This commit is contained in:
Mike McQuaid 2017-02-21 18:50:07 +00:00
parent ed7290abb4
commit 2f42dfc68a
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/dev-cmd/audit.rb
View File

@ -816,10 +816,12 @@ class FormulaAuditor
return if formula.revision.zero?
if formula.stable
revision_map = attributes_map[:revision][:stable]
stable_revisions = revision_map[formula.stable.version] if revision_map
if !stable_revisions || stable_revisions.empty?
problem "'revision #{formula.revision}' should be removed"
if revision_map = attributes_map[:revision][:stable]
stable_revisions = revision_map[formula.stable.version]
stable_revisions -= [formula.revision]
if stable_revisions.empty?
problem "'revision #{formula.revision}' should be removed"
end
end
else # head/devel-only formula
problem "'revision #{formula.revision}' should be removed"