audit: whitelist node@* to use conflicts_with
Add exceptions for node@* versioned formulae to use conflicts_with instead of keg_only :versioned_formula since they, and the main node formula, all currently overwrite npm during postinstall.
This commit is contained in:
parent
8772b021a2
commit
a1da909dea
@ -519,14 +519,6 @@ class FormulaAuditor
|
||||
end
|
||||
|
||||
def audit_conflicts
|
||||
if formula.conflicts.any? && formula.versioned_formula?
|
||||
problem <<-EOS
|
||||
Versioned formulae should not use `conflicts_with`.
|
||||
Use `keg_only :versioned_formula` instead.
|
||||
EOS
|
||||
return
|
||||
end
|
||||
|
||||
formula.conflicts.each do |c|
|
||||
begin
|
||||
Formulary.factory(c.name)
|
||||
@ -539,6 +531,13 @@ class FormulaAuditor
|
||||
problem "Ambiguous conflicting formula #{c.name.inspect}."
|
||||
end
|
||||
end
|
||||
|
||||
return unless formula.conflicts.any? && formula.versioned_formula?
|
||||
return if formula.name.start_with? "node@"
|
||||
problem <<-EOS
|
||||
Versioned formulae should not use `conflicts_with`.
|
||||
Use `keg_only :versioned_formula` instead.
|
||||
EOS
|
||||
end
|
||||
|
||||
def audit_options
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user