286 Commits

Author SHA1 Message Date
Max Howell
9274f7cda1 Formula.Enumerable
Deprecated Formula.all, replaced usage with more appropriate enumerable options. Just check out how much nicer `brew audit` runs now.
2012-08-21 12:09:05 -04:00
Jack Nagel
e57122780e Add Version#detected_from_url? 2012-08-18 11:12:09 -05:00
Jack Nagel
b3724b2945 Remove executable bits from audit.rb and bottle.rb
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-08-17 21:09:12 -05:00
Jack Nagel
f970f9ec60 Refactor brew audit 2012-08-12 13:58:14 -05:00
Adam Vandenberg
ac9bc89bb3 Remove options audit check 2012-08-09 12:52:05 -07:00
Charlie Sharpsteen
524190f109 brew-audit: Warn against depending on MPI
Depending on `open-mpi` or `mpich2` will cause problems since both formulae
install components with the same names. `brew audit` now recommends using
MPIDependency.

Signed-off-by: Charlie Sharpsteen <source@sharpsteen.net>
2012-07-28 09:12:44 -07:00
Jack Nagel
76b2eee777 Refactor checksumming
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-07-04 22:47:33 -05:00
Jack Nagel
2c6e93cf8a audit: handle new formula specs 2012-07-04 22:47:33 -05:00
Jack Nagel
9ebb1a3d08 audit: prefer ARGV.build_head? to inspecting 'version'
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-06-17 18:01:22 -05:00
Jack Nagel
6a94df360a audit: prefer modifying ENV to using env or export
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-06-17 17:59:30 -05:00
Jack Nagel
38a28285a6 audit: catch unnecessary 'ENV.foo' interpolation
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-06-17 17:58:49 -05:00
Jack Nagel
4dfa2806b9 audit: fix broken deps check
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-05-15 17:45:26 -05:00
Jack Nagel
fa1edd6846 audit: don't count printed URLs as problems
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-05-07 17:50:05 -05:00
Jack Nagel
4d027874b0 audit: check MacPorts patch URLs
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-05-07 17:44:57 -05:00
Mike McQuaid
fe969c21ad Add ofail command and fix bottle command output. 2012-04-30 21:38:08 +08:00
Adam Vandenberg
162b1ee936 audit: reduce false-positives 2012-04-29 09:32:39 -07:00
Mike McQuaid
0cbdeeaa3c Exit with bad exit code on command failures. 2012-03-29 18:44:37 +11:00
Adam Vandenberg
9c28138889 audit: add tests for patches 2012-03-19 18:50:17 -07:00
Jack Nagel
672128c908 bsdmake is a build-time dep
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-03-17 11:16:45 -05:00
Adam Vandenberg
8f47bdb782 audit: check for install options being shadowed 2012-03-17 08:46:04 -07:00
Adam Vandenberg
27288547aa Add specialty formulase to inheritance check 2012-03-10 10:26:06 -08:00
Jack Nagel
79d1c2396a audit: check for gfotran in Formula#deps instead
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-03-01 19:56:09 -06:00
Jack Nagel
2f842994f0 audit: automake, autoconf, and libtool are build-time deps
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-28 11:36:12 -06:00
Adam Vandenberg
a8e4cf4f80 audit: flag imake as a build dep 2012-02-21 18:57:27 -08:00
Jack Nagel
ccec313b03 audit: use a heredoc for this long line
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-18 20:49:51 -06:00
Jack Nagel
ecbee2b73c audit: tighten xcodebuild SYMROOT check
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-18 20:49:50 -06:00
Jack Nagel
856fe669e2 audit: warn about ARGV.include? '--devel'
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-16 23:47:40 -06:00
Jack Nagel
f1dc59ca11 audit: make checksum warnings more clear
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-16 23:47:39 -06:00
Adam Vandenberg
0ae1772b89 audit: add problem counts 2012-02-16 20:27:08 -08:00
Jack Nagel
b63584a386 audit: warn about correct empty checksum type
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-15 23:03:43 -06:00
Jack Nagel
98dcfcfe2e audit: only look for empty checksums once
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-15 22:12:06 -06:00
Trevor Wennblom
555b16962f more stringent auditing of checksums
Closes Homebrew/homebrew#10213.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-15 22:12:06 -06:00
Jack Nagel
1d9ada295a Boost-jam is now part of boost-build
So remove it, and add/update the appropriate aliases.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-02-13 20:51:40 -06:00
Adam Vandenberg
62cfa49082 audit: make boost-jam a build-time dependency 2012-01-28 12:50:45 -08:00
Jack Nagel
ab19242d04 audit: reorganize some checks
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-01-25 22:41:53 -06:00
Jack Nagel
c36561f450 audit: make devel check more specific
There are a few false positives where the string 'devel' occurs in other
contexts.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-01-25 22:39:13 -06:00
Misty De Meo
d121bcdada Add devel to the DSL, + stable and bottle blocks
This commit adds a `devel` entry to the DSL, allowing formulae to
specify an unstable branch.

`devel` takes a block, which should contain standard `url` and `md5`
fields (and `version`, if necessary). This must come after the standard
DSL fields.

This commit also migrates over all formulae currently using `devel` to
the new syntax, as well as formulae which used `head` for non-VCS urls.

The new syntax is also available for `stable` and `bottle`. `stable` is
an option alongside the old syntax. `bottle` replaces the old syntax.

Note that the @stable ivar in Formula has been renamed to @standard,
and the @bottle ivar has been renamed to @bottle_url.

Closes Homebrew/homebrew#9735.

Signed-off-by: Misty De Meo <mistydemeo@gmail.com>
2012-01-25 21:45:19 -06:00
Jack Nagel
cf16987845 audit: check for mercurial dependency
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2012-01-17 21:57:13 -06:00
Adam Vandenberg
198135e8c0 audit: do not complain about --32-bit 2012-01-02 14:58:15 -08:00
Jack Nagel
9c83af341f audit: check for trailing newline
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-12-31 00:05:25 -06:00
Adam Vandenberg
e416bd1115 audit: remove --strict 2011-12-21 14:52:15 -08:00
Adam Vandenberg
a68152fc7d Audit: warn about head-only formulae 2011-12-18 16:24:56 -08:00
Jack Nagel
e4bd231680 audit: hard wrap dep warning
The warning is lengthy, and usually wraps on 80-column terminals.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-12-15 16:59:02 -06:00
Jack Nagel
18bdd72827 audit: check for hard-coded compilers
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-12-08 23:08:42 -06:00
Jack Nagel
6f83e20f49 audit: only perform GNU URL check on primary URLs
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-11-30 13:14:24 -06:00
Jack Nagel
1657bb1fcf audit: disable GNU url check
It needs to be reworked to only check the primary URLs, as we are now
using ftp.gnu.org as a mirror.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-11-30 12:57:29 -06:00
Adam Vandenberg
f059e9624c audit: smake is also a build tool 2011-11-29 18:55:55 -08:00
Adam Vandenberg
7278eaec51 audit: check for DB deps too 2011-11-29 18:50:44 -08:00
Jack Nagel
45a87ab8d9 audit: warn about more "forbidden" dependencies
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-11-29 19:57:26 -06:00
Jack Nagel
7f7391243a audit: check for build-time dependencies
This can be made more robust in the future when we stop throwing away
the ':build' type flag in Formula#depends_on.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2011-11-29 19:40:14 -06:00