admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Remove options audit check

Browse Source
This commit is contained in:
Adam Vandenberg 2012-08-09 12:52:05 -07:00
parent e196c845bf
commit ac9bc89bb3
1 changed files with 0 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
Library/Homebrew/cmd/audit.rb
View File

@ -155,46 +155,6 @@ INSTALL_OPTIONS = %W[
--verbose
].freeze
def audit_formula_options f, text
problems = []
# Textually find options checked for in the formula
options = []
text.scan(/ARGV\.include\?[ ]*\(?(['"])(.+?)\1/) { |m| options << m[1] }
options.reject! {|o| o.include? "#"}
options.uniq! # May be checked more than once
# Find declared options
begin
opts = f.options
documented_options = []
opts.each{ |o| documented_options << o[0] }
documented_options.reject! {|o| o.include? "="}
rescue
documented_options = []
end
if options.length > 0
options.each do |o|
next if o == '--HEAD' || o == '--devel'
problems << " * Option #{o} is not documented" unless documented_options.include? o
end
end
if documented_options.length > 0
documented_options.each do |o|
next if o == '--universal' and text =~ /ARGV\.build_universal\?/
next if o == '--32-bit' and text =~ /ARGV\.build_32_bit\?/
problems << " * Option #{o} is unused" unless options.include? o
if INSTALL_OPTIONS.include? o
problems << " * Option #{o} shadows an install option; should be renamed"
end
end
end
return problems
end
def audit_formula_patches f
problems = []
patches = Patches.new(f.patches)
@ -400,7 +360,6 @@ module Homebrew extend self
text_without_patch = (text.split("__END__")[0]).strip()
problems += audit_formula_text(f.name, text_without_patch)
problems += audit_formula_options(f, text_without_patch)
problems += audit_formula_specs(f)
unless problems.empty?