286 Commits

Author SHA1 Message Date
Xu Cheng
e2994bb078 audit: suggest to not using git as dependency
Closes Homebrew/homebrew#37696
Closes Homebrew/homebrew#37703

Closes Homebrew/homebrew#37735.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-15 20:55:55 +08:00
chdiza
21314474cd audit: Clarify GNU url warning message
"ftpmirror.gnu.org" must have a protocol prefix of "http", not
"https".

Closes Homebrew/homebrew#37567.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-12 08:19:37 +00:00
Xu Cheng
7d7081a18b audit: whitelist pipe, redirect etc in the system check
Closes Homebrew/homebrew#37523.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-10 00:57:21 +08:00
Mike McQuaid
3b15382029 audit: git tags should also specify revisions. 2015-03-08 10:48:58 +00:00
Dominyk Tiller
12861686b8 checksums: switch to sha256 for bottles and new formulae
Closes Homebrew/homebrew#37164.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-05 14:45:39 +00:00
Xu Cheng
ce5d4a3b03 audit: deprecate ScriptFileFormula
Closes Homebrew/homebrew#37356.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-04 00:34:21 +08:00
Xu Cheng
67554a7338 audit: deprecate AmazonWebServicesFormula
Closes Homebrew/homebrew#37355.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-03-03 21:18:01 +08:00
Viktor Szakáts
10d5c4f97b brew audit: req https for archive.apache.org urls
Closes Homebrew/homebrew#37313.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-03-02 11:53:53 +00:00
Mike McQuaid
0161d50d7a audit: handle head/devel-only correctly. 2015-02-27 16:13:04 +00:00
Xu Cheng
be15a514eb audit: suggest setting JAVA_HOME by depends_on :java
Closes Homebrew/homebrew#37174.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-02-25 16:44:25 +08:00
Xu Cheng
589de2f26a fix audit 2015-02-24 17:20:55 +08:00
Xu Cheng
39473f7694 audit: fix FormulaText match
It's used in `audit_text`

Closes Homebrew/homebrew#37139.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-02-24 17:04:29 +08:00
Xu Cheng
40e6426322 audit: give better suggestion on git/hg dependency
Closes Homebrew/homebrew#36959.

Signed-off-by: Xu Cheng <xucheng@me.com>
2015-02-19 18:49:15 +08:00
Mike McQuaid
6dd51ff399 audit: check for setuid in caveats. 2015-02-19 09:29:17 +00:00
Dominyk Tiller
51956d343a audit: extend ssl checks
Extends the audit checks to GnuPG, a significant chunk of Freedesktop
domains, and Github Pages. I’ve somewhat hardened my stance towards
Github Pages from the last time we extended this, hence the new
inclusion - I did a pretty thorough check through the Homebrew formulae
that use Github Pages for homepage links and found very few places
where enforcing SSL/TLS would cause issues - I think a wider
enforcement is worthwhile.

I’ve also fixed the capitalisation of the taps, if only because at the
moment it disagrees with what ` puts formula.tap ` outputs (We get
Homebrew/homebrew-head-only rather than homebrew/homebrew-head-only for
example).

Closes Homebrew/homebrew#36719.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-17 12:06:17 +00:00
Xu Cheng
f204e2e608 audit: more information on build deps audit
Closes Homebrew/homebrew#36892.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-17 10:30:32 +00:00
Xu Cheng
d0e2d126a1 audit: catch empty installations
Closes Homebrew/homebrew#36794.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-14 15:10:35 +00:00
Dominyk Tiller
2abd3298f9 audit: catch more examples from example_formula
See
https://github.com/Homebrew/homebrew/pull/36629#discussion_r24293912
amongst other recent examples. The example formula isn’t as strongly
policed as the ` brew create ` default, this tries to do something
about that.

Closes Homebrew/homebrew#36639.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 12:24:17 +00:00
Dominyk Tiller
40ddea637a audit: stop red-flagging devel-only
Currently the bot is failing certain devel-only formulae because it
thinks having ` devel ` defined with an added ` head ` defined
as well = a head-only formula.

```
==> audit problems
docker-machine:
 * Head-only (no stable download)
```

This is a pretty simple fix for that problem:

```
==> brew style docker-machine
1 file inspected, no offenses detected
```

Closes Homebrew/homebrew#36197.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-26 14:39:12 +00:00
Jack Nagel
bf6887bc59 Deprecate GithubGistFormula
Closes Homebrew/homebrew#36094.
2015-01-22 20:34:51 -05:00
Jack Nagel
165b47c0e6 Audit check for gnome unstable as stable 2015-01-22 16:58:54 -05:00
Dominyk Tiller
50d64da1ec audit: improve ssl/tls detection
I don’t know how maintainers are going to feel about this, to be
honest. If it’s too clunky, perhaps we could externalise the entire two
main blocks here and then require that file into the audit instead?

Basically, I’m pushing changes here to better detect a wide-array of
SSL/TLS available links that either have no auto-redirect in place or
is a common linking error in formulae. I haven’t spotted any false
positives yet, but obviously, feel free to try and break the changes
and I’ll fix as necessary ;).

IMO, this would allow us gradual updates without having to mass-update
everything at once and stress the bot and inform users they have
hundreds of updates pending when really it’s just style/basic changes.

Closes Homebrew/homebrew#35551.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-06 08:16:25 +00:00
Mike McQuaid
980cad0717 audit (strict): only run brew style with Ruby 2. 2015-01-05 07:52:47 +00:00
Mike McQuaid
c294ce22a7 audit: also run brew style on --strict.
Closes Homebrew/homebrew#35465.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-04 11:05:34 +00:00
Baptiste Fontaine
81986ee7a7 audit: system check fixed for multiple arguments
Closes Homebrew/homebrew#35459.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 10:36:36 +00:00
Jack Nagel
9e335fa0b8 Revert "audit (strict): check for use double-quotes."
This reverts commit 8fe14451842dea92bca04116ba043421b4f44a6b.

Conflicts:
	Library/Homebrew/cmd/audit.rb
2014-12-27 17:07:30 -05:00
Mike McQuaid
e1c6a4614f Rename HEAD only tap. 2014-12-27 20:55:21 +00:00
Mike McQuaid
8458540afb audit: simplify test defined check. 2014-12-27 20:46:01 +00:00
Mike McQuaid
13239276f0 audit: improve FileUtils check.
Match the parens properly and only interpolate once.

Closes Homebrew/homebrew#35288.
Closes Homebrew/homebrew#35291.
2014-12-27 20:35:26 +00:00
Mike McQuaid
c4f7217811 audit (strict): add require formula check. 2014-12-27 16:31:44 +00:00
Mike McQuaid
f3a5a83452 audit (strict): check a test is present. 2014-12-27 16:31:44 +00:00
Mike McQuaid
d263c73cc4 audit (strict): whitelist 32-bit in options check. 2014-12-27 16:31:43 +00:00
Mike McQuaid
5cd8f62865 audit (strict): check for use double-quotes. 2014-12-27 16:31:43 +00:00
Mike McQuaid
c82e48b904 audit (strict): check for use of spaces in system. 2014-12-27 16:31:43 +00:00
Mike McQuaid
3e3a4cad50 audit: check for use of FileUtils methods. 2014-12-27 16:31:43 +00:00
Mike McQuaid
fca32ee7cc audit: check options when in strict mode. 2014-12-27 12:38:58 +00:00
Mike McQuaid
24f183dd12 audit: add strict mode, argument. 2014-12-27 12:38:04 +00:00
Jack Nagel
7c4324d5ea Fix formula template comment audit 2014-12-22 01:12:44 -05:00
Jack Nagel
cd7004b579 Deprecate appending the CVS module name to the URL string 2014-12-22 00:52:10 -05:00
Jack Nagel
0344d243e4 Deprecate made-up URL schemes
This deprecates URLs that begin with the following fake URL schemes:
  bzr://
  cvs://
  hg://
  fossil://
  svn+http://

Despite their appearance, they are not actually accepted by the
corresponding tools. They exist only as hints to the download strategy
detection code, and are stripped from the URL before the URL is handed
off to the VCS program.

This is not documented, and may lead one to believe it is a valid URL
that can be used elsewhere, when it actually only works inside Homebrew.

We have a better mechanism for specifying the download strategy that is
straightforward and explicit:
  :using => :hg

Recommend that instead.

Closes Homebrew/homebrew#35114.
2014-12-19 12:28:18 -05:00
Jack Nagel
ef48a5e7d7 Deprecate UnsafeSubversionDownloadStrategy 2014-12-18 16:45:15 -05:00
Jack Nagel
89dc0b9787 One less place where Formula is reopened 2014-11-12 21:41:14 -06:00
Jack Nagel
16a2220834 Exempt the head-only tap from the head-only audit warning 2014-11-12 21:32:44 -06:00
Jack Nagel
673f08f17e audit: compare file mode directly 2014-10-29 22:47:17 -05:00
Jack Nagel
1195718d0e Rename "f" to "formula" in the installer 2014-10-29 22:41:03 -05:00
Jack Nagel
f8c0c27566 Deprecate insecure download strategies 2014-10-18 17:39:53 -05:00
Jack Nagel
b6631b9a15 audit: call puts once instead of problems.size + 2 times 2014-10-17 00:35:51 -05:00
Jack Nagel
fb30041640 audit: loop over deps once 2014-10-17 00:11:46 -05:00
Jack Nagel
73d08fcc1a Audit devel and head deps 2014-10-17 00:08:17 -05:00
Jack Nagel
b05351d0b2 Reorganize post-install checks so we can share more code 2014-10-13 23:13:01 -05:00