3907 Commits

Author SHA1 Message Date
Mike McQuaid
2ee93a2476
Revert "remove flaky cask upgrade test"
This reverts commit 626f9406b1987932382814bc7d7cae3b41b771f4.
2020-06-29 09:50:43 +01:00
Mike McQuaid
a9877088ea
Revert "test/cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 8a0e6a1603ce823eb66cc183a692f722668d9c67.
2020-06-29 09:50:36 +01:00
Mike McQuaid
cc0ea9aec3
Revert "cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 75c74e4674d3f6a85c4afce79a6096bcc5cca9fc.
2020-06-29 09:50:29 +01:00
Mike McQuaid
af2c57dbeb
Revert "cask/cmd/upgrade_spec: remove more flaky tests."
This reverts commit fb0fa419abc750bf33695a396244b9cffbea1554.
2020-06-29 09:50:18 +01:00
Jonathan Chang
90309e5f42 github: fetch approved reviews for a pull request 2020-06-29 12:53:03 +10:00
Sam Ford
15bc09d916
version: add empty? method 2020-06-27 21:03:16 -04:00
Lionell
5f6917ae7c Merge branch 'master' into license 2020-06-28 02:07:53 +08:00
Mike McQuaid
ba62b988e1
Merge pull request #7840 from Rylan12/remove-iso-8601-hyphen
Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb
2020-06-27 13:15:55 +01:00
Mike McQuaid
58de51f2ce
Merge pull request #7837 from FTLam11/7392-migrate-audit-rules-to-rubocop
audit: Move patch checks from brew audit to rubocop
2020-06-27 13:11:51 +01:00
Mike McQuaid
21069e3797
Merge pull request #7696 from Rylan12/audit-shell-variables
style: set shell variables in hash
2020-06-27 13:10:35 +01:00
Rylan Polster
9c44e39a39 Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb 2020-06-26 21:32:18 -04:00
Rylan Polster
e82084583a style: set shell variables in hash
When running Utils.popen (or similar popen command), having a line like
"SHELL=bash ..." doesn't work properly. Instead, use:
`Utils.popen({ "SHELL" => "bash" }, "...")`
2020-06-26 16:39:39 -04:00
Frank Lam
ffb1cc8e19
Find patch nodes nested inside blocks 2020-06-27 03:13:50 +08:00
Frank Lam
b2eafdf11d
Remove patch checks from audit 2020-06-27 02:37:57 +08:00
Rylan Polster
9520eabc35 style: enforce ISO-8601 in deprecation date 2020-06-26 11:53:42 -04:00
Frank Lam
644ae115f5
Prepare inline patch specs 2020-06-25 22:29:34 +08:00
Lionell
ff7a80ebf5 Merge branch 'master' into license 2020-06-25 21:51:39 +08:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
2020-06-25 11:38:40 +01:00
Lionell
5aa0eb487e rename spec file 2020-06-25 17:51:47 +08:00
Lionell
57fd1fdc7e Merge branch 'master' into license 2020-06-25 13:42:27 +08:00
lionellloh
fbd5c32d22 bunch of style fixes 2020-06-25 05:46:18 +08:00
Bo Anderson
04cebe30dc test/support/fixtures/bottles: add Big Sur fixtures 2020-06-24 16:31:48 +01:00
Mike McQuaid
c250227750
test/spec_helper: fix needs_svn.
Use the shim to find a valid Subversion.
2020-06-24 10:37:36 +01:00
Mike McQuaid
58cc7dd96c
utils/svn_spec: use shim to detect Subversion presence. 2020-06-24 10:37:36 +01:00
Mike McQuaid
1dbbb5e58c
Merge pull request #7789 from MLH-Fellowship/cask-integration
Integrate `--cache` and `home` with cask
2020-06-24 09:02:25 +01:00
Rylan Polster
0faf17b1e6 use safe_popen_read instead of popen_read
RuboCop requires using Utils.safe_popen_read and Utils.safe_popen_write
instead of Utils.popen_read and Utils.popen_write respectively.

Using the "safe" version means that an error will be shown if the
command fails. Previously, when using `popen_read`, a failed command can
go unnoticed and have negative consequences that go undetected (as
happened for pipend in
https://github.com/Homebrew/homebrew-core/pull/55682)

RuboCop does not require Utils.safe_popen_read in a test do block
because there can be some legitimate uses for Utils.popen_read in these
cases.
2020-06-23 13:57:33 -04:00
William Ma
27abc8c50b home: Print info for each formula/cask opened 2020-06-23 09:44:17 -04:00
Adrian Ho
6044bb17ee Fix test cask macOS dependency
This should be updated when the minimum OS requirement changes.
2020-06-23 09:51:56 +08:00
William Ma
78ccb05166 Fix style issues 2020-06-22 16:07:18 -04:00
William Ma
0e61ca6715 update tests to match new output format 2020-06-22 15:55:51 -04:00
lionellloh
127d67e745 license: update tests and license checking logic 2020-06-23 02:59:55 +08:00
lionellloh
e4e55c5cb3 update-license-data: wrote rspec test and added one more parseable arg 2020-06-23 02:25:46 +08:00
Michka Popoff
a5025e9a9f
Merge pull request #7751 from iMichka/shared
formulae: add generic shared_library_extension
2020-06-22 18:25:35 +02:00
William Ma
bd2f5c3b32 test cache: split regex into multiple lines 2020-06-22 11:42:15 -04:00
William Ma
cf6ff4d84c cache: add test for casks 2020-06-22 11:24:49 -04:00
William Ma
0495281325 home: write tests using cask as argument 2020-06-22 10:46:59 -04:00
Dario Vladovic
8a62f891e1
formula: add std_cargo_args 2020-06-22 14:39:49 +02:00
Michka Popoff
955bca6574 formule: add generic shared-lib methods
We have strings containing hardcoded ".dylib" extensions in homebrew-core.
To be able to bring linuxbrew-core and homebrew-core closer together,
I am introducing a new generic attribute that can be used in formulae.
2020-06-20 23:14:18 +02:00
miccal
3263f796b6 cpu_spec: add :icelake 2020-06-20 14:14:56 +08:00
Lionell
fa412f9bb4 audit spec: editted strings to matach audit problem strings 2020-06-19 04:24:36 +08:00
Lionell
f78d4f41a0 audit spec: include cases for new formula 2020-06-18 00:45:13 +08:00
Lionell
f1cd404839 Merge branch 'master' into license 2020-06-17 22:58:12 +08:00
lionellloh
2b66968505 audit: cosmetic changes 2020-06-17 22:55:02 +08:00
lionellloh
0b95f030fd audit: fix code review changes 2020-06-17 22:13:04 +08:00
lionellloh
3bfca5bcee audit: change location of spdx.json file 2020-06-17 21:45:51 +08:00
lionellloh
03fc6b2c15 audit_spec: override core-tap attribute in online test 2020-06-17 05:19:38 +08:00
Lionell
e8f6e651d1 dev-cmd/audit_spec: WIP: online mismatch does not return any problems in test environment 2020-06-17 04:16:01 +08:00
Lionell
44aac2474e dev-cmd/audit_spec: check if license info exists and if it is a standard spdx-id 2020-06-17 03:39:00 +08:00
Sean Molenaar
523c24684d
cask: audit locales 2020-06-16 11:41:06 +02:00
Sean Molenaar
d64afece81
Merge pull request #7690 from SMillerDev/cask/audit/token
cask: codify the token rules
2020-06-16 11:40:25 +02:00