3907 Commits

Author SHA1 Message Date
Sean Molenaar
4a24908fe4
cask: codify the token rules 2020-06-11 19:34:36 +02:00
Michka Popoff
3ad9009937 on_os block: test support for patches 2020-06-10 19:29:52 +02:00
Michka Popoff
2a50ef045f on_os blocks: remove url tests
This is not allowed by the style audit, and we do not want
to allow different source url's depending on the os.
2020-06-10 19:29:52 +02:00
Michka Popoff
1f8ebf5d20 resource: allow on_os blocks 2020-06-10 19:29:04 +02:00
Mike McQuaid
b58fa4ebb1
Drop Mavericks support.
Companion to https://github.com/Homebrew/brew/pull/7698.

Provide better, `odeprecated` messaging for
`depends_on :macos => :mavericks` and otherwise just fix up the code
that relied on `:mavericks`.
2020-06-10 10:06:46 +01:00
Mike McQuaid
2a94d382ac
audit: make audit_revision_and_version_scheme faster.
This is really, really slow at the moment for a few reasons:
- it goes through the list of revisions twice
- it checks many more revisions than it needs to

Even after these improvements it's still by far the slowest audit so
am also making it a `--git` only audit.

Additionally, to further improve default `brew audit` performance do not
run `brew style` checks when doing `brew audit` with no arguments.

`brew style` can be run quickly and efficiently on all of a tap (and is
cached) so no need to duplicate it here.
2020-06-08 15:00:09 +01:00
Issy Long
8eba9b86ab
Change occurrences of "blacklist" to "denylist" or "disallow"
- Depending on context, I've gone for either "denylist" or "disallow"
  here. "Disallow" for things in sentences, or actions, and "denylist"
  for list of things.
2020-06-06 22:38:33 +01:00
Issy Long
0041ea21f5
Change occurrences of "whitelist" to "allowlist" 2020-06-06 22:38:32 +01:00
Michka Popoff
1be708922f
Merge pull request #7436 from iMichka/audit-block
on_os_blocks: add audit
2020-06-05 11:24:25 +02:00
Mike McQuaid
22857b56b9
formula: deprecate devel blocks.
As we haven't released 2.3.1 I think we can get away with sneaking this
in. I'm also prepared to back this out if it's too widely used and
there's too much backlash.
2020-06-05 09:22:49 +01:00
Michka Popoff
c494528f15 on_os_blocks: add audit 2020-06-04 17:36:28 +02:00
Mike McQuaid
aa81982aba
brew style --fix 2020-06-02 09:49:23 +01:00
nandahkrishna
1edff7934e
livecheck: modify regex in tests 2020-06-01 11:37:58 +05:30
nandahkrishna
9ffd0e66af
livecheck: reference Formula URLs 2020-05-31 13:52:55 +05:30
Sean Molenaar
3567892802
Add notibility checks for casks 2020-05-26 14:21:25 +02:00
Mike McQuaid
ef95b59ed4
Remove HomebrewArgvExtension
Fixes #5730
2020-05-23 19:39:11 +01:00
Mike McQuaid
bc27e38f18
Remove ARGV.debug?
Replace with `Homebrew.args.debug?`.

Part of #5730.
2020-05-23 14:38:58 +01:00
Mike McQuaid
e1f3c8d2b3
Merge pull request #7579 from MikeMcQuaid/deprecations
Update deprecations
2020-05-23 14:38:10 +01:00
Mike McQuaid
183670296f
Merge pull request #7493 from GauthamGoli/argv-cleanup-26
ARGV: Deprecate ARGV.cc and replace with Homebrew.args.cc
2020-05-23 14:10:20 +01:00
Mike McQuaid
e5d15c8b19
Merge branch 'master' into argv-cleanup-26 2020-05-23 13:44:42 +01:00
Mike McQuaid
11cf77be17
formula_installer: prelude before fetch.
This ensures that dependencies are verified and tapped before they are
fetched. `FormulaInstaller#lock` has been moved into
`FormulaInstaller#install` to avoid locking until necessary.

While we're here, don't compute dependencies before fetching if we're
not going to use them.
2020-05-23 13:40:13 +01:00
Mike McQuaid
e10ade758d
Revert "formulary: install tap if needed." 2020-05-22 16:19:30 +01:00
Mike McQuaid
61b48d8557
formulary: install tap if needed.
This matches what `cask_loader` does and is low risk given we no longer
allow tap pinning.

Fixes #7626
2020-05-22 14:21:40 +01:00
Mike McQuaid
ca47992a6c
Fix rubocop-performance brew style. 2020-05-22 08:52:26 +01:00
Mathäus Zingerle
bb9665ced8 Migrate scheme checks for cvs, bzr, hg, fossil, and svn+http to Rubocop 2020-05-20 20:52:00 -05:00
Mike McQuaid
1ebb1c2885
Merge pull request #7580 from tharun208/brew-cask-analytics
Added analytics for cask info
2020-05-20 08:06:46 +01:00
Tharun
aeede8374f fixed review changes 2020-05-19 21:41:02 +05:30
Tharun
84f2edc884 replaced json and used dictionary 2020-05-19 19:35:30 +05:30
Tharun
6a50f31feb fixed proper parsing of mock data for analytics 2020-05-19 17:25:16 +05:30
Tharun
9e26a451e3 Updated mocking analytics call 2020-05-19 14:58:55 +05:30
Mike McQuaid
0e9897c86d
Merge pull request #7577 from vidusheeamoli/add-byebug
Set up Byebug debugger
2020-05-19 08:27:53 +01:00
Tharun
6e543f7289 Updated test with stubing cask analytics call 2020-05-18 20:46:43 +05:30
Mathäus Zingerle
82ba0475ad audit: Port version checks that do not rely on Formula state to RuboCop and add tests 2020-05-18 10:12:13 -05:00
Mike McQuaid
4f75a77b08
Update deprecations
Add more deprecations, disable deprecations and remove disabled code.
2020-05-18 13:50:46 +01:00
vidusheeamoli
4f1e9f44a1 set up byebug debugger 2020-05-18 16:28:43 +05:30
Tharun
4aba04556e Updated tests 2020-05-17 02:55:07 +05:30
nandahkrishna
a4f9a66406
livecheck: add component order rubocop 2020-05-15 19:00:14 +05:30
Shaun Jackman
133ee7966d shell: Use .profile unless .bash_profile exists 2020-05-13 09:30:02 -07:00
Mike McQuaid
08a9f0e1c0
Use FormulaInstaller#fetch before #prelude. 2020-05-11 09:38:26 +01:00
Michelle Nguyen
2264c08cee
Fetch formula resources before unlinking during upgrade.
Fixes #6374.
2020-05-11 09:37:56 +01:00
Mike McQuaid
35e487064e
Merge pull request #7537 from MikeMcQuaid/cli_parser_formulae
Replace ARGV#flags_only with Homebrew.args.flags_only
2020-05-11 08:47:12 +01:00
nandahkrishna
77e74e7e69
Adding livecheck Formula DSL 2020-05-11 09:41:13 +05:30
Mike McQuaid
fa0d454817
Replace ARGV#flags_only with Homebrew.args.flags_only
Take two on https://github.com/Homebrew/brew/pull/7490
2020-05-10 15:12:25 +01:00
Mike McQuaid
c91f397605
cli: fix options handling.
Fix breaking options on taps again (second time in two weeks, sob).

To avoid doing this again: also add a test for this case (that I've
verified would have caught these cases).
2020-05-07 10:33:02 +01:00
Mike McQuaid
60c9472b14
rubocop_rspec: disable RSpec/FilePath.
We keep adding to the list of exceptions and this fails if it isn't run
in the right directory.
2020-05-05 15:50:10 +01:00
Mike McQuaid
316da98140
Merge pull request #7503 from Bo98/since-fix
os/mac/software_spec: fix argument error in valid  use case
2020-05-05 09:10:33 +01:00
vidusheeamoli
f851688541 audit: Port audit_keg_only to rubocop and add tests
audit: add test

audit: fixed test

audit: added another test case

audit: fix test

audit: fix test

audit: fix keg only
2020-05-05 10:47:49 +05:30
Bo Anderson
16141e7eff os/mac/software_spec: fix argument error in valid use case 2020-05-04 17:16:39 +01:00
Mike McQuaid
e1f3b0b971
Merge pull request #7500 from MikeMcQuaid/deps_args_spec
deps_spec: check args.
2020-05-04 13:28:13 +01:00
Mike McQuaid
f567302ebf
deps_spec: check args. 2020-05-04 12:59:56 +01:00