3907 Commits

Author SHA1 Message Date
William Ma
e05538a7d9 Create DependenciesHelpers file, add tests 2020-07-31 11:35:45 -04:00
Markus Reiter
4381c32524 Add test for parsing with ignore_invalid_options. 2020-07-31 15:07:17 +02:00
Markus Reiter
d4c2ffd705 Refactor CLI::Parser. 2020-07-31 15:07:17 +02:00
Markus Reiter
8d97029b03
Merge pull request #8084 from reitermarkus/cli-parser
Refactor usage of global `Homebrew.args`.
2020-07-30 11:44:12 +02:00
Mike McQuaid
4888a677c7
Merge pull request #8126 from MLH-Fellowship/integrate-deps
deps: Print cask dependencies
2020-07-30 10:20:30 +01:00
Markus Reiter
05365b5542 Pass args more explicitly in FormulaInstaller. 2020-07-30 03:21:12 +02:00
Markus Reiter
ca18a72673 Refactor output_unsupported_error. 2020-07-30 03:21:12 +02:00
Markus Reiter
e14506e589 Pass args in uninstall instead of using global args. 2020-07-30 03:21:12 +02:00
Markus Reiter
24eff8f81a Pass args in SoftwareSpec instead of using global args. 2020-07-30 03:21:12 +02:00
Markus Reiter
f8934c0255 Pass args in Install and Messages instead of using global args. 2020-07-30 03:21:12 +02:00
William Ma
f96240eec7 deps: Add tests for CaskDependent 2020-07-29 13:37:38 -04:00
Seeker
4bd6c343d0 dev-cmd/audit: enforce uses_from_macos only if core tap 2020-07-28 10:28:00 -07:00
lionellloh
4f45ddd55b brew style --fix 2020-07-28 21:04:45 +08:00
lionellloh
26c786fc0a double quotes to single quotes 2020-07-28 21:01:36 +08:00
Lionell
0d6ea9e26c Updated tests to pass 2020-07-28 21:01:36 +08:00
Lionell
721c9b06cd audit-license: Small change to use license_array 2020-07-28 21:01:36 +08:00
lionellloh
4a14ae6589 Audit-license: more tests to ensure behaviour 2020-07-28 21:01:36 +08:00
lionellloh
797a07d555 All tests adapted to pass 2020-07-28 21:01:36 +08:00
Markus Reiter
bf9659423a Increase timeout for some integration tests. 2020-07-28 09:50:15 +02:00
Markus Reiter
5cf7ffd93e Make Cask::Auditor return a Hash with warnings and errors. 2020-07-28 09:50:15 +02:00
Markus Reiter
276c570c16 Pass individual args explicitly to ENV extensions. 2020-07-28 02:52:45 +02:00
Mike McQuaid
2ff56c9e71
Merge pull request #7927 from MLH-Fellowship/integrate-cask
Allow references to casks when running upgrade and outdated
2020-07-27 15:11:32 +01:00
Mike McQuaid
047738069f
Speed up timing-out tests.
- make `brew readall` only check Homebrew/brew syntax with no tap
  passed.
- pass specified tap to `brew readall` test for speed
- only shell out once in `FormulaInfo` test for speed
2020-07-27 14:01:22 +01:00
Mike McQuaid
25db60ebbb
Unify (mostly) Homebrew code style
Make the Homebrew/cask and Homebrew/homebrew-core style more closely
match the rest of Homebrew.

To accomplish this:
- Run `brew cask style` to ensure we don't break style there when
  making changes or upgrading RuboCop in Homebrew/brew.
- Fix the HomepageMatchesUrl cop to better handle weird input.
- Remove the now unneeded `.rubocop_shared.yml`
- Fix the cask fixtures with `brew cask style --fix`.
- Share more style between Homebrew/brew, casks and formulae.
2020-07-27 12:57:40 +01:00
Issy Long
fdbb2ac16a
Merge pull request #7985 from vidusheeamoli/utils-inreplace-to-true
sorbet: set utils/inreplace.rb to true
2020-07-26 10:37:30 +01:00
vidusheeamoli
fd382d2ecd srb: set utils/inreplace.rb to true and refactor
- Sorbet gives preference to class methods over methods defined in
  included modules, hence Sorbet was unavailable to resolve the
definition of the gsub! method.
- The gsub! method in StringInreplaceExtension conflicts with the definition in String.
- This PR refactors the call to the gsub! method so that a custom object
  is exposed instead of a string.
2020-07-26 12:43:31 +05:30
Dustin Rodrigues
ec81d43519 increase readall test timeout 2020-07-25 22:53:25 -04:00
Markus Reiter
8a1f8ab858 Pass args to FormulaInstaller instead of using global args. 2020-07-25 04:21:21 +02:00
Markus Reiter
25b3632c4c Pass args to ENV instead of using global args. 2020-07-25 03:57:43 +02:00
Markus Reiter
adc36a05ff Refactor Bintray not to depend on args. 2020-07-25 02:37:10 +02:00
rmnull
0bf981f010
skip tests when HOMEBREW_PATCHELF_RB is not set. 2020-07-25 01:41:20 +05:30
rmnull
06a4a78b99
simple rpath, interpreter tests for existing fixtures. 2020-07-25 01:25:08 +05:30
Markus Reiter
fda2183d5e
Merge pull request #8056 from reitermarkus/audit
Refactor `brew cask audit`.
2020-07-23 00:39:25 +02:00
Seeker
2e5d79a64a
Merge pull request #8033 from SeekingMeaning/allow-libressl
dev-cmd/audit: add libressl to uses_from_macos allow list
2020-07-22 10:43:01 -07:00
Sean Molenaar
dab18076fa
audit: error on archived repos 2020-07-22 11:57:50 +02:00
Markus Reiter
d048c324f9 Increase timeout for brew readall integration test. 2020-07-22 01:11:57 +02:00
Markus Reiter
b2698d501b Change test for MacOS::languages. 2020-07-22 01:11:57 +02:00
Markus Reiter
365d2b214e Remove useless spec. 2020-07-22 01:09:14 +02:00
Markus Reiter
4bc174cc62 Add timeout for all specs. 2020-07-22 01:09:14 +02:00
Markus Reiter
8d148b1fbc Remove special-casing of MacOS::languages. 2020-07-22 01:09:14 +02:00
Markus Reiter
ee09df8db3 Move Download from Auditor into Audit. 2020-07-22 01:09:14 +02:00
Seeker
e77c156690 dev-cmd/audit: rename USES_FROM_MACOS_ALLOWLIST
Rename to PROVIDED_BY_MACOS_DEPENDS_ON_ALLOWLIST
2020-07-21 08:21:09 -07:00
William Ma
fa0f6f4d5b outdated: Update tests for deprecation warning 2020-07-20 16:16:18 -04:00
Dawid Dziurla
2cd72908bc
Merge pull request #7863 from iMichka/single-resource
on_os resources: allow linux-only or mac-only resources
2020-07-20 16:58:30 +02:00
Rylan Polster
70dfaf3b42 Add link to pypi downloads page to problem message 2020-07-18 14:22:05 -04:00
Rylan Polster
5f3f7d010b Require long urls for pypi and pythonhosted urls 2020-07-18 14:05:46 -04:00
Issy Long
47826fd01d
Merge pull request #7997 from issyl0/git-test-last_revision_commit_of_files
utils/git_spec: Add a test for `last_revision_commit_of_files`
2020-07-16 17:07:29 +01:00
Issy Long
e1383c2898
utils/git_spec: Make example files easier to reason about
- Give the files real names, like `README.md`, rather than having to
  parse the difference between "bleh" and "blah" when reading the tests.
2020-07-14 00:18:45 +01:00
Issy Long
981726c088
utils/git_spec: Add a test for last_revision_commit_of_files
- This method, called from `brew extract` in the case of extraction from
  third-party taps, was untested. This led to it breaking when we refactored
  some of it to appease Sorbet (see PR 7933). If I make the same
  (flawed) change here and run these tests, they fail.
- There's a fair bit going on here, but most of it is setup for
  committing changes to more files, as we're testing operations on
  multiple files in a Homebrew repo.
- I originally tried to write tests for `brew extract`, but that
  required _a lot_ of refactoring because those tests (and their helper
  methods) aren't designed for third-party taps - they rely on
  `CoreTap`. So testing the underlying method is a better solution.
2020-07-14 00:18:44 +01:00
Sean Molenaar
4f5e6d5638
Merge pull request #7966 from SMillerDev/cask/list_json
cask: add list --json
2020-07-13 07:24:06 +02:00