Max Eisner
a002463362
#delete_suffix instead of #sub
2022-09-06 14:41:59 +02:00
Max Eisner
1b15d03634
remove always-true condition
2022-09-06 14:41:59 +02:00
Max Eisner
8398dfbae0
fix condition array substraction
2022-09-06 14:41:59 +02:00
Max Eisner
06518ec613
add RuboCop to combine multiple calls
2022-09-06 14:41:59 +02:00
Max Eisner
e4b67e84dd
fix shell parameter type
2022-09-06 14:41:59 +02:00
Max Eisner
d963a1ae2f
style
2022-09-06 14:41:59 +02:00
Max Eisner
2329844f50
refactor: naming
2022-09-06 14:41:58 +02:00
Max Eisner
50ae38a372
add :arg shell_parameter
2022-09-06 14:41:58 +02:00
Max Eisner
b901e5873d
do not use parantheses if no args given to method
2022-09-06 14:41:58 +02:00
Max Eisner
0509eebda4
fix: don't write binary param if base_name == binary/base_name
2022-09-06 14:41:58 +02:00
Max Eisner
fd98c3df58
add preliminary RuboCop for generate_completions DSL
2022-09-06 14:41:57 +02:00
Rylan Polster
af99dfba00
Refactor on_system rubocops for use in casks
2022-08-14 17:31:07 -04:00
Mike McQuaid
6b697470fd
brew style --fix
...
For https://github.com/Homebrew/brew/pull/13671
2022-08-10 14:19:33 +01:00
Rylan Polster
d5d6456b24
Add checks for on_system method
2022-07-24 23:01:56 +02:00
Rylan Polster
7b24ed3b4d
Update OnSystem cop to check other on_{system} methods
2022-07-24 23:01:56 +02:00
Mike McQuaid
2d5eab2e1c
brew style --fix
2022-06-30 08:56:21 +01:00
Mike McQuaid
03f7b254e9
rubocops: fix OnOs block checks.
...
This wasn't correctly flagging the use of `on_os` in `test do` as
invalid.
2022-03-29 19:15:03 +01:00
Carlo Cabrera
0f26522fad
rubocops/lines: disallow pyoxidizer as a build/runtime dependency
...
PyOxidizer downloads pre-built versions of Rust and Python, and embeds
this Python into the binaries it produces.
This goes against a number of our packaging policies, so let's make sure
formulae in Homebrew/core don't do this.
See Homebrew/homebrew-core#90025 .
2021-11-30 17:36:26 +08:00
Carlo Cabrera
1ffbcc04d4
rubocops/lines: allow OS.foo? in service blocks
...
These seem more natural, and I don't think we need to be able to mock
service blocks on other OSs.
See Homebrew/homebrew-core#90091 .
2021-11-28 21:47:21 +08:00
Bo Anderson
4836ea0ba2
Remove XQuartz handling
2021-11-05 12:40:22 +00:00
Michka Popoff
1cc7ca33c0
update: migrate everyone from linuxbrew-core to homebrew-core
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-10-20 11:01:38 +01:00
Mike McQuaid
56753c9d08
rubocops/lines: be less strict about OS.{mac,linux}? in taps.
...
Fixes #12040 .
2021-09-15 12:23:07 +01:00
Mike McQuaid
ebc4cce456
rubocops/lines: add some OS cop comments/exceptions.
...
Exclude and comment the cases the autocorrect currently doesn't work.
Follow-up from #11955 .
2021-09-08 13:46:01 +01:00
Mike McQuaid
a6e4e195c1
rubocops/lines: recommend on_os/OS.os? based on context.
...
Recommend the use of `on_macos` and `on_linux` unless we're in
`def install`, `def post_install` or `test do` in which case recommend
`OS.mac?` and `OS.linux?` instead.
2021-09-08 13:18:07 +01:00
Mike McQuaid
227a96fd7f
rubocops/lines: remove OS.mac?/OS.linux? check.
...
This will be reimplemented in https://github.com/Homebrew/brew/pull/11955
but this allows us to merge the homebrew-core changes before that PR is
merged.
Closes https://github.com/Homebrew/brew/pull/11946
2021-09-02 13:50:23 +01:00
Nanda H Krishna
5ccfbcd1d2
Autocorrect style issues with brew style --fix
2021-07-08 12:36:39 +05:30
Carlo Cabrera
92d224f0fc
rubocops/lines: check allowlist for use of ENV.runtime_cpu_detection
...
This is implements the first audit discussed in #11608 .
2021-07-01 18:38:54 +01:00
Bo Anderson
9063945b3e
Promote shell commands audit to global cop
2021-03-17 20:45:41 +00:00
Nanda H Krishna
b9cbeb3019
Merge pull request #10608 from nandahkrishna/assignment-condition-parentheses
...
style: use parentheses for assignment in conditions
2021-02-15 18:43:54 +05:30
nandahkrishna
8e5451df2f
style: use parentheses for assignment in conditions
2021-02-12 18:33:37 +05:30
Mike McQuaid
e8c71aeb8c
rubocops/lines: check for if ENV["CI"] usage.
...
Suggested in:
https://github.com/Homebrew/homebrew-core/pull/70675#issuecomment-775092539
2021-02-12 11:25:44 +00:00
Mike McQuaid
d6957a3acb
Homebrew 3.0.0 deprecations/disables
2021-01-29 19:50:24 +00:00
Jonathan Chang
b8fb568021
rubocops/lines: use rubocop v1 API
2021-01-12 19:11:42 +11:00
Jonathan Chang
f81e89193e
rubocops: update helpers for rubocop v1 API
2021-01-12 19:11:42 +11:00
souleater7
e50e3e4b22
Delete references to devel
2021-01-01 10:16:31 -08:00
Mike McQuaid
87dd13aea6
Deprecate cask requirements.
...
This probably has to wait until 2.7.0 now and will require a bunch of
formula changes/deprecations but we should probably start moving in this
direction given we're not installing any of these on our CI any more.
2020-12-15 14:19:45 +00:00
Rylan Polster
01cf98e526
Remove style exceptions for ProvidedByMacos and UsesFromMacos
2020-12-03 14:30:34 -05:00
Rylan Polster
629ad219aa
Migrate MAKE_CHECK_ALLOWLIST
2020-11-30 18:18:50 -05:00
Mike McQuaid
0793644f62
Merge pull request #9052 from jonchang/deprecate-requirements-in-core
...
audit: deprecate requirements in core
2020-11-06 15:16:18 +00:00
EricFromCanada
3768b7a6e9
apidoc: update comment wording, punctuation, formatting
2020-11-06 00:21:02 -05:00
Jonathan Chang
1b95059c2b
Restrict audit to homebrew/core
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-11-06 00:49:48 +11:00
Jonathan Chang
777dc10aa8
audit: deprecate requirements in core
...
This strict audit ensures that new formulae that depend on Requirements
like :x11, :java, and :osxfuse are not introduced into homebrew/core.
2020-11-06 00:20:34 +11:00
Markus Reiter
bf7fe45e89
Merge pull request #8896 from reitermarkus/sorbet-inline
...
Inline type annotations.
2020-10-13 10:40:53 +02:00
Rylan Polster
3b944434cf
style: allow python versions with two digits
2020-10-11 09:46:14 -04:00
Rylan Polster
40e4b38d05
style: python versions must match python dependency
2020-10-10 13:59:20 -04:00
Markus Reiter
24ae318a3d
Move type annotations into files.
2020-10-10 14:59:39 +02:00
Rylan Polster
38cedb9013
style: allow license exceptions to be on one line
2020-10-05 16:23:52 -04:00
Markus Reiter
52efa13222
Document rubocops/lines cops.
2020-08-26 03:13:59 +02:00
Rylan Polster
97b1b75dc5
style: forbid one line nested license expressions
2020-08-20 11:20:04 -04:00
Rylan Polster
ef447a38c6
style: convert from license array to license hash
2020-08-20 10:58:36 -04:00
