admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #9052 from jonchang/deprecate-requirements-in-core

Browse Source 
audit: deprecate requirements in core
This commit is contained in:
Mike McQuaid 2020-11-06 15:16:18 +00:00 committed by GitHub
commit 0793644f62
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
Library/Homebrew/rubocops/lines.rb
View File

@ -665,6 +665,23 @@ module RuboCop
end
end
# This cop ensures that new formulae depending on Requirements are not introduced in homebrew/core.
class CoreRequirements < FormulaCop
def audit_formula(_node, _class_node, _parent_class_node, _body_node)
return if formula_tap != "homebrew-core"
if depends_on? :java
problem "Formulae in homebrew/core should depend on a versioned `openjdk` instead of :java"
end
if depends_on? :x11
problem "Formulae in homebrew/core should depend on specific X libraries instead of :x11"
end
problem ":osxfuse is deprecated in homebrew/core" if depends_on? :osxfuse
end
end
# This cop makes sure that shell command arguments are separated.
#
# @api private