rubocops/lines: check for if ENV["CI"] usage.

Suggested in: https://github.com/Homebrew/homebrew-core/pull/70675#issuecomment-775092539
2021-02-12 11:25:44 +00:00 · 2021-02-12 11:25:44 +00:00 · e8c71aeb8c
commit e8c71aeb8c
parent f9b4b69f27
1 changed files with 9 additions and 0 deletions
--- a/Library/Homebrew/rubocops/lines.rb
+++ b/Library/Homebrew/rubocops/lines.rb
@ -546,6 +546,15 @@ module RuboCop
            problem "`depends_on` can take requirement classes instead of instances"
          end

+          find_instance_method_call(body_node, "ENV", :[]) do |method|
+            next unless modifier?(method.parent)
+
+            param = parameters(method).first
+            next unless node_equals?(param, "CI")
+
+            problem 'Don\'t use ENV["CI"] for Homebrew CI checks.'
+          end
+
          find_instance_method_call(body_node, "Dir", :[]) do |method|
            next unless parameters(method).size == 1