admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Remove unnecessary skip since toplevel_stanzas doesn't look in blocks

Browse Source 
Co-authored-by: Markus Reiter <me@reitermark.us>
This commit is contained in:
Issy Long 2023-03-21 00:17:02 +00:00
parent 7a4a579847
commit 794cd37dbb
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/cask/no_overrides.rb
View File

@ -25,8 +25,6 @@ module RuboCop
cask_stanzas.each do |stanza| cask_stanzas.each do |stanza|
# Skip if the stanza is itself an `on_*` block. # Skip if the stanza is itself an `on_*` block.
next if ON_SYSTEM_METHODS.include?(stanza.stanza_name) next if ON_SYSTEM_METHODS.include?(stanza.stanza_name)
# Skip if the stanza we detect is already in an `on_*` block.
next if stanza.parent_node.block_type? && ON_SYSTEM_METHODS.include?(stanza.parent_node.method_name)
# Skip if the stanza outside of a block is not also in an `on_*` block. # Skip if the stanza outside of a block is not also in an `on_*` block.
next unless stanzas_in_blocks.include?(stanza.stanza_name) next unless stanzas_in_blocks.include?(stanza.stanza_name)