From 794cd37dbbc4be1fa4a45ccb2ca2130bd700cc87 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Tue, 21 Mar 2023 00:17:02 +0000 Subject: [PATCH] Remove unnecessary skip since `toplevel_stanzas` doesn't look in blocks Co-authored-by: Markus Reiter --- Library/Homebrew/rubocops/cask/no_overrides.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/Library/Homebrew/rubocops/cask/no_overrides.rb b/Library/Homebrew/rubocops/cask/no_overrides.rb index 6d1dbbf186..82d8740d67 100644 --- a/Library/Homebrew/rubocops/cask/no_overrides.rb +++ b/Library/Homebrew/rubocops/cask/no_overrides.rb @@ -25,8 +25,6 @@ module RuboCop cask_stanzas.each do |stanza| # Skip if the stanza is itself an `on_*` block. next if ON_SYSTEM_METHODS.include?(stanza.stanza_name) - # Skip if the stanza we detect is already in an `on_*` block. - next if stanza.parent_node.block_type? && ON_SYSTEM_METHODS.include?(stanza.parent_node.method_name) # Skip if the stanza outside of a block is not also in an `on_*` block. next unless stanzas_in_blocks.include?(stanza.stanza_name)