admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/cask: Run on_system_stanzas(on_block) once in the beginning

Browse Source 
Co-authored-by: Markus Reiter <me@reitermark.us>
This commit is contained in:
Issy Long 2023-03-21 00:12:28 +00:00
parent c337dc4c81
commit 7a4a579847
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/rubocops/cask/no_overrides.rb
View File

@ -20,13 +20,15 @@ module RuboCop
# Skip if there are no `on_*` blocks.
return unless (on_blocks = cask_stanzas.select { |s| ON_SYSTEM_METHODS.include?(s.stanza_name) }).any?
stanzas_in_blocks = on_system_stanzas(on_blocks)
cask_stanzas.each do |stanza|
# Skip if the stanza is itself an `on_*` block.
next if ON_SYSTEM_METHODS.include?(stanza.stanza_name)
# Skip if the stanza we detect is already in an `on_*` block.
next if stanza.parent_node.block_type? && ON_SYSTEM_METHODS.include?(stanza.parent_node.method_name)
# Skip if the stanza outside of a block is not also in an `on_*` block.
next unless on_system_stanzas(on_blocks).include?(stanza.stanza_name)
next unless stanzas_in_blocks.include?(stanza.stanza_name)
add_offense(stanza.source_range, message: format(MESSAGE, stanza: stanza.stanza_name))
end