Caleb Xu
ff2ce2f093
extract: better success message
...
Fixes the empty rev string when copying file from HEAD; explicitly
set rev to HEAD in that case.
2018-08-25 13:35:08 -04:00
Caleb Xu
d4a2006f04
extract: add missing monkey-patch
2018-08-25 13:33:25 -04:00
Caleb Xu
be0cd21d0f
extract: explicitly load cli_parser
2018-08-25 10:58:13 -04:00
Caleb Xu
0e080eba97
extract: simplify integration tests
2018-08-25 10:51:31 -04:00
Caleb Xu
1e4cd780c3
extract: fix style
2018-08-25 10:49:06 -04:00
Caleb Xu
9ab3ff4a41
extract: add spec/integration test
2018-08-24 11:42:11 -04:00
Caleb Xu
a232e3a791
extract: fix corner case
...
If the formula to be retrieved was just version-bumped in the most
recent commit (HEAD), we would've ended up grabbing the second-most
recent version.
Instead, if the file already exists in tree at the current commit,
just construct the formula from that to get the version (for naming
purposes) and copy the file outright to its new location.
2018-08-24 11:38:14 -04:00
Caleb Xu
bc551d5ed1
extract: regenerate docs and manpages
2018-08-21 10:17:23 -04:00
Caleb Xu
0552dcff62
extract: accept tap as a non-flagged argument
2018-08-21 10:17:23 -04:00
Caleb Xu
6018968f91
Further collapse monkeypatches
2018-08-21 10:17:23 -04:00
Caleb Xu
875885dda6
Add a starter file for spec
2018-08-21 10:17:23 -04:00
Caleb Xu
713aedb6ed
Fix code review requests
2018-08-21 10:17:23 -04:00
Caleb Xu
260867627b
Switch back to monkey-patching
...
Also gsub! some particular formula contents to work around older
formulae ("brewkit" isn't around anymore, and url is expected to
be a method, not an instance variable).
2018-08-21 10:17:23 -04:00
Caleb Xu
95abdf9662
Use refinements instead of general monkey-patching
2018-08-21 10:17:23 -04:00
Caleb Xu
ff8b5f8c5a
extract: rework to search through old/deleted formulae
...
- Removed use of FormulaVersions - it's generally too brittle for our uses. We
now interface directly with the Git repo via utils/git and monkeypatch the
formula loading process where needed.
- Really old formulae (that specify fields as instance vars instead of methods)
still need more work to be supported; they don't work here quite yet.
- Properly handles deleted/removed formulae from Homebrew/homebrew-core.
Additional work is still needed to search through Homebrew/legacy-homebrew if
this functionality is desired.
2018-08-21 10:17:23 -04:00
Caleb Xu
8d8d235019
Bring up manpages and docs to match new changes
2018-08-21 10:17:23 -04:00
Caleb Xu
1003aa72c9
Additional fixups for extract command
...
- Rework command line options
- Make specifying a version optional
- Remove stdout option and require a tap to be specified
- Do not allow user to extract into homebrew/core
- Rework new class name generation to use existing Formulary tools
2018-08-21 10:17:23 -04:00
Caleb Xu
bd2ac70c0f
Fix style issues in extract command
2018-08-21 10:17:23 -04:00
Caleb Xu
1dff2f141c
Add manpages/docs for extract command
2018-08-21 10:17:23 -04:00
Caleb Xu
055460884b
Fix up extract command
...
- Move from cmd to dev-cmd
- Add --stdout flag
- Add sanity checks for args/flags
- Minor rewording on error messages
2018-08-21 10:17:23 -04:00
Caleb Xu
2952a9bf74
Add new extract command to retrieve old versions of formulae
2018-08-21 10:17:23 -04:00
Markus Reiter
664bd9ac0f
Merge pull request #4728 from reitermarkus/languages
...
Ignore unparsable system languages.
2018-08-21 10:58:22 +02:00
Markus Reiter
b119591c69
Merge pull request #4731 from reitermarkus/use-cp
...
Use `cp` instead of `FileUtils.copy_entry`.
1.7.2
2018-08-20 23:56:37 +02:00
Markus Reiter
556e76b037
Use cp
instead of FileUtils.copy_entry
.
2018-08-20 19:06:55 +02:00
Markus Reiter
48dcf19169
Ignore unparsable system languages.
2018-08-19 22:10:20 +02:00
Mike McQuaid
c9aa25e6d2
Merge pull request #4722 from kabel/remove-chdir-twice
...
Remove the chdir call that was already moved to the ancestor
2018-08-19 16:21:20 +01:00
Mike McQuaid
8f1a3b53c3
Merge pull request #4727 from commitay/conflicts-cop-node
...
conflicts_cop: remove `node@` from whitelist
2018-08-19 16:16:15 +01:00
commitay
84216f5aa8
conflicts_cop: remove node@
from whitelist
2018-08-19 17:35:23 +10:00
Mike McQuaid
b2bfa6247f
Merge pull request #4678 from sjackman/mdfind
...
OS::Mac.mdfind: No need to guard on OS.mac?
2018-08-18 12:06:05 +01:00
Mike McQuaid
b87f2f55c8
Merge pull request #4716 from woodruffw/curl-git-dev-paths
...
brew.sh: Allow developers to specify curl/git paths
2018-08-18 12:05:29 +01:00
Mike McQuaid
bab5b02293
Merge pull request #4620 from brianmorton/hbc_analytics
...
Add analytics to cask installs
2018-08-18 09:33:36 +01:00
Mike McQuaid
86f27baea3
docs/Analytics: note install_on_request
and cask_install
.
2018-08-18 08:49:07 +01:00
Mike McQuaid
077e9f0c53
hbc/installer: don't send analytics for private taps.
2018-08-18 08:48:49 +01:00
Mike McQuaid
9fc8265f05
Merge pull request #4723 from Homebrew/revert-4717-error-pipe
...
Revert "Use JSON to marshal errors from children"
2018-08-18 08:48:35 +01:00
Mike McQuaid
b068e4b927
update-report: tweak cask analytics messaging.
2018-08-18 08:26:44 +01:00
Mike McQuaid
7df5b7057e
Revert "Use JSON to marshal errors from children"
2018-08-18 08:20:13 +01:00
Kevin Abel
584cced003
Remove the chdir call that was already moved to the ancestor
...
528b4b367ed2a4026c321e2f2e503ace4548b9d2 moved the chdir definition to
the parent class and call it in the parent's stage. chdir was getting
called twice for archives with two nested directories.
2018-08-17 23:13:23 -05:00
Brian Morton
7ced0be133
Merge branch 'master' into hbc_analytics
2018-08-17 16:18:40 -07:00
Mike McQuaid
b8e276ad8a
Merge pull request #4717 from woodruffw/error-pipe
...
Use JSON to marshal errors from children
2018-08-17 22:06:27 +01:00
Mike McQuaid
89e0302bb4
Merge pull request #4713 from JBallin/contributing-fork
...
CONTRIBUTING: Add "How to contribute" section
2018-08-17 22:04:03 +01:00
JBallin
4141c494d9
Link first-timers to "How To Open A Homebrew Pull Request"
2018-08-17 12:53:12 -07:00
William Woodruff
5c90833f0a
Use JSON to marshal errors from children
2018-08-17 15:23:08 -04:00
William Woodruff
a7816eea6e
brew.sh: Remove whitespace
2018-08-17 15:20:05 -04:00
William Woodruff
60741c5c25
brew.sh: Integrate curl/git path checks into main checks
2018-08-17 15:17:14 -04:00
William Woodruff
479f82904b
brew.sh: Allow developers to specify curl/git paths
...
This introduces the HOMEBREW_CURL_PATH and HOMEBREW_GIT_PATH
variables, which are used to populate HOMEBREW_CURL and HOMEBREW_GIT,
respectively, when in developer mode (HOMEBREW_DEVELOPER).
Both paths are expected to be valid executables and must
have the executable bit set.
2018-08-17 14:59:07 -04:00
Jonathan Chang
a11039d854
Merge pull request #4710 from jonchang/audit-scope-fix
...
audit: don't error when test block is missing
2018-08-16 17:00:29 -04:00
Jonathan Chang
25d0c020c9
audit: don't error when test block is missing
2018-08-16 16:42:08 -04:00
Jonathan Chang
a5a6da5861
Merge pull request #4698 from jonchang/audit-scope
...
audit: fixes for test checks
2018-08-16 14:45:51 -04:00
Mike McQuaid
3a8165cf40
Merge pull request #4694 from JBallin/docs-upgrade-cleanup
...
[docs] Clarify upgrade --cleanup only cleans upgraded formulae
2018-08-16 19:23:42 +01:00
Jonathan Chang
ca59377a90
audit: add autocorrect and tests for test checks
2018-08-16 12:43:50 -04:00