20359 Commits

Author SHA1 Message Date
Maxim Belkin
22bc5a94e7
Properly handle outdated cURL
`HOMEBREW_CURL_PATH` has an effect only when `HOMEBREW_DEVELOPER` is set. However, the part of `brew.sh` that prints a message about outdated cURL disregards the value of `HOMEBREW_DEVELOPER`, which leads to a misleadnig message telling the user that `HOMEBREW_CURL_PATH` is outdated even though another cURL was used/tested.

This PR fixes it and instructs Homebrew to:

1. Display a warning message when system cURL is outdated and either `HOMEBREW_CURL_PATH` **or `HOMEBREW_DEVELOPER`** are not set. New `HOMEBREW_CURL_WARNING` variable is set to display the above warning only once (useful when `brew` calls itself internally).
2. Display `Installing Homebrew cURL` before auto-installing cURL in `update.sh` (due to `HOMEBREW_FORCE_BREWED_CURL`) and stop/exit if this step fails.
3. Display `Installing Homebrew Git` before auto-installing Git in `update.sh` (due to `HOMEBREW_FORCE_BREWED_GIT`) and stop/exit if this step fails.
2020-11-19 10:14:10 -06:00
Markus Reiter
ae8ebf9464 Add rspec-sorbet. 2020-11-19 16:14:22 +01:00
Markus Reiter
70dd41cfd8 Add type signatures to BuildEnvironment. 2020-11-19 16:07:50 +01:00
Markus Reiter
220b4606ca Add type signatures to GitHub::Actions. 2020-11-19 16:07:50 +01:00
Markus Reiter
60d1246cb7 Add type signatures to Utils::Shebang. 2020-11-19 16:07:50 +01:00
Markus Reiter
a42cc9499e Add type signatures to Cask::Cache. 2020-11-19 16:07:50 +01:00
Markus Reiter
0b6c31fc70 Add type signatures to Cask::Pkg. 2020-11-19 16:07:50 +01:00
Markus Reiter
845887914e Mark TopologicalHash # typed: true. 2020-11-19 16:07:50 +01:00
Markus Reiter
66bf1314a1 Add type signatures for Cask::Staged. 2020-11-19 16:07:50 +01:00
Markus Reiter
64a0e9a721 Add type signatures for Caskroom. 2020-11-19 16:07:50 +01:00
Markus Reiter
bc24128263 Support casks in brew cat. 2020-11-19 16:01:10 +01:00
Markus Reiter
2c47678b05 Add --zap flag to brew uninstall and remove brew zap. 2020-11-19 15:07:59 +01:00
Mike McQuaid
35db40fe25
Disable Java requirement versions on Big Sur
It would be possible to work around this but I'm not convinced it's
worth it given https://github.com/Homebrew/homebrew-core/issues/63290

Fixes #9194
2020-11-19 14:03:57 +00:00
Markus Reiter
f4b4fdac98 Add brew zap command. 2020-11-19 13:42:02 +01:00
Jonathan Chang
a094e43337 cli: fix type signature of to_kegs_to_casks 2020-11-19 21:00:56 +11:00
Markus Reiter
aa6a8e5c13 Add --update option to brew vendor-gems. 2020-11-19 10:11:19 +01:00
Issy Long
7bcf554799
rubocops/components_order: Specify disable! and deprecate! order
- Ordering them this way seems to require less `--fix`ing in
  Homebrew/homebrew-core than the other way around.
- In the Big Sur bottling, we found many repos that were archived. We've
  been going through and deprecating repos that are archived or that
  don't build any more. I felt weird without the ordering of these
  stanzas without an audit to guide me - I spent time looking at
  previous examples to see "should `deprecate!` go before or after
  `depends_on`" question. Computers can tell us this instead.
2020-11-18 21:44:46 +00:00
Markus Reiter
9bfbeace54 Fix corrected_problem_count and new_formula_problem_lines. 2020-11-18 18:37:53 +01:00
Markus Reiter
873b2a0042 Fix brew audit --tap=<tap>. 2020-11-18 18:29:20 +01:00
Markus Reiter
5097af3b74 Support --cask flag in brew uninstall. 2020-11-18 17:30:34 +01:00
Markus Reiter
24cef5c2ce Support casks in brew audit. 2020-11-18 13:21:49 +01:00
Mike McQuaid
97a7b02f8e
Merge pull request #9188 from MikeMcQuaid/install-quiet-tweaks
Improve `brew install --quiet`
2020-11-18 11:31:43 +00:00
Mike McQuaid
4665a756b5
Merge pull request #9189 from MikeMcQuaid/big-sur-cleanup
Big Sur cleanup
2020-11-18 11:05:24 +00:00
Markus Reiter
dc11f02e16 Move auditor classes into separate files. 2020-11-18 11:22:27 +01:00
Mike McQuaid
74264b8582
Big Sur cleanup
Remove `HOMEBREW_BIG_SUR_TESTING` variable as it is no longer needed.
2020-11-18 10:15:53 +00:00
Mike McQuaid
caae165eb2
Improve brew install --quiet
- Suppress (some more) warnings when doing `brew install --quiet`
- Clarify `man brew` output that we don't suppress all warnings
  for all commands with `--quiet`

While I was doing this I noticed references to the (soon to be
deprecated) `brew switch` so:
- remove these references in `install` output
- remove a reference in the documentation
- add a comment to remind me to deprecate `brew diy`, too

Fixes #9179
2020-11-18 10:13:57 +00:00
Markus Reiter
04272f5f68 Move TapAuditor into separate file. 2020-11-18 10:25:32 +01:00
Markus Reiter
e54e719e38 Add Cask::Cmd::Audit.audit_casks method. 2020-11-18 10:25:32 +01:00
Mike McQuaid
f00e094884
Merge pull request #9176 from EricFromCanada/show-upgradeable-dependents
upgrade: show upgradeable dependents during dry run
2020-11-18 09:14:20 +00:00
Markus Reiter
7c5d8a5288 Refactor FormulaInstaller. 2020-11-18 09:30:11 +01:00
Markus Reiter
549763d594 Don't create package.json in current directory. 2020-11-18 08:40:59 +01:00
Markus Reiter
7904cfd122
Merge pull request #9183 from reitermarkus/fix-tests
Unset `HOMEBREW_BAT` in tests.
2020-11-18 08:06:58 +01:00
Markus Reiter
dfeb1b4d08 Unset HOMEBREW_BAT in tests. 2020-11-18 07:03:39 +01:00
Markus Reiter
d1cb2dd872
Merge pull request #9181 from reitermarkus/local-tests
Fix tests failing locally.
2020-11-18 07:01:43 +01:00
Markus Reiter
f87c9c5dc4 Fix tests failing locally. 2020-11-18 05:54:42 +01:00
Markus Reiter
da922db811
Merge pull request #9153 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2020-11-18 05:36:12 +01:00
Markus Reiter
a014f65e41 Fix type checking errors. 2020-11-18 04:21:41 +01:00
Markus Reiter
47aded9dac
Merge pull request #9166 from reitermarkus/rubocop
Enable `Performance/ConstantRegexp` cop.
2020-11-18 04:16:38 +01:00
BrewTestBot
c74d8434d6 sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2020-11-18 04:16:22 +01:00
Markus Reiter
a81edc3940
Merge pull request #9165 from MikeMcQuaid/named_args_tap
cli/named_args: don't convert to taps.
2020-11-18 02:48:52 +01:00
Dustin Rodrigues
028087e7f2
Merge pull request #9155 from dtrodrigues/checksum-change-scheme
audit: allow checksum to be added/removed when changing download scheme
2020-11-17 20:14:34 -05:00
EricFromCanada
bcdb0c7698 upgrade: show upgradeable dependents during dry run 2020-11-17 18:26:35 -05:00
miccal
42881ebc55 shared_audits: add haptickey to GITHUB_PRERELEASE_ALLOWLIST 2020-11-18 06:54:24 +08:00
Mike McQuaid
f212bf20cb
cli/named_args: don't convert to taps.
Fixes https://github.com/Homebrew/brew/issues/8966
2020-11-17 17:31:30 +00:00
Daniel Bayley
cfceee7872 Fix brew style checks on Brewfiles
Fixes https://github.com/Homebrew/homebrew-test-bot/issues/522
2020-11-17 16:05:11 +00:00
Markus Reiter
af4143150d
Merge pull request #9163 from reitermarkus/lzma
Unify `Lzma` and `Xz`.
2020-11-17 15:23:55 +01:00
Markus Reiter
71095f2147 Enable Performance/ConstantRegexp cop. 2020-11-17 15:18:37 +01:00
Mike McQuaid
07b8304468
Merge pull request #8899 from hyuraku/hide_deprecated_cask_command
hide deprecated cask command
2020-11-17 13:35:05 +00:00
Dustin Rodrigues
d26567a65d audit: allow checksum to be added/removed when changing download scheme 2020-11-17 08:02:55 -05:00
Markus Reiter
421853217f
Merge pull request #9161 from peterlewis/dmg-ulmo-fix
unpack_strategy: Move `Dmg` to above `Xz` and `Lzma`
2020-11-17 13:51:57 +01:00