admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: allow checksum to be added/removed when changing download scheme

Browse Source
This commit is contained in:
Dustin Rodrigues 2020-11-16 19:37:57 -05:00
parent 421853217f
commit d26567a65d
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/dev-cmd/audit.rb
View File

@ -943,7 +943,8 @@ module Homebrew
if current_version == newest_committed_version &&
current_url == newest_committed_url &&
current_checksum != newest_committed_checksum
current_checksum != newest_committed_checksum &&
current_checksum.present? && newest_committed_checksum.present?
problem(
"stable sha256 changed without the url/version also changing; " \
"please create an issue upstream to rule out malicious " \

13
Library/Homebrew/test/dev-cmd/audit_spec.rb
View File

@ -717,6 +717,19 @@ module Homebrew
it { is_expected.to be_nil }
end
context "can be removed when switching schemes" do
before do
formula_gsub_origin_commit(
'url "https://brew.sh/foo-1.0.tar.gz"',
'url "https://foo.com/brew/bar.git", tag: "1.0", revision: "f5e00e485e7aa4c5baa20355b27e3b84a6912790"',
)
formula_gsub_origin_commit('sha256 "31cccfc6630528db1c8e3a06f6decf2a370060b982841cfab2b8677400a5092e"',
"")
end
it { is_expected.to be_nil }
end
end
context "revisions" do