Markus Reiter
fd5e673d2d
Merge pull request #2825 from reitermarkus/refactoring
...
Refactoring using `Forwardable` and `DelegateClass`.
2017-07-01 05:32:19 +02:00
JCount
0a5052141d
Merge pull request #2827 from JCount/version-improve-url-only-version-parsing
...
version: improve url-only version parsing
2017-06-30 11:37:28 -04:00
Gautham Goli
e6938d9201
Enable LegacyPatches cop
2017-06-30 20:25:18 +05:30
Gautham Goli
8c167b23cc
audit: Don't run audit methods when --only-cops
is passed
2017-06-30 20:25:12 +05:30
JCount
d50312ae6b
version_spec: add tests for char prefixed and w.x.y.z url-only styles
2017-06-30 10:53:24 -04:00
JCount
f87fadd4ee
version: improve parsing of url-only, non-filename versions
...
add support for styles prefixed with a r,v,V and an optional _ ,
and styles with four groups of digits, seperated by periods;
combinations of the two are also supported
2017-06-30 10:53:24 -04:00
Mike McQuaid
bfe4eed034
Merge pull request #2826 from chrmoritz/languagenode
...
language/node: multiple improvements
2017-06-30 15:14:32 +01:00
Mike McQuaid
202b3bc2c1
Merge pull request #2813 from DomT4/high_sierra_updates
...
High Sierra: update expected CLT/libcurl pkgconfig file.
2017-06-30 15:10:23 +01:00
Markus Reiter
29ffe15890
Merge pull request #2819 from reitermarkus/trash
...
🗑️ Use AppleScript instead of Swift for trashing.
2017-06-30 14:38:57 +02:00
Misty De Meo
0077e4f20e
Merge pull request #2837 from mistydemeo/audit_request_full_index_patches
...
audit: ask for full_index patches
2017-06-29 19:57:14 -07:00
Misty De Meo
5b464babf8
Define a custom assertion failure error for cross-version compat
...
Fixes #2840 .
2017-06-29 17:40:04 -07:00
Markus Reiter
6a1fa87191
Refactor Formula/Cask dependencies.
2017-06-30 02:20:50 +02:00
Christian Moritz
5e00c277ce
partly revert log verbose npm pack output commit
...
to fix issues with shwoing npm debug output even on non-verbose install runs.
2017-06-30 00:55:34 +02:00
Christian Moritz
6baea2543a
language/node: set cache config via argument
...
instead of writing a .npmrc file, which simplifies the code.
npm_cache_config is still preserved for backwarts compatiblility and
usage int he kibana@n formulas in core.
2017-06-29 20:29:25 +02:00
Christian Moritz
466fe9841a
language/node: npm pack ignore prepublish scripts
...
This tells npm pack to don't run prepublish scripts at all.
I think this is the best default because:
* most modules don't have a prepublish script at all and aren't affected
by this change
* most prepublish scripts are calling devDeps, which would fail in our
case, because (dev)Deps aren't installed at npm pack time until #2820
gets resolved
* we favor npm registry tarball for formula downloads, which are already
prepublished, so we would in the best case needlessly run prepublish
a second time and in the worst case it would fail (because a clean
step is required before running prepublish a second time in a row)
* This change does the right thing for >99% of all the packages and
would only affect packages with prepublish scripts downloaded from a
non-npm registry tarball (like github tarballs) and with a prepublish
script wich does no't require any devDep (unlike for cross platform)
2017-06-29 20:29:25 +02:00
Christian Moritz
fe39dbb78c
language/node: log verbose npm pack output
...
This makes npm pack to log verbose debug output to the console to
simplify debugging npm pack failures.
Refs: https://github.com/Homebrew/brew/pull/2820#discussion_r123890729
Prevously Utils.popen_read swallowed all debug output.
2017-06-29 20:29:25 +02:00
Christian Moritz
495520a1f9
language/node: make packname detection more robust
...
This fixes some edge cases where verbose output from a prepublish script
could break our npm pack package name detection code by only using the
last line of the output printed by npm itself containing the desired
package name.
2017-06-29 20:29:25 +02:00
Christian Moritz
02113e2714
language/node: build native addons from source
...
By telling node-pre-gyp and prebuild to don't pull prebuild binaries and
instead build them from source. This still may not work for some custom
third party scripts for pulling prebuild binaries.
2017-06-29 20:29:25 +02:00
Christian Moritz
7d8124f339
language/node: set npm loglevel to max -ddd
...
to match the loglevel used in npm_debug.log (previous --verbose loglevel
would match -dd)
2017-06-29 20:29:25 +02:00
ilovezfs
7013f9dee3
formula_desc_cop: allow formula name in desc
...
except at the very beginning, as the audit originally intended.
See https://github.com/Homebrew/legacy-homebrew/pull/45493 .
2017-06-29 08:14:58 -07:00
Mislav Marohnić
f8ec2332a2
Strip trailing newline
2017-06-29 13:28:55 +02:00
Misty De Meo
87fa20076c
audit: ask for full_index patches
2017-06-28 20:49:37 -07:00
Markus Reiter
96271aaa89
Use attr_reader
in CaskLoader
.
2017-06-28 10:05:48 +02:00
Markus Reiter
2703646b10
Remove utf8_inspect
method.
2017-06-28 09:25:31 +02:00
Markus Reiter
3b4ee58c49
Refactor using Forwardable
and DelegateClass
.
2017-06-28 09:25:31 +02:00
Mislav Marohnić
3701b11e42
Fix unshallowing taps in bump-formula-pr
...
Never try to unhshallow full clones.
2017-06-27 23:45:57 +02:00
Mislav Marohnić
b3ef9ccb8a
Fix bump-formula-pr
when working with a shallow git clone
...
Creating a fork and pushing to it doesn't work when the repository in
question is a shallow clone. By default, Homebrew clones all taps in
shallow mode unless `--full` was passed or $HOMEBREW_DEVELOPER was set.
2017-06-27 14:32:09 +02:00
Ed Flanagan ed@flanagan.xyz
700b5e2738
Add PreToken composite
2017-06-27 03:17:23 -07:00
Markus Reiter
a636d58067
🥚 No easter egg for you!
2017-06-27 12:07:40 +02:00
ilovezfs
13576111e0
Merge pull request #2822 from ilovezfs/software_spec-recursive-reqs
...
software_spec: define recursive deps and reqs
2017-06-25 08:43:24 -07:00
Mike McQuaid
3ce667f3b9
Merge pull request #2823 from MikeMcQuaid/test-simplify-minitest
...
test: simplify minitest inclusion.
2017-06-25 13:30:47 +01:00
Mike McQuaid
c45cca8e36
test: simplify minitest inclusion.
...
The previous version seems needlessly complicated given we only support
a single Ruby version. It was also blowing up on Bundler 1.15.X.
2017-06-25 13:04:36 +01:00
ilovezfs
cbf89e50bb
software_spec: define recursive deps and reqs
2017-06-25 03:38:21 -07:00
Mike McQuaid
943c69f6a6
Merge pull request #2814 from mansimarkaur/java
...
[WIP] Added tests for language/java
2017-06-25 09:18:36 +01:00
Mike McQuaid
f4cdd7a051
Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop
...
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-25 08:54:59 +01:00
mansimarkaur
fac708da7a
changes test names for class methods
2017-06-25 06:27:53 +05:30
mansimarkaur
1df9a475a8
Set java environment var to test overriding
2017-06-25 06:04:09 +05:30
Mike McQuaid
73d81bb96d
Merge pull request #2777 from mansimarkaur/inc_test_cov
...
Added tests for language/node.rb
2017-06-24 22:30:47 +01:00
Mike McQuaid
5f8a86c178
Merge pull request #2816 from MikeMcQuaid/test-needs-link
...
test: require non-keg-only formulae to be linked.
2017-06-24 13:30:21 +01:00
Mike McQuaid
1956c0a01c
Merge pull request #2817 from MikeMcQuaid/no-fossies-url
...
audit: don't use Fossies as a primary URL.
2017-06-24 13:29:42 +01:00
Gautham Goli
2e82754776
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-24 17:06:26 +05:30
Markus Reiter
f24fc42362
🔥 Remove test files after trashing.
2017-06-24 09:15:37 +02:00
Markus Reiter
a1f9032b95
🗑️ Use AppleScript instead of Swift for trashing.
2017-06-24 09:15:37 +02:00
mansimarkaur
67c48360fa
Improved code quality
2017-06-24 02:34:10 +05:30
mansimarkaur
66d5baf3fe
Removed extra space from include clause
2017-06-24 02:18:52 +05:30
Mike McQuaid
b9e3daac70
audit: don't use Fossies as a primary URL.
...
As requested in:
https://github.com/Homebrew/homebrew-core/issues/14486#issuecomment-307753234
2017-06-23 19:34:25 +01:00
Mike McQuaid
7d5cce569d
test: require non-keg-only formulae to be linked.
...
This can be overridden with `--force`.
As mentioned in:
https://github.com/Homebrew/homebrew-core/pull/14525#issuecomment-307838164
2017-06-23 17:42:09 +01:00
ilovezfs
301a6dc1d9
formula_installer: runtime reqs of build deps are build reqs
...
so don't consider their absence fatal if we're pouring a bottle.
2017-06-23 08:44:56 -07:00
mansimarkaur
690e841fca
Added tests for language/java
2017-06-23 06:26:23 +05:30
mansimarkaur
bfd19f9170
Stubbed nil:NilClass
2017-06-23 03:40:03 +05:30