11445 Commits

Author SHA1 Message Date
Mike McQuaid
53038a14b3 Merge pull request #2940 from kevinburke/move-brew-prefix
Speed up brew --prefix
2017-07-25 16:12:25 +01:00
Mike McQuaid
733abc7e7d Merge pull request #2932 from GauthamGoli/audit_urls_rubocop_part_2
audit: Port audit_urls to rubocop and add corresponding tests Part 2
2017-07-25 15:46:23 +01:00
Kevin Burke
be1764c0a5
Speed up brew --prefix
Move --prefix, --cellar to the top of brew.sh. Timings on master:

    brew --prefix > /dev/null  0.05s user 0.03s system 46% cpu 0.165 total
    brew --prefix > /dev/null  0.05s user 0.04s system 63% cpu 0.131 total
    brew --prefix > /dev/null  0.04s user 0.03s system 72% cpu 0.104 total
    brew --prefix > /dev/null  0.04s user 0.03s system 87% cpu 0.080 total
    brew --prefix > /dev/null  0.04s user 0.03s system 81% cpu 0.080 total
    brew --prefix > /dev/null  0.04s user 0.03s system 84% cpu 0.075 total
    brew --prefix > /dev/null  0.04s user 0.03s system 83% cpu 0.080 total
    brew --prefix > /dev/null  0.04s user 0.02s system 84% cpu 0.072 total
    brew --prefix > /dev/null  0.04s user 0.03s system 86% cpu 0.072 total
    brew --prefix > /dev/null  0.04s user 0.03s system 82% cpu 0.075 total
    brew --prefix > /dev/null  0.04s user 0.03s system 85% cpu 0.072 total
    brew --prefix > /dev/null  0.04s user 0.03s system 84% cpu 0.076 total
    brew --prefix > /dev/null  0.04s user 0.03s system 85% cpu 0.074 total
    brew --prefix > /dev/null  0.03s user 0.03s system 83% cpu 0.073 total
    brew --prefix > /dev/null  0.04s user 0.02s system 83% cpu 0.072 total
    brew --prefix > /dev/null  0.03s user 0.03s system 86% cpu 0.068 total
    brew --prefix > /dev/null  0.04s user 0.03s system 82% cpu 0.080 total
    brew --prefix > /dev/null  0.04s user 0.03s system 84% cpu 0.079 total
    brew --prefix > /dev/null  0.04s user 0.02s system 83% cpu 0.070 total
    brew --prefix > /dev/null  0.03s user 0.03s system 84% cpu 0.072 total

With the patch applied:

    brew --prefix > /dev/null  0.02s user 0.02s system 24% cpu 0.157 total
    brew --prefix > /dev/null  0.02s user 0.03s system 53% cpu 0.078 total
    brew --prefix > /dev/null  0.02s user 0.02s system 64% cpu 0.056 total
    brew --prefix > /dev/null  0.02s user 0.03s system 74% cpu 0.065 total
    brew --prefix > /dev/null  0.01s user 0.02s system 73% cpu 0.049 total
    brew --prefix > /dev/null  0.01s user 0.02s system 77% cpu 0.050 total
    brew --prefix > /dev/null  0.01s user 0.02s system 64% cpu 0.054 total
    brew --prefix > /dev/null  0.01s user 0.02s system 77% cpu 0.049 total
    brew --prefix > /dev/null  0.01s user 0.02s system 56% cpu 0.061 total
    brew --prefix > /dev/null  0.02s user 0.02s system 66% cpu 0.060 total
    brew --prefix > /dev/null  0.01s user 0.02s system 62% cpu 0.057 total
    brew --prefix > /dev/null  0.01s user 0.02s system 71% cpu 0.052 total
    brew --prefix > /dev/null  0.02s user 0.03s system 67% cpu 0.063 total
    brew --prefix > /dev/null  0.01s user 0.02s system 70% cpu 0.042 total
    brew --prefix > /dev/null  0.02s user 0.02s system 68% cpu 0.056 total
    brew --prefix > /dev/null  0.01s user 0.02s system 73% cpu 0.049 total
    brew --prefix > /dev/null  0.01s user 0.02s system 62% cpu 0.058 total
    brew --prefix > /dev/null  0.02s user 0.02s system 67% cpu 0.058 total
    brew --prefix > /dev/null  0.01s user 0.02s system 73% cpu 0.043 total
    brew --prefix > /dev/null  0.01s user 0.02s system 65% cpu 0.055 total
2017-07-25 07:00:49 -07:00
Mike McQuaid
f0ca3108f7 Merge pull request #2931 from JCount/version-devel-parsing-improvements
version: improve devel spec version parsing
2017-07-25 14:38:13 +01:00
Gautham Goli
2639b6c556 audit: Update Urls Cop with more rules of audit_urls and corresponding tests 2017-07-25 19:06:36 +05:30
Mike McQuaid
7041f7eb00 Merge pull request #2911 from GauthamGoli/audit_urls_rubocop_part_1
audit: Port audit_urls partially to rubocop and add corresponding tests
2017-07-25 13:46:19 +01:00
Mike McQuaid
0b0ab9b606 Merge pull request #2924 from sjackman/sse4-linux
cpu: fix SSE4 detection on Linux
2017-07-25 13:31:44 +01:00
Bob W. Hogg
76e246059e Follow the XDG Base Directory specification for caching on Linux
Prefer $XDG_CACHE_HOME if defined, falling back to $HOME/.cache.
The Mac cache location is not affected by this change.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-07-24 09:11:14 -07:00
Markus Reiter
aa8eb21b8c Merge pull request #2861 from reitermarkus/cask-search-tty
Output plain list when running `brew cask search` without a TTY.
2017-07-24 00:04:43 +02:00
Mike McQuaid
a947bfbf47 Merge pull request #2922 from MikeMcQuaid/config-libexec-python
system_config: look for python formula binary.
2017-07-23 15:21:01 +01:00
JCount
a5fff4547f verion_spec: add test coverage for devel spec version style
also expand coverage for improved dash version style
2017-07-22 19:31:36 -04:00
JCount
1502e5b897 version: improve devel spec version parsing
term this 'devel spec version style';
also improve dash version style parsing
2017-07-22 19:28:19 -04:00
William Woodruff
7c9b170ea0
linkage_checker: Whitelist another harmless dylib
libgcc_s.1.dylib is a variation on libgcc_s_ppc64.1.dylib.
2017-07-22 15:44:55 -04:00
Shaun Jackman
5198e80724 cpu: fix SSE4 detection on Linux 2017-07-22 11:29:19 +02:00
Mike McQuaid
acb418c488 system_config: look for python formula binary.
Now that Python has been renamed it's important that we still output
which Python they are using for debugging purposes e.g.

```
Python: /usr/local/opt/python/libexec/bin/python => /usr/local/Cellar/python/2.7.13_1/Frameworks/Python.framework/Versions/2.7/bin/python2.7
```
2017-07-21 17:31:35 +01:00
Mike McQuaid
fe35bb32e8 tab: include aliases.
Including aliases in the tab allows e.g. `brew switch` to correctly
handle switching between different keg’s aliases.
2017-07-21 17:20:54 +01:00
Mike McQuaid
43c8223dcc formula: ensure aliases don’t include full names.
Aliases that include `/`s end up creating directories and this is bad.
2017-07-21 17:20:12 +01:00
Gautham Goli
b7ddd271e1 audit: Port audit_urls partially to rubocop and add corresponding tests 2017-07-21 20:50:28 +05:30
Mike McQuaid
9747bc397a Merge pull request #2906 from GauthamGoli/new_formula_rubocop_fix
style: disable NewFormulaAudit cops' execution by default unless specified
2017-07-21 14:41:40 +01:00
Markus Reiter
9578e2995a Move Hbc::DSL#license to compat. 2017-07-21 10:50:10 +01:00
Mike McQuaid
2d18ba586b Enable more deprecations.
It's been long enough that these have been commented out so let's
enable them globally.
2017-07-21 10:50:07 +01:00
Mike McQuaid
bd06a7926c diagnostic: use ENV[] 2017-07-20 20:02:34 +01:00
Justin Baugh
0a9de6b8a6 Update source check to match style 2017-07-20 14:44:20 -04:00
Justin Baugh
e077bfe655 Address rubocop issues 2017-07-20 11:57:43 -04:00
Justin Baugh
dd334a8357 Add updated diagnostic test for build from source check. 2017-07-20 11:18:16 -04:00
Justin Baugh
7504d830cb Add warning to doctor if HOMEBREW_BUILD_FROM_SOURCE is set. 2017-07-20 11:08:53 -04:00
ilovezfs
4fb7626ce5 python_requirement: prefer Homebrew's Python
This avoids linkage to both system Python and Homebrew's python.
2017-07-20 02:54:04 -07:00
Misty De Meo
f8300b2cb7 Merge pull request #2883 from mistydemeo/allow_passing_hash_to_system
Allow passing hash to system
2017-07-18 12:53:54 -07:00
Gautham Goli
086e540231 Add a rubocop config file to control cops' execution in audit and style 2017-07-18 20:23:03 +05:30
Misty De Meo
32b7e32856
formula: use env helper 2017-07-15 17:41:17 -07:00
Misty De Meo
8e645dfbec
build: use with_env helper 2017-07-15 17:40:55 -07:00
Misty De Meo
610af15f0e
run_as_not_developer: use with_env helper 2017-07-15 17:40:35 -07:00
Misty De Meo
890788af65
FileUtils.make: don't bypass superenv 2017-07-15 17:40:21 -07:00
Misty De Meo
30adcab6cf
Add with_env helper to set temporary ENV vars 2017-07-15 17:39:55 -07:00
Gautham Goli
5b3231ea0a style: disable NewFormulaAudit cops' execution by default unless specified 2017-07-15 22:40:26 +05:30
Mike McQuaid
fb90154589 Merge pull request #2897 from MikeMcQuaid/python@2
python_requirement: add libexec/bin to PATH.
2017-07-15 17:27:47 +01:00
Mike McQuaid
ce1b26d58d Merge pull request #2905 from GauthamGoli/audit_option_rubocop_3
audit: Port audit_options rules for new formulae to rubocop and add test
2017-07-15 13:40:45 +01:00
Mike McQuaid
f5cc8daa39 Merge pull request #2900 from MikeMcQuaid/improve-docs
Documentation improvements
2017-07-15 13:39:32 +01:00
Gautham Goli
a8f1b02be9 audit: Port audit_options rules for new formulae to rubocop and add test 2017-07-15 17:35:10 +05:30
Mike McQuaid
4fd8aea015 Documentation improvements
- Document ilovezfs as the official lead maintainer of
 Homebrew/homebrew-core. This is a role he's been doing unofficially
 (and brilliantly) for a while and explicit documentation of power
 structures makes it easier for non-Homebrew-maintainers to understand.
- Document the contents of some of Homebrew's subdirectories for people
  clicking around in the GitHub UI looking to contribute.
- Remove update bug mention from README. Enough time has passed that we
  can remove this disappointment.
2017-07-15 12:57:34 +01:00
Gautham Goli
f3923f23ef audit: Port audit_options strict rules to rubocop and add tests 2017-07-14 21:43:16 +05:30
Mike McQuaid
fb310c57b1 sandbox: sandbox all taps by default.
We've been doing this in `brew test-bot`, for our CI and for
homebrew/core long enough that this is a reasonable default that
provides more protection to our users of non-homebrew/core taps.
2017-07-14 17:00:07 +01:00
Mike McQuaid
f08b518481 python_requirement: add libexec/bin to PATH.
This avoids having to fix formulae that use `python` to make them use
`python2`.
2017-07-14 16:58:14 +01:00
Mike McQuaid
20db5470e3 Merge pull request #2879 from GauthamGoli/audit_option_rubocop_1
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-14 15:32:52 +01:00
Mike McQuaid
4ca2efb12d Merge pull request #2876 from VonUniGE/patch-1
Update documentation of brew install syntax to match its actual behav…
2017-07-13 21:22:55 +01:00
Mike McQuaid
7d443e6bfe Merge pull request #2894 from MikeMcQuaid/integration-test-debugging
integration_test: try tests on Gem load failure.
2017-07-13 21:07:36 +01:00
Mike McQuaid
f7c254dc33 Merge pull request #2893 from MikeMcQuaid/unpin-bundler
tests: unpin bundler.
2017-07-13 17:54:00 +01:00
Mike McQuaid
8b63214c2e integration_test: try tests on Gem load failure.
This should help with debugging `Gem::LoadError`s (e.g. for
https://github.com/Homebrew/homebrew-test-bot/pull/111).
2017-07-13 17:25:34 +01:00
Mike McQuaid
ec574c0e7f tests: unpin bundler.
These issues were fixed by https://github.com/Homebrew/brew/pull/2872
and https://github.com/Homebrew/brew/pull/2823.
2017-07-13 17:15:03 +01:00
Mike McQuaid
7c26dfee55 Merge pull request #2892 from MikeMcQuaid/homebrew-version-consistency
brew.sh: always use 7 chars for HOMEBREW_VERSION.
2017-07-13 10:41:03 +01:00