admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
2,595 Commits 15 Branches 471 Tags
Commit Graph

2595 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Max Howell
3dec84de8a Improve libiconv diagnostic and suggestion 
This is coming up a lot at the moment, so here is an attempt to be more helpful.
 2012-08-14 11:46:18 -04:00
Max Howell
fef6d5b8c0 brew doctor -D (diagnostic-dump) 
-D is now the switch for diagnostic-dumps. Let it be so.

Shows how long each doctor method takes in a sorted table at end. I used this to move the two slowest methods to the end of the doctor run so that as much useful information can be shown as quickly as possible.

Also now possible to specify on command line which tests should be run.
 2012-08-14 11:46:18 -04:00
Max Howell
9fffbde987 brew irb fix 
Broke when I removed `require 'formula'` from ARGV.rb.
 2012-08-14 09:14:26 -04:00
Misty De Meo
a3ca4f0872 options: Print "--" in option name for --compact 
This was a regression which caused the bash completion script to
fail to complete formula options.
 2012-08-13 12:45:53 -05:00
Max Howell
88e79a9098 Uninstall keg if error during build & tab creation 
Previously if error occurred in code around the logic you'd get a keg that is installed without a tab, which breaks brew.
 2012-08-13 10:14:59 -04:00
Max Howell
28ee57aa3c Don't fail if ENOENT 2012-08-13 10:14:59 -04:00
Max Howell
ad80c616b8 brew cleanup removes .DS_Store files 
Probably slow, but we hate these fuckers.
 2012-08-13 10:14:59 -04:00
Max Howell
b0e50ba13d Formula.select and Formula.installed 2012-08-13 10:14:59 -04:00
Max Howell
3d657746bb Encourage clicks on issues link 2012-08-13 10:14:59 -04:00
Jack Nagel
a054dc5019 Add :when_xquartz_installed as a keg-only reason 
Using :when_xquartz_installed will tell the keg-only machinery to activate
if XQuartz is installed.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-12 17:28:15 -05:00
Jack Nagel
f970f9ec60 Refactor brew audit 2012-08-12 13:58:14 -05:00
Jack Nagel
8952bcf315 Fix writing build options to install receipt 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-12 13:37:40 -05:00
Max Howell
33ec48a394 Don't require the WHOLE of Homebrew from ARGV.rb 
This was slowing down every instantiation of brew significantly.

Hopefully doesn't break anything that had become accustomed to not having to require 'formula' or 'keg'.

/cc @mikemcquaid
 2012-08-12 11:40:55 -04:00
Jack Nagel
8818e008e3 tests: require string extension before exceptions 
exceptions.rb now needs String#undent when it is loaded.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-12 01:02:37 -05:00
Jack Nagel
0549a9ab05 BuildOptions: store option tuples in a Set 
As options are stored in an object owned by the eigenclass of a formula,
options defined in the Formula#options method can be added multiple
times if the formula is instantiated multiple times.

Store them in a set to prevent duplicates.

Fixes Homebrew/homebrew#14133.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-12 00:58:48 -05:00
Jack Nagel
c9f824b54a Make Set available globally 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-12 00:58:31 -05:00
Misty De Meo
d1c0d4c879 Fix normalization of old- and new-style options 
When combining the set of old-style and new-style options, make sure
that the leading "--" is stripped.

Fixes displaying options in `brew options`, and the exotic case of
declaring options using the old syntax and then checking them with
`build.include?`
 2012-08-11 16:54:03 -05:00
Misty De Meo
5882ae901f options: Don't add "--" to options that have it 2012-08-11 14:13:40 -05:00
Mike McQuaid
5c79d5884a Don't warn uses on :fails_with compiler blocks. 
Fixes Homebrew/homebrew#14121.
 2012-08-11 17:19:43 +01:00
Jack Nagel
c5eb0b880a options: fix missing leading "--" in output 
Closes Homebrew/homebrew#14124.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-11 10:29:21 -05:00
Adam Vandenberg
bd1a7e2690 remove trailing whitespace 2012-08-10 07:23:48 -07:00
Max Howell
45b84df1bd Be more verbose when users insist on being sudoers 
If you google for "Cowardly refusing to sudo brew" you get a lot of confused users who didn't read any of the Homebrew documentation and then had a hissy-fit.
 2012-08-10 09:33:44 -04:00
Jack Nagel
f5eaef0aee Deprecate ancient formula syntax 
Closes Homebrew/homebrew#13444.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-09 23:56:54 -05:00
Adam Vandenberg
2104510b63 New style is for option descriptions to not end with periods 2012-08-09 21:35:56 -07:00
Adam Vandenberg
928734c0bd Document dependencies.rb 2012-08-09 20:32:57 -07:00
Misty De Meo
d58fc0c2e4 dev_tools_path: Don't trust exit status of xcrun 
A user on IRC was getting strange results from MacOS.dev_tools_path.
It turns out that xcrun's exit status is not always reliable - if
xcrun is a shim and not able to locate the real xcrun, it will exit
0 despite not actually doing what it was asked. Instead check to see
if the stout is empty.
 2012-08-09 16:33:49 -05:00
Misty De Meo
ab80dfc5b7 create: Fix indentation for :x11 dep 2012-08-09 16:33:49 -05:00
Adam Vandenberg
ac9bc89bb3 Remove options audit check 2012-08-09 12:52:05 -07:00
Adam Vandenberg
e196c845bf Fix info/options for new options dsl 2012-08-09 09:24:27 -07:00
hazz
60bdb16a7c Run each search_tap in a separate thread to speed things up. 
Closes Homebrew/homebrew#14066.

Signed-off-by: Max Howell <mxcl@me.com>
 2012-08-09 11:58:58 -04:00
Misty De Meo
f9751d63c4 fish completion: Remove dupe lines, fix commands 2012-08-09 10:57:27 -05:00
samueljohn
eb0be2ba47 download_strategy: Use MacOS.locate to find svn 
- So that Xcode-only systems don't fail to find svn.

Closes Homebrew/homebrew#14080.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
 2012-08-09 08:53:20 -07:00
Adam Vandenberg
dbe460ef04 options: remove duplicate function 2012-08-09 07:20:14 -07:00
Adam Vandenberg
d1d52b3467 Add option to the DSL 
Closes Homebrew/homebrew#9982
 2012-08-08 22:01:27 -07:00
Mike McQuaid
0df4c6a703 Add modular x11 dependencies. 
Fixes Homebrew/homebrew#13638.
 2012-08-08 18:19:21 +01:00
Mike McQuaid
f15bef5831 Remove libpng and freetype blacklist 2012-08-08 18:19:20 +01:00
Jack Nagel
c2725aa048 Simplify conditional 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-07 15:33:29 -05:00
Jack Nagel
1d295ff3bc Automatically append shell completion caveats 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-07 15:32:00 -05:00
Jack Nagel
4f809d0311 Simplify printing conflicts in brew info 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-07 14:24:54 -05:00
Jack Nagel
82d3890495 Fix typo in conflicts_with DSL method 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2012-08-07 14:24:34 -05:00
Adam Vandenberg
d5ba82ca7e fix info command 2012-08-07 12:23:25 -07:00
Max Howell
c84035a287 Fix Xcode.version 
I managed to remove a return while fixing this yesterday. The whitespace changes made the diff unreadable so I missed this regression.

Why does this sort of thing still happen?
 2012-08-07 14:34:27 -04:00
Max Howell
adccbf893e Document brew tap --repair 2012-08-07 14:24:09 -04:00
Max Howell
3b23cf102f brew tap by itself handles dashes in usernames 
This stuff sucks. I'd like to just replace the dash with a directory division or tilde character. But this makes the code even more complicated, unless we can figure out how to migrate the taps.
 2012-08-07 14:24:09 -04:00
Stafford Brunk
cbee0bd2ee Print an appropriate message if the tapped repository appears to be private 
Closes Homebrew/homebrew#12247.
Closes Homebrew/homebrew#12244.

Signed-off-by: Max Howell <mxcl@me.com>
 2012-08-07 14:24:09 -04:00
Adam Vandenberg
8c8701f268 Allow multiple unsatisfied fatal requirements 
Closes Homebrew/homebrew#13335.
 2012-08-07 10:49:45 -07:00
Brandon Black
bcde6432f3 Fix issues with writable? detection in brew doctor 
Closes Homebrew/homebrew#13689.

Signed-off-by: Max Howell <mxcl@me.com>

There are subtle distinctions between writable? and writable_real? we don't
understand precisely why we need this, but it fixes the bugs :/
 2012-08-06 22:02:38 -04:00
Max Howell
1f62284384 Restore check for broken xcode-select path 
How did this get removed? Had a bug today where user had this but no doctor check so I was confused!
 2012-08-06 19:28:39 -04:00
Max Howell
da692fadc6 Don't chmod -R 0777 before uninstalling 
If the user owns the parent directory we have the rights to rmtree. At least I believe so.

Fixes Homebrew/homebrew#13714.
 2012-08-06 18:49:14 -04:00
samueljohn
27fae8a829 brew --env: Added missing env vars 
Closes Homebrew/homebrew#13431.

Signed-off-by: Max Howell <mxcl@me.com>
 2012-08-06 18:22:45 -04:00