159 Commits

Author SHA1 Message Date
Zach Auten
fe643758d7 Updated get_info
- get_info builds info string by appending helper functions
  - removed unnecessary returns
  - fixed indentation in missing_formula
  - reduced size of regex in info_spec
  - missing_formula will indicate when it finds a cask with same name
2019-03-06 00:27:48 -05:00
Zach Auten
330ae8c6fa print_caveats and get_info return heredocs 2019-02-24 21:53:04 -05:00
Zach Auten
ed80b60834 Fixed installation info output and imports 2019-02-21 21:08:57 -05:00
Mike McQuaid
e095da4d01
rubocop: enable Layout/EmptyLineAfterGuardClause. 2019-02-21 12:55:49 +00:00
Zach Auten
554106d2e0 Updated missing formula cask reason
- search_for_cask in missing_formula renamed to is_a_cask_reason
    - is_a_cask calls new getInfo method in cask/cmd/info.rb to return info
      string
    - self.info in info.rb now calls getInfo and puts return value
    - added ohai_title to return the ohai printout for only titles, so that
      ohai printout could be added to the getInfo return string without
      calling puts.
    - refactored ohai to use ohai_title
    - updated info_spec.rb cask info test to be more specific when
      matching stderr.
    - is_a_cask_reason will respect 'silent'
    - refactored print_caveats to return instead of print
2019-02-18 03:33:57 -05:00
Markus Reiter
713453cc2f
Merge pull request #5745 from reitermarkus/cask-edit
Allow editing broken casks.
2019-02-16 10:20:56 +01:00
Markus Reiter
5536432c4f Allow editing broken casks. 2019-02-15 22:05:28 +01:00
Markus Reiter
cd03c0f86d Retry merging once after 5 seconds. 2019-02-15 19:48:12 +01:00
Markus Reiter
68e0c5f904 Check for write access instead of HOMEBREW_DEVELOPER. 2019-02-15 16:27:37 +01:00
Markus Reiter
57fefff942 Add brew cask automerge command. 2019-02-15 16:27:37 +01:00
Markus Reiter
190ff7558a Use saved cask config for reinstall/upgrade/uninstall. 2019-02-15 10:09:14 +01:00
Mike McQuaid
efc3c0c4c0
Use bundle install in more places.
This provides a more consistent version for `rubocop` than relying on
`Homebrew.install_gem_setup_path!` (and we really want `brew style` to
provide consistent output).
2019-01-08 15:08:21 +00:00
Markus Reiter
04908dcb19 Fix RuboCop for Casks. 2018-11-12 05:01:33 +01:00
Mike McQuaid
109e974c38
Cleanup rubocop-cask references. 2018-11-08 15:54:47 +00:00
Mike McQuaid
737b84b54b
brew style --fix fixes. 2018-11-02 17:29:23 +00:00
EricFromCanada
20167e5f1b Adjust comments to tidy API docs output. 2018-10-18 21:42:43 -04:00
Markus Reiter
a838b372de Fix brew cask style with relative paths. 2018-10-17 13:51:51 +02:00
Markus Reiter
8aab6dc03d Run rubocop in temporary directory to skip reading parent config. 2018-10-16 14:55:00 +02:00
Markus Reiter
711bb4977f
Merge pull request #5056 from reitermarkus/accessibility_access
Remove the `accessibility_access` stanza.
2018-10-08 18:24:18 +02:00
Markus Reiter
16618d0fc7 Use ActiveSupport’s #pluralize and #to_sentence. 2018-10-07 23:10:56 +02:00
Markus Reiter
59e3a532ff Remove the accessibility_access stanza. 2018-10-07 21:53:31 +02:00
L. E. Segovia
6d7e49b02b
Cask: check if xattr works before quarantining
Fixes Homebrew/homebrew-cask#52128.
2018-09-26 20:55:54 +00:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Markus Reiter
dfb6ada805
Merge pull request #4902 from MikeMcQuaid/active-support-blank
Use ActiveSupport Object#blank? and #present?
2018-09-16 20:02:00 +02:00
Mike McQuaid
955214abc0
Use ActiveSupport Object#blank? and #present? 2018-09-14 17:02:19 +01:00
L. E. Segovia
123dda09f0
Cask: constrain quarantine support status
Quarantine is available ONLY if the script exits with '2'.
It is definitely NOT available if Swift doesn't exist or if
it exits with '5' (incompatible SDK). All other cases are
from now on treated as unsupported.

Also print to standard error only when explictly required (via an
exception).
2018-09-14 15:48:16 +00:00
Eric Mark Martin
c62d2e6918 Cask: rename block argument f -> cask 2018-09-09 13:37:42 -04:00
Eric Mark Martin
28061369dc Cask: show previous verison in cask upgrade 2018-09-09 00:47:31 -04:00
Mike McQuaid
132aa14320
Merge pull request #4838 from reitermarkus/cask-module
Rename `Hbc` module to `Cask`.
2018-09-06 09:15:44 +01:00
Mike McQuaid
0770e0bb67
Merge pull request #4814 from zdcthomas/upgrade_greedy_verbose_response
removes auto updates warning if greedy flag is included
2018-09-06 09:07:59 +01:00
Mike McQuaid
11ac4db05e
Merge pull request #4796 from amyspark/quarantine-swift-clt
Cask: check that the tools for quarantining are available
2018-09-06 08:56:04 +01:00
Markus Reiter
a84a1c63db Rename Hbc module to Cask. 2018-09-06 09:30:52 +02:00
Markus Reiter
ac2cd67861 Deprecate brew cask --version. 2018-09-06 07:05:22 +02:00
zdcthomas
5cca3315cf fixes trailing whitespace 2018-09-05 09:19:39 -06:00
zdcthomas
f71f74da4a removes auto updates warning if greedy flag is included 2018-09-05 09:19:39 -06:00
L. E. Segovia
ed6f2829b1
Cask: check support of quarantine's tools
- In some cases (usually old CLT versions) Swift is available but needs an
extra guard to use the quarantine API.
- xattr's native filesystem recursion is an Apple extension which is
not available in Mojave; so let's use xargs.
- Insert a quarantine support check in brew cask doctor.

Fixes Homebrew/homebrew-cask#51554, and fixes Homebrew/homebrew-cask#51538.
2018-09-04 21:11:29 +00:00
Mike McQuaid
1ae2326984
Rename Cask::CLI to Cask::Cmd. 2018-09-04 09:56:58 +01:00
Mike McQuaid
1d86d7a7c7
cask: move cask/cli to cask/cmd. 2018-09-04 09:56:57 +01:00
Markus Reiter
3e7f94d5b5 Move cask to cmd/. 2017-03-06 11:41:29 +01:00
Markus Reiter
4944d43d58 Move coverage reporting into brew tests. 2017-03-05 23:08:14 +01:00
Markus Reiter
9fc6c7b2be Move Cask specs into brew tests. 2017-03-05 23:08:14 +01:00
Markus Reiter
31b9dc28e3 Remove cask test directory. 2017-02-10 17:19:19 +01:00
Mike McQuaid
f7b1991626 Use dedicated upload_coverage script. 2017-01-29 17:23:05 +00:00
Markus Reiter
39ce9c890e Try uploading coverage report in .simplecov. 2017-01-26 23:11:37 +01:00
Markus Reiter
dd0bc83eca Move require "bundler/setup“ to top of cask-tests. 2017-01-26 18:28:08 +01:00
Markus Reiter
e65150412c Add require "bundler/setup“ to cask-tests. 2017-01-26 16:57:30 +01:00
Mike McQuaid
92b48ac42e brew-cask-tests: import Rakefile logic.
This avoids a `rake` dependency in the Gemfile and an unnecessary shell
out.
2017-01-26 12:01:54 +00:00
Mike McQuaid
dc81898331 travis: use Xcode 8.1 on Sierra.
For code coverage from `brew test-bot`.
2016-12-04 14:14:11 +00:00
Kaito Udagawa
1a4eb14b16 cask-tests: fix cask-tests always fail on the test failure
`brew cask-tests` collected the test results in an improper way so that it reports a false success in certain situations.
Specially, the session under BrewTestBot always reports success regardless of the test status.
With this update, the exit code of `brew cask-tests` is 1 when the test fails, and then CI preperly works.
2016-11-12 11:48:12 +09:00
Markus Reiter
f863d61374 Move vendor/bundle up one level to HOMEBREW_LIBRARY_PATH. 2016-10-29 18:28:07 +02:00