Deprecate brew cask --version.

This commit is contained in:
Markus Reiter 2018-09-06 06:07:43 +02:00
parent f2012f5fda
commit ac2cd67861
9 changed files with 17 additions and 31 deletions

View File

@ -18,4 +18,3 @@ require "cask/staged"
require "cask/topological_hash"
require "cask/utils"
require "cask/verify"
require "cask/version"

View File

@ -23,7 +23,6 @@ require "cask/cmd/reinstall"
require "cask/cmd/style"
require "cask/cmd/uninstall"
require "cask/cmd/upgrade"
require "cask/cmd/--version"
require "cask/cmd/zap"
require "cask/cmd/abstract_internal_command"

View File

@ -33,7 +33,7 @@ module Hbc
end
def check_software_versions
ohai "Homebrew Cask Version", Hbc.full_version
ohai "Homebrew Version", HOMEBREW_VERSION
ohai "macOS", MacOS.full_version
ohai "SIP", self.class.check_sip
ohai "Java", SystemConfig.describe_java

View File

@ -1,10 +0,0 @@
module Hbc
def self.full_version
@full_version ||= begin
<<~EOS
Homebrew Cask #{HOMEBREW_VERSION}
#{Tap.default_cask_tap.full_name} #{Tap.default_cask_tap.version_string}
EOS
end
end
end

View File

@ -8,6 +8,7 @@ module Homebrew
odie "This command does not take arguments." if ARGV.any?
puts "Homebrew #{HOMEBREW_VERSION}"
puts "Homebrew/homebrew-core #{CoreTap.instance.version_string}"
puts "#{CoreTap.instance.full_name} #{CoreTap.instance.version_string}"
puts "#{Tap.default_cask_tap.full_name} #{Tap.default_cask_tap.version_string}" if Tap.default_cask_tap.installed?
end
end

View File

@ -1,4 +1,5 @@
require "compat/cask/cask_loader"
require "compat/cask/cmd/--version"
require "compat/cask/cmd/cleanup"
require "compat/cask/cmd/search"
require "compat/cask/cache"

View File

@ -1,3 +1,6 @@
require "cask/cmd/abstract_command"
require "cmd/--version"
module Hbc
class Cmd
class Version < AbstractCommand
@ -12,12 +15,18 @@ module Hbc
end
def run
puts Hbc.full_version
odeprecated "`brew cask --version`", "`brew --version`", disable_on: Time.new(2018, 10, 31)
ARGV.clear
Homebrew.__version
end
def self.help
"displays the Homebrew Cask version"
end
def self.visible
false
end
end
end
end

View File

@ -1,13 +0,0 @@
describe Hbc::Cmd::Version, :cask do
describe "::run" do
it "outputs the current Homebrew Cask version" do
expect { described_class.run }
.to output(/\AHomebrew Cask.*\d+\.\d+\.\d+/).to_stdout
.and not_to_output.to_stderr
end
it "does not support arguments" do
expect { described_class.run(:foo, :bar) }.to raise_error(ArgumentError)
end
end
end

View File

@ -5,13 +5,13 @@ describe Hbc::Cmd::Doctor, :cask do
it "displays some nice info about the environment" do
expect {
Hbc::Cmd::Doctor.run
}.to output(/\A==> Homebrew Cask Version/).to_stdout
described_class.run
}.to output(/^==> Homebrew Version/).to_stdout
end
it "raises an exception when arguments are given" do
expect {
Hbc::Cmd::Doctor.run("argument")
described_class.run("argument")
}.to raise_error(ArgumentError)
end
end