Gautham Goli
c7bf79407a
Better man page formatting
2018-10-03 19:20:26 +05:30
Gautham Goli
b6c456b681
Extract out arg parsing method to <cmd>_args method
2018-10-03 19:19:04 +05:30
Gautham Goli
32e5a5686b
audit: Use OptionParser to generate help text
2018-10-03 19:18:56 +05:30
Markus Reiter
e9b9ea49a1
Update to RuboCop 0.59.1.
2018-09-17 03:45:59 +02:00
Mike McQuaid
955214abc0
Use ActiveSupport Object#blank? and #present?
2018-09-14 17:02:19 +01:00
Mike McQuaid
80d75bc0d8
Homebrew/.rubocop: tweak rules.
...
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
2018-09-02 20:15:09 +01:00
Mike McQuaid
bcb1ec5499
Improve Homebrew/brew line length.
...
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
2018-09-02 16:15:09 +01:00
Gautham Goli
32bc5535b6
style: Fix npe and add test for corrected offense results
2018-08-28 23:31:35 +05:30
Gautham Goli
5d2ca08a93
audit: Use fetch with default value prevent NPE
2018-08-28 13:16:44 +05:30
Gautham Goli
23846d6ca8
audit: Add null check on style results
2018-08-27 19:50:11 +05:30
Gautham Goli
3705956f53
Merge pull request #4753 from GauthamGoli/autocorrect-count
...
audit: Show RuboCop offense correction status and count in output
2018-08-26 23:55:17 +05:30
Gautham Goli
b82dbdcfa8
audit: Show RuboCop offense correction status in output when --fix is passed
2018-08-26 19:33:19 +05:30
commitay
e0c3ea7474
audit: remove "bottle is not defined"
2018-08-23 11:06:35 +10:00
Jonathan Chang
2487345460
audit: fixes for test checks
2018-08-16 12:43:13 -04:00
Dominyk Tiller
20311aec15
audit: flag redundant shell_output() exit codes
2018-08-11 01:53:00 +01:00
Markus Reiter
29182ad068
Remove non-existent download strategies.
2018-08-01 01:59:54 +02:00
commitay
fabb0931e3
audit: change the "unstable" spec message to devel/head
2018-07-29 09:32:46 +10:00
Mike McQuaid
0fe1f01e41
audit: output new formula issue comment failure message.
...
This should help debug when this fails to be created.
2018-07-23 19:33:59 +01:00
Mike McQuaid
5c6ef3d920
Disable more deprecations.
...
- Turn more old `odeprecated` into `odisabled`
- Remove more old `odisabled`
- Remove code for older Ruby versions
2018-07-14 16:00:50 +01:00
commitay
1f115fa2f5
Merge pull request #4456 from commitay/optional-reqs
...
audit: check for optional and recommended requirements on new formulae
2018-07-13 10:04:15 +10:00
commitay
ab8054482b
audit: check for optional and recommended requirements on new formulae
2018-07-12 10:14:07 +10:00
commitay
2c5f56d77d
audit: ensure bottle is defined
2018-07-08 09:22:58 +10:00
commitay
a185f3272e
audit: disallow unstable specs for versioned formulae
2018-07-04 11:39:11 +10:00
ilovezfs
4b97b618df
audit: exact match throttled formula names
2018-07-03 01:14:12 -07:00
commitay
6ca66d18e0
audit: exempt versioned formulae from new formula audit
2018-07-02 23:40:24 +10:00
Andrew Janke
e0a8a79921
Style fixes for Rubocop 0.57.1
2018-06-30 19:40:14 -04:00
Andrew Janke
97c12b4bbf
brew audit: avoid error on head-only formulae
2018-06-15 20:07:02 -04:00
commitay
abdf6cae2f
audit: fix typo
2018-06-08 16:53:49 +10:00
commitay
0e763fbb5e
Merge pull request #4303 from commitay/throttled
...
audit: throttled formulae
2018-06-07 23:05:02 +10:00
Andrew Janke
8b55cb5ecb
Refactor commands to remove "require cmd/help"
2018-06-07 04:59:59 -04:00
commitay
0fe8c02b3c
audit: throttled formulae
2018-06-07 16:34:44 +10:00
Gautham Goli
f5e5a81a7f
Merge pull request #4146 from GauthamGoli/global-args
...
cli: Store parsed args in Homebrew.args and access @args everywhere else
2018-06-01 20:01:26 +05:30
Mike McQuaid
fb0f979279
Merge pull request #4204 from commitay/github-notabilty
...
audit: github notability
2018-06-01 08:39:26 +01:00
commitay
54b4f0c743
audit: github notability
2018-06-01 08:30:03 +10:00
Gautham Goli
fba52e2f74
cli_parser: Store parsed args in Homebrew.args and access args everywhere else
2018-05-30 00:05:39 +05:30
Tom Schoonjans
ecbd9b9a26
Add gtk-mac-integration to gnome_devel_whitelist
2018-05-29 10:38:38 +01:00
commitay
dc96e6f735
Merge pull request #4170 from commitay/new-formulae-options
...
audit: new formulae should not have options
2018-05-24 07:16:11 +10:00
commitay
c297d39420
audit: add back new formulae condition for patches
2018-05-23 07:36:59 +10:00
Mike McQuaid
c7aa286336
audit: tweak line length/style.
2018-05-22 14:52:02 +01:00
Gautham Goli
38c832b029
audit: exit with code 1 if regular audit errors or new formula audit errors when comment is not created
2018-05-22 19:14:18 +05:30
Gautham Goli
b01446d059
audit: Add condition check on new_formula_audits
2018-05-22 17:55:40 +05:30
commitay
9d55fed15f
audit: new formulae should not have options
2018-05-22 19:39:14 +10:00
Mike McQuaid
8401cffe41
audit: remove "new formula" from messaging.
2018-05-22 09:55:41 +01:00
Mike McQuaid
1c91c83eac
Merge branch 'master' into bot-comment
2018-05-21 17:16:19 +01:00
Mike McQuaid
e2968c7889
Various cleanup and fixes.
...
Rename some variables and use existing regexes and a single variable.
2018-05-21 15:36:26 +01:00
Mike McQuaid
840c97c1cc
formula: add versioned formulae method.
2018-05-12 15:02:29 -04:00
Gautham Goli
26e77dd75c
new-formula: Don't fail CI instead comment on PR about audit violations
2018-04-30 10:59:20 +05:30
Markus Reiter
33a9521576
Fix MissingFormula namespacing.
2018-04-22 17:27:44 +02:00
Markus Reiter
16fb563d49
Refactor MissingFormula spec.
2018-04-20 19:11:22 +02:00
commitay
909312f9a4
audit: new formulae should not have a HEAD spec
2018-04-14 19:24:07 +10:00
