audit: flag redundant shell_output() exit codes

2018-08-11 01:49:35 +01:00 · 2018-08-11 01:49:35 +01:00 · 20311aec15
commit 20311aec15
parent 8f3a80b562
1 changed files with 4 additions and 0 deletions
--- a/Library/Homebrew/dev-cmd/audit.rb
+++ b/Library/Homebrew/dev-cmd/audit.rb
@ -803,6 +803,10 @@ module Homebrew

      problem "Use separate make calls" if line.include?("make && make")

+      if line =~ /shell_output\(['"].+['"], 0\)/
+        problem "Passing 0 to shell_output() is redundant"
+      end
+
      if line =~ /JAVA_HOME/i && !formula.requirements.map(&:class).include?(JavaRequirement)
        problem "Use `depends_on :java` to set JAVA_HOME"
      end