3156 Commits

Author SHA1 Message Date
Mike McQuaid
0c1b556196
uses_from_macos: remove before/after.
We're not actually using this anywhere and it makes the code
more complicated.

Relatedly, this PR fixes the issue where
`uses_from_macos "python@2" => :build` was valid on macOS but not
on Linux.
2019-12-19 14:36:33 +00:00
Mike McQuaid
76711e3222
Fix Rubocop 0.78.0 failures. 2019-12-19 12:01:51 +00:00
Gautham Goli
22e25dd593 argv: move formulae to cli/args 2019-12-11 16:36:23 +05:30
Vítor Galvão
497a160cda cask version MAJOR_MINOR_PATCH_REGEX: allow any word character instead of only digits 2019-12-07 14:04:55 +00:00
Mike McQuaid
bed5297b6c
.github/workflows/tests: run config, doctor.
This should help with debugging why the `brew bundle` tests are now
failing.
2019-12-04 15:35:31 +00:00
Figroc Chen
3c09ab0d06 extract: semver aware 2019-12-03 21:45:55 +08:00
Mike McQuaid
5dd8ead51a
Rename Formula#installed? to Formula#latest_version_installed?
This naming has always been a bit weird and confusing so let's change
it and provide a `compat` fallback for later deprecation.
2019-12-03 11:42:42 +00:00
Mike McQuaid
c1b00297e0
cask/cmd/style_spec: add rubocop test.
This verifies the cask configuration hasn't been broken.
2019-12-01 15:04:32 +00:00
Mike McQuaid
3a9f585ebb
Move more code to utils/analytics. 2019-11-22 09:10:29 +00:00
Mike McQuaid
bf74cd994b
Merge pull request #6760 from MikeMcQuaid/test_bot_logic_to_actions
Move some brew-test-bot logic to GitHub Actions.
2019-11-21 22:00:32 +00:00
Mike McQuaid
04835db85e
Move some brew-test-bot logic to GitHub Actions.
This will improve the output and ease of parsing while allowing code to
be removed from brew-test-bot which relates only to a single repo (this
one).
2019-11-21 19:50:23 +00:00
Alexander Bayandin
b7b5a60f86 utils/inreplace: do not allow to use empty list of files 2019-11-21 16:49:06 +00:00
Mike McQuaid
5904aab98a
Merge pull request #6622 from zachauten/argv_kegs
Moved kegs from ARGV to args.rb
2019-11-13 00:22:09 +00:00
Zach Auten
fd429d0d75 Moved kegs from ARGV to args.rb 2019-11-09 11:56:47 -05:00
Mike McQuaid
eb0be5f6fe
test: re-enable portable Ruby tests.
Let's try to get these working again.
2019-11-06 15:36:28 +00:00
Mike McQuaid
6a33959888
test/subversion: fix subversion paths/detection. 2019-11-06 14:58:33 +00:00
Mike McQuaid
924af100b7
cask/pkg_spec: remove flaky test. 2019-11-06 14:28:05 +00:00
Mike McQuaid
ee1cbfc8d3
formula: refactor outdated_kegs logic.
- Use the `Formula.cache` and `Cacheable` rather than rolling our own.
- Use keyword arguments instead of `options = {}`
- Improve readability in general
2019-11-06 11:49:31 +00:00
Mike McQuaid
918224ce1a
Merge pull request #6696 from Homebrew/dependabot/bundler/Library/Homebrew/activesupport-6.0.1
build: bump activesupport from 5.2.3 to 6.0.1 in /Library/Homebrew
2019-11-06 11:06:58 +00:00
Mike McQuaid
6670ae6202
global: require rubygems for activesupport. 2019-11-06 10:36:40 +00:00
Mike McQuaid
22795d7e30
spec_helper: do cache clearing in single location. 2019-11-06 10:20:57 +00:00
Mike McQuaid
ddcbdbe0c0
formula: cache runtime_dependencies related stuff. 2019-11-06 10:04:13 +00:00
Mike McQuaid
eeb9ac36a2
keg: cache runtime_dependencies. 2019-11-06 10:04:13 +00:00
Markus Reiter
78725740e2 Refactor cask dependency resolution. 2019-10-31 20:20:55 +01:00
Markus Reiter
df3bbd0299 Reduce need for interpolating appdir in casks. 2019-10-24 17:07:30 +02:00
Markus Reiter
e6cfb4a3c2
Merge pull request #6629 from timsly/manpage-artifact
Add Manpage artifact
2019-10-24 13:48:52 +02:00
Tim Masliuchenko
91ddb6e53d Cleanup specs 2019-10-24 14:22:13 +03:00
Tim Masliuchenko
87f29857f0 Pass section to the constructor 2019-10-23 18:34:16 +03:00
Tim Masliuchenko
22d821323c Feedbacks 2019-10-23 16:28:00 +03:00
Markus Reiter
04493e2dde Fix trash.swift without arguments. 2019-10-23 06:59:39 +02:00
Markus Reiter
299bb1c25f
Merge pull request #6628 from reitermarkus/automation-access
Remove `User::automation_access?`.
2019-10-22 20:52:37 +02:00
Tim Masliuchenko
3ef5e06943 Add Manpage artifact 2019-10-22 15:21:49 +03:00
Mike McQuaid
cddf402365
Merge pull request #6620 from scpeters/must_exist_frameworks
os/mac/keg: Frameworks -> MUST_EXIST_DIRECTORIES
2019-10-22 09:15:51 +01:00
Markus Reiter
7a5e4d1269 Remove User::automation_access?. 2019-10-22 07:38:35 +02:00
Steven Peters
1ad0addbc8 spec_helper: always remove Frameworks 2019-10-21 12:27:39 -07:00
Steven Peters
875bfbc8d3 spec_helper: workaround for removing Frameworks 2019-10-20 22:47:46 -07:00
Cheng XU
163ef284d2
brew test: more fixes for ARM
On ARMv7, the arch name is armv7l instead of armv7. So update the bottle
file name accordingly.
2019-10-19 15:20:35 +08:00
Cheng XU
c98b77fd3e
cpu_spec: fix for ARM 2019-10-18 15:33:28 +08:00
Cheng XU
f0e848b3e0
fixtures: add testball bottle for ARM
Also fix the absolute link used by testball_bottle-0.1.intel_macintosh.bottle.tar.gz
2019-10-18 15:30:24 +08:00
Mike McQuaid
8a93230c15
test/cask: remove disabled functionality tests. 2019-10-15 09:52:33 +01:00
Mike McQuaid
02ded996a4
formulary_spec: remove deprecated tap-pin usage. 2019-10-15 09:13:11 +01:00
Mike McQuaid
1b4fdc17f4
Raise deprecation exceptions in tests
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).

Instead, ensure that tests always raise deprecations as exceptions so
that new deprecations will have their tests handled immediately.
2019-10-15 08:52:42 +01:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Issy Long
fed1bbe029
Disable Metrics/LineLength for long URL lines in patches_spec.rb
- The final two `brew style` offenses were for Metrics/LineLength where
  parsing the GitHub diff URL as a regex took 119/118 lines.
- This disables the cop for each of those long, problematic lines, and
  re-enables them straight afterwards, else they'd apply to the whole file
  from the first occurrence onwards, which we probably don't want?
- I wondered about increasing the LineLength limit to 119 or 120, but
  it appears to have been set for a justifiable reason in 80d75bc0d8.
2019-10-13 16:04:37 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses 2019-10-13 16:04:26 +01:00
Mike McQuaid
0d068341fc
Merge pull request #6467 from EricFromCanada/uses_from_macos-json
Expose `uses_from_macos` list in formula API
2019-10-11 09:28:01 +01:00
Jacob Middag
c6cb20a768
Fix frozen string bug 2019-10-11 09:34:43 +02:00
Mike McQuaid
a1a0569f75
Merge pull request #6578 from dawidd6/audit-uses-from-macos
audit: replace depends_on with uses_from_macos
2019-10-10 19:20:17 +01:00
Dawid Dziurla
86feb5a9de
audit: replace depends_on with uses_from_macos 2019-10-10 17:59:32 +02:00