3156 Commits

Author SHA1 Message Date
Alexander Bayandin
bfcba0f5f0 Library/Homebrew: add free_port test helper
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-03-31 00:00:11 +01:00
Mike McQuaid
bd076049a0
integration_test: only run on system Ruby.
There appear to be random, seemingly impossible to debug issues with
running integration tests on portable Ruby. Instead of confusing
contributors when these will be run on CI anyway: let's just skip them
by default (like we do with `--online` for online tests anyway).
2020-03-30 20:25:42 +01:00
Jonathan Chang
0d3a4d98c0 utils/github: add test for fetch_artifact 2020-03-30 22:41:17 +11:00
Jonathan Chang
bab564f203 pr-pull: add tests 2020-03-30 22:41:17 +11:00
Jonathan Chang
282bfbf70a bintray: add tests 2020-03-30 22:41:17 +11:00
Vítor Galvão
2e8aa3eb97 Use long --disable instead of short -q in curl 2020-03-29 20:04:37 +01:00
Bo Anderson
c241dccbc8 test/resource_spec: fix flaky test 2020-03-28 00:10:42 +00:00
Bo Anderson
3955e7e13b language/test: add shebang tests 2020-03-27 19:18:25 +00:00
Mike McQuaid
fa8fe0fc39
Merge pull request #7200 from dawidd6/create-ruby
create: add --ruby option
2020-03-24 13:50:35 +00:00
Dawid Dziurla
626f9406b1
remove flaky cask upgrade test 2020-03-23 19:27:48 +01:00
Jonathan Chang
86f245effb dev-cmd: new pr-publish command 2020-03-22 13:35:15 +11:00
Markus Reiter
50b61fa7f2 Retry curl requests 3 times by default. 2020-03-20 18:40:43 +01:00
Alexander Bayandin
b37c3e9cb2 rubocops/patches: suggest url with full_index=1 2020-03-15 11:24:38 +00:00
Mike McQuaid
1e265247ca
rubocop: apply autofixes. 2020-03-13 21:16:18 +00:00
Jonathan Chang
57109a175a diagnostic: add doctor check for CPU arch on Linux
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-03-13 11:39:27 +11:00
Chris Tompkinson
af3010758a appease rubocop 2020-03-10 10:51:20 +00:00
Chris Tompkinson
160b2c40d0 Add covering test for headers 2020-03-10 10:47:18 +00:00
Mike McQuaid
78140cef4a
Merge pull request #7073 from alexreg/issue-7068
audit: ignore group write bit
2020-03-06 14:08:45 +00:00
Alexander Regueiro
68047abc0e audit: ignore group write bit 2020-03-05 23:01:41 +00:00
Mike McQuaid
67d7697165
Merge pull request #7120 from MikeMcQuaid/args-tweaks
cli/parser: add and use more helpers.
2020-03-05 12:21:24 +00:00
Mike McQuaid
42477a1aaa
Merge pull request #7125 from Bo98/make-regex
extend/string: match multiline make variables
2020-03-05 09:29:52 +00:00
Mike McQuaid
677e6c972a
Merge pull request #7123 from dawidd6/resource-build-and-test
dependency_collector: make resource dep available at test-time too
2020-03-05 09:29:17 +00:00
Mike McQuaid
495daf0aee
extend/ARGV: remove/private unused methods. 2020-03-05 09:25:14 +00:00
Mike McQuaid
66155ea370
cli/parser: add named/min_named helpers. 2020-03-05 09:25:14 +00:00
Bo Anderson
d0896d641a extend/string: match multiline make variables 2020-03-05 04:11:35 +00:00
Dawid Dziurla
59ce122e90
dependency_collector: make resource dep available at test-time too
There are formulae that use resource blocks for stuff that is needed in
test blocks. If a resource is a `.zip` archive, one needs `unzip`
utility in `PATH` to extract it, but its only available at build-time,
so one observes an error like that for example:

```
==> brew test psftools --verbose
Testing psftools
==> Downloading https://www.zone38.net/font/pc8x8.zip
Already downloaded: /github/home/.cache/Homebrew/downloads/ea5f6a485687368ff5bc99e4cc43a49b06e081baa51a97ee6ddcd8d1b82d7963--pc8x8.zip
==> Verifying ea5f6a485687368ff5bc99e4cc43a49b06e081baa51a97ee6ddcd8d1b82d7963--pc8x8.zip checksum
unzip -o /github/home/.cache/Homebrew/downloads/ea5f6a485687368ff5bc99e4cc43a49b06e081baa51a97ee6ddcd8d1b82d7963--pc8x8.zip -d /tmp/d20200304-21389-ui0wr0
Error: psftools: failed
undefined method `shelljoin' for nil:NilClass
```

Of course this issue affects Linux the most, because of higher
probability that the system lacks `unzip` for example.

With this commit, all resource guessed dependencies should be available
at build and test time.
2020-03-04 22:49:54 +01:00
David Frascone
8ed8d6979c Fix for when version is nil
When version is nil, (version <==> other.version) also returns nil
and then the nill object doesn't have a nonzero? method.

I'm not sure what package put me into this state, but, this fix repaired
my environment.

Also, there is probably a more ruby-esque way to do this, but, I'm not a
ruby expert ;-)
2020-03-03 12:27:21 -07:00
EricFromCanada
b681d64e59 version: handle -stable in tag 2020-02-28 14:57:28 -05:00
Seeker
11ebc27e0a version: parse tag if detecting version 2020-02-27 10:27:02 -08:00
EricFromCanada
29006396dd audit: check apache.org URLs 2020-02-24 13:07:46 -05:00
Mike McQuaid
dfa22680df
Autofix rubocop checks. 2020-02-19 11:24:12 +00:00
ImgBotApp
06841497bb [ImgBot] Optimize images
/Library/Homebrew/test/support/fixtures/test.svg -- 0.26kb -> 0.25kb (1.52%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-02-16 14:17:57 -08:00
Issy Long
2a36f61c19
missing_formula: TexLive is only blacklisted on macOS
- In Homebrew/linuxbrew-core, [we have a Linux-only formula for
  `texlive`](https://github.com/Homebrew/linuxbrew-core/tree/master/Formula/texlive.rb).
- When running `brew audit --strict texlive` on Linux, we got the
  following messaging:

  ```
  $ brew audit --strict texlive
  texlive:
    * 'texlive' is blacklisted from homebrew/core.
    Error: 1 problem in 1 formula detected
  ```

- Looking at where this comes from leads to the missing formula
  messaging to install `mactex` via Homebrew Cask. The 'blacklisted in
  homebrew/core' messaging only applies to macOS where Casks are an option
  for users, so let's not surface the audit for `texlive` on Linux.
2020-02-15 19:51:48 +00:00
Issy Long
b3abf3d7c9
dev-cmd/tap-new: Set up GitHub Actions CI instead of Azure
- We recently removed Azure as a supported CI provider
  (Homebrew/homebrew-test-bot PR 325), so `brew test-bot` won't run on
  Azure any more.
- Homebrew CI is moving towards GitHub Actions as the standard.
2020-02-15 17:39:33 +00:00
Markus Reiter
cb4316df97
Merge pull request #6922 from danielbayley/rmdir
Make rmdir: recursive
2020-02-15 09:58:26 +01:00
Daniel Bayley
f3a0fcfb6d Make rmdir: recursive 2020-02-11 07:56:15 +00:00
Mike McQuaid
a915114ea7
tap: fix arguments.
- Use Ruby attribute arguments.
- Fix use of `full_clone` in `cmd/tap` to be on by default.
- Remove unnecessary argument in test.
2020-02-05 20:22:21 +00:00
Mike McQuaid
9eedb1e2ca
system_command_result_spec: fix frozen objects. 2020-02-05 19:28:25 +00:00
Mike McQuaid
4493f27db2
Merge pull request #6989 from Homebrew/revert-6988-revert-6965-external-help-cli-parser
help: print cli/parser help message if used
2020-02-02 17:51:02 +01:00
Mike McQuaid
8a9dcad2c7
Move more command handling logic to commands.rb. 2020-02-02 17:05:45 +01:00
Mike McQuaid
243e703700
tap: default to full clones.
This makes `Tap` consistent with what the installer is doing.

Generally shallow clones get slower and slower (and more and more
pointless) the more they are fetched so don't make sense for our
use-case.

Keep the option around anyway because it's useful for integration tests.
2020-02-02 16:36:37 +01:00
Gautham Goli
acde828a45 ARGV: Replace ARGV.verbose? with Homebrew.args.verbose? 2020-02-02 14:00:04 +01:00
Mike McQuaid
6bc72cf18a
rubocop/lines: add whitelist.
Let's only allow cryto or libraries.
2020-01-29 12:17:21 +00:00
Xiao Di Guan
a9b22165fd
doctor: remove DYLD checks 2020-01-26 14:38:32 +11:00
Jonathan Chang
abf2b83b35 audit: add uses_from_macos dependency ordering 2020-01-12 11:12:27 -08:00
Jonathan Chang
cf66c05d87 audit: avoid build-time checks in core
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-11 09:48:54 -08:00
Jonathan Chang
9634041f82 audit: unnecessary comments from external taps
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-11 09:44:20 -08:00
Jonathan Chang
7239b3099a audit: check for build.with? in core
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-11 09:37:10 -08:00
Jonathan Chang
779304df68 audit: add "homebrew/core" for relevant checks 2020-01-08 15:38:48 -05:00
Mike McQuaid
d50a8c4e41
ARGV: delete/make private some more methods. 2020-01-02 14:07:07 +00:00