3156 Commits

Author SHA1 Message Date
Markus Reiter
9b4e32322a xar is only pre-installed on macOS. 2018-07-12 10:39:28 +02:00
Markus Reiter
633c590aac Refactor unpack strategy specs. 2018-07-12 10:39:27 +02:00
Markus Reiter
5b3bbb76c9 Separate staging from download. 2018-07-12 10:39:27 +02:00
Mike McQuaid
459e2bfa48
Merge pull request #4455 from reitermarkus/heredocs
Use more descriptive heredoc names.
2018-07-12 09:30:35 +01:00
Markus Reiter
7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
Markus Reiter
20ec595cb2 Fix Installer not supporting plain executables. 2018-07-11 16:56:37 +02:00
Markus Reiter
05cb6cda08 Add Installer spec. 2018-07-11 16:46:33 +02:00
Markus Reiter
37f3a603ce Use env utility instead of with_env. 2018-07-11 16:46:33 +02:00
Markus Reiter
1f5311888e Add failing spec for SystemCommand. 2018-07-11 15:58:38 +02:00
Markus Reiter
98bb073b46
Merge pull request #4265 from claui/fix-pkg-environment
Fix PKG installer environment
2018-07-11 08:25:19 +02:00
ilovezfs
24d7f41258
Merge pull request #4446 from MikeMcQuaid/tab-handle-json-parser-error
tab: if parsing JSON fails output the filename.
2018-07-10 10:08:29 +01:00
ilovezfs
3d3c462bff
tab_spec: fix typo 2018-07-10 08:55:50 +00:00
Mike McQuaid
7cc970fea2 link: refactor, reorder and fix bugs.
The change in #4441 broke the handling of the `elsif`s due to the
change in logic. As every block here has a `next` there's no need to do
an `elsif` in here at all. Additionally, reorder the conditions in here
so you get an appropriate message depending on what you're trying to do.
Finally, tweak some of the messaging to remove things that are ignored
and tell people correct commands to run to link things.
2018-07-10 09:32:42 +01:00
Mike McQuaid
d49566ba06 tab: if parsing JSON fails output the filename.
This should make it easier to debug and resolve things like #4439.
2018-07-10 09:29:26 +01:00
Markus Reiter
4ddb1123d7
Merge pull request #4426 from reitermarkus/refactor-system-command-plist
Simplify `Hbc::SystemCommand::Result#plist`.
2018-07-09 18:30:32 +02:00
Markus Reiter
fcf8cb24fd Remove unused incremental_hash method. 2018-07-06 23:14:34 +02:00
Claudia
3dbb735f3c
Fix PKG installer environment
This commit solves an issue where the environment handed to
`/usr/sbin/installer` is not the same as the environment used by the
graphical PKG installer.

This is evident in some post-install scripts, e. g. the
`component-10.pkg/Scripts/postinstall` script in the `dymo-label`
cask. The code says:

```
USER_ID=`id -u ${USER}`

launchctl bootstrap gui/$USER_ID /Library/LaunchAgents/com.dymo.dls.webservice.plist
```

The graphical installer will export e. g. `USER=alice`, and
everything works as intended.

However, `brew cask install` does not override `sudo`’s default,
which is `USER=ROOT`. This violates the assumptions in the script.

This commit fixes the issue by configuring `sudo` to override the
following environment variables with the proper user name:

- `LOGNAME`
- `USER`
- `USERNAME`
2018-07-06 09:38:00 +02:00
Mike McQuaid
14364bbaee extend/ENV: support CX11 for LLVM Clang.
Fix some checks for `:clang` which should match for either `:clang` or
`:llvm_clang`. Note that's not every check.
2018-07-05 20:15:57 +01:00
Markus Reiter
e07eddc391 Simplify Hbc::SystemCommand::Result#plist. 2018-07-05 10:54:35 +02:00
commitay
44873fd4c8 bottle_block_cop: remove 2018-07-04 21:25:43 +10:00
commitay
44a78a12a9
Merge pull request #4344 from commitay/cask-audit-all-appcasts
cask audit: check for devmate and hockeyapp appcasts
2018-07-04 11:13:40 +10:00
Markus Reiter
98bc356a59 Use Pathname#/. 2018-07-04 02:26:36 +02:00
Markus Reiter
6b078e5883 Update Gemfile.lock. 2018-07-04 02:26:36 +02:00
commitay
4dba9fddf1 components_redundancy: audit stable do without a head or devel spec 2018-07-03 11:56:31 +10:00
Markus Reiter
cbc3184436
Merge pull request #4357 from reitermarkus/tapped-cask-count
Show tapped casks.
2018-07-02 20:46:33 +02:00
Claudia
79682df8b6
Re-enable tests by removing a stray rspec :focus 2018-07-02 16:01:01 +02:00
dependabot[bot]
0bce59b510
Bump rubocop from 0.57.1 to 0.57.2 in /Library/Homebrew/test
Bumps [rubocop](https://github.com/rubocop-hq/rubocop) from 0.57.1 to 0.57.2.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.57.1...v0.57.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-02 05:30:04 +00:00
Markus Reiter
c6c1eacc18 Rename enumeration to comma_and. 2018-07-01 18:48:28 +02:00
Markus Reiter
7671606ddc Add Formatter::enumeration. 2018-07-01 18:48:28 +02:00
Mike McQuaid
61a8c4d1fb
Merge pull request #4300 from apjanke/new-rubocop-version
Upgrade to Rubocop 0.57.2
2018-07-01 09:08:16 +01:00
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
Mike McQuaid
6f5c8b8509 linkage: enable cache by default.
This has not been causing any issues in CI or for `master` users so
let's now enable it by default for everyone.
2018-06-29 19:57:39 +01:00
commitay
b12498159b cask audit: check for devmate and hockeyapp appcasts 2018-06-28 23:17:05 +10:00
Markus Reiter
18e46b3ec2 Fix usage of HOMEBREW_LOAD_PATH. 2018-06-18 16:23:35 +02:00
Markus Reiter
1d629c6978 Don’t show Casks on Linux. 2018-06-18 16:23:35 +02:00
Markus Reiter
a8bfe09c49 Remove tests for brew cask search. 2018-06-18 16:23:35 +02:00
Markus Reiter
da193d2f7e Merge brew cask search into brew search. 2018-06-18 16:23:35 +02:00
Mike McQuaid
f7d0c89c21
Merge pull request #4348 from errordeveloper/master
Ignore any version of Go, when it is a dependency of a bottle
2018-06-18 14:56:14 +01:00
Mike McQuaid
5e6c40e28f Make versioned formulae regex more consistent.
Share the regex where possible and otherwise ensure they are identical.
2018-06-18 14:36:51 +01:00
Vítor Galvão
9831e67452
Merge pull request #4346 from commitay/version-minor_patch
cask dsl versions: add minor_patch
2018-06-16 13:18:21 +01:00
commitay
c5bbf28dd6 cask dsl versions: add minor_patch 2018-06-15 22:40:33 +10:00
Markus Reiter
44f56a0773 Refactor join("") to join. 2018-06-15 13:56:08 +02:00
Markus Reiter
502b393d66 Fix tests. 2018-06-14 22:45:20 +02:00
Mike McQuaid
9b21422b72
Merge pull request #4334 from mistydemeo/mojave_clt_headers
Mojave: require CLT header package
2018-06-14 09:13:25 +01:00
Mike McQuaid
c6b6b31d66
Merge pull request #4304 from apjanke/rspec-implies-non-formula-files
brew style: assume file args are non-formulae when passed --rspec
2018-06-14 09:11:42 +01:00
Misty De Meo
e5212d74a6 Diagnostic: require CLT headers on 10.14 2018-06-13 17:24:32 -07:00
Andrew Janke
c0b7aa00e4 brew style: assume files under Library are no-formulae 2018-06-13 14:06:23 -04:00
commitay
dee0028d1b
Merge pull request #4310 from commitay/remove-checkpoint
remove appcast checkpoints
2018-06-12 23:37:26 +10:00
dependabot[bot]
250449982a
Bump rspec-retry from 0.6.0 to 0.6.1 in /Library/Homebrew/test
Bumps [rspec-retry](https://github.com/noredink/rspec-retry) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/noredink/rspec-retry/releases)
- [Changelog](https://github.com/NoRedInk/rspec-retry/blob/master/changelog.md)
- [Commits](https://github.com/noredink/rspec-retry/compare/v0.6.0...v0.6.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-06-11 20:34:59 +00:00
Mike McQuaid
3081390ff8
Merge pull request #4327 from reitermarkus/dependency-order-cop
Support constants in `DependencyOrder` cop.
2018-06-11 08:59:35 +01:00