3156 Commits

Author SHA1 Message Date
Markus Reiter
785ec4ef57 Add tests for `CaskUnreadableError. 2018-07-29 12:03:42 +02:00
Markus Reiter
355df64d93 Use SystemCommand for curl. 2018-07-29 01:23:33 +02:00
Markus Reiter
aacf603ad2 Fix .codecov.yml. 2018-07-27 01:21:38 +02:00
Mike McQuaid
b74974611c
Merge pull request #4548 from MikeMcQuaid/coverage-tweaks
Tweak code coverage logic
2018-07-26 10:21:46 +01:00
Mike McQuaid
afec4e2988 Tweak code coverage logic
- make OS detection looser to exclude more Linux files on macOS (and
  vice versa)
- Allow slight (0.5%) coverage drops to account for somewhat random
  fluctuations.
2018-07-26 10:09:02 +01:00
Markus Reiter
2912ebfbfe Add test for Tap::from_path. 2018-07-25 11:04:00 +02:00
Markus Reiter
83a1e8dd97 Refactor UnpackStrategy::Dmg. 2018-07-24 16:44:27 +02:00
Markus Reiter
1d167a6b9f Reraise SystemCallError as ErrorDuringExecution. 2018-07-24 16:44:27 +02:00
Markus Reiter
eccd20e276 Merge Hbc::Container classes into UnpackStrategy. 2018-07-24 16:44:27 +02:00
Markus Reiter
b6e54a06e0 Refactor unpack strategies into separate files. 2018-07-23 20:59:28 +02:00
Markus Reiter
e5e8033145 Add system_command helpers. 2018-07-22 23:24:18 +02:00
Markus Reiter
db299035ac
Merge pull request #4517 from reitermarkus/rename-system-command
Rename `Hbc::SystemCommand` to `SystemCommand`.
2018-07-22 22:24:00 +02:00
Markus Reiter
45f6cc5bd0
Merge pull request #4532 from reitermarkus/directory-permissions
Fix directory permissions when unpacking.
2018-07-22 22:23:45 +02:00
Markus Reiter
b675024ce0 Add failing test for DirectoryUnpackStrategy. 2018-07-22 22:02:09 +02:00
Markus Reiter
8f462ddb5d Fix Searchable when collection contains nil. 2018-07-22 21:51:53 +02:00
Markus Reiter
bcf05f1a48 Remove :cask from SystemCommand specs. 2018-07-22 21:11:47 +02:00
Markus Reiter
28384ba518 Rename Hbc::SystemCommand to SystemCommand. 2018-07-22 21:11:47 +02:00
Claudia
8666d8fa18
Increase spec timeout to 30 seconds
I’ve noticed the deadlock test in `cask/system_command_spec.rb` appears to fail spuriously, e. g. in #4529.

Details:

https://travis-ci.org/Homebrew/brew/jobs/406827725#L297-L318

With the spec taking 2 seconds on average on my 2017 MBP, I feel it’s
entirely plausible for the aging test-bot hardware to get knocked by
the 15-second timeout.

Given that the spec will pass early anyway if it passes, I feel it’s
reasonable to bump the timeout to 30 seconds.
2018-07-22 16:27:16 +02:00
Markus Reiter
7ad999f5f8
Merge pull request #4488 from reitermarkus/system-command
Refactor `Hbc::SystemCommand`.
2018-07-20 17:51:10 +02:00
Markus Reiter
fec884d8da Add tests for ErrorDuringExecution. 2018-07-19 16:53:11 +02:00
Markus Reiter
2452b27866 Refactor ErrorDuringExecution. 2018-07-19 16:41:27 +02:00
Markus Reiter
50855c98f0 Don't pass down basename in #extract_nested_tar. 2018-07-19 12:49:21 +02:00
Markus Reiter
c6fa3fe8b4 Add test for basename in #extract_nestedly. 2018-07-19 12:49:21 +02:00
dependabot[bot]
c3ee091e40
Bump parallel_tests from 2.21.3 to 2.22.0 in /Library/Homebrew/test
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.21.3 to 2.22.0.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.21.3...v2.22.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-07-18 16:40:34 +00:00
Markus Reiter
22ddec85b0 Add failing test. 2018-07-18 13:05:34 +02:00
Markus Reiter
5841b992ac Refactor $LOAD_PATH. 2018-07-17 23:38:57 +02:00
Markus Reiter
89582c2d0e Fix typo. 2018-07-17 12:53:12 +02:00
Markus Reiter
e5865e7e7f Assimilate Containers with UnpackStrategy. 2018-07-16 23:50:45 +02:00
Markus Reiter
85f76e312a Add spec for nested directories. 2018-07-16 21:36:44 +02:00
Markus Reiter
589c5b4e8d Add support for nested archives. 2018-07-16 21:36:44 +02:00
Markus Reiter
1f56314365 Clear Tap cache before each example. 2018-07-16 10:55:22 +02:00
commitay
43bfbe2060
Merge pull request #4343 from commitay/cask-info-updates
cask info: display `auto_updates`
2018-07-16 09:32:17 +10:00
Mike McQuaid
bd5131d710
Merge pull request #4392 from MikeMcQuaid/more-deprecation-disabled
Disable more deprecations.
2018-07-15 14:48:00 +01:00
Mike McQuaid
af204c843d
Merge pull request #4359 from apjanke/display-build-times
Add --display-times option to `install`, `upgrade`, and `reinstall`
2018-07-15 11:30:22 +01:00
commitay
6d1f99fa5f cask info: display auto_updates 2018-07-15 11:13:04 +10:00
Markus Reiter
b7e849799f
Merge pull request #4469 from reitermarkus/systemcommand-path
Don’t expand `executable` path in `SystemCommand`.
2018-07-14 22:45:43 +02:00
Mike McQuaid
256dfc1af9 Move methods from FileUtils to Formula
These don't need to live on FileUtils and don't really make sense there
either.
2018-07-14 18:13:23 +01:00
Andrew Janke
0a2d8c3d4d Add --display-times option to install, reinstall, and upgrade 2018-07-14 11:06:03 -04:00
Mike McQuaid
5c6ef3d920 Disable more deprecations.
- Turn more old `odeprecated` into `odisabled`
- Remove more old `odisabled`
- Remove code for older Ruby versions
2018-07-14 16:00:50 +01:00
Vítor Galvão
3742cf892c
Merge pull request #4457 from commitay/latest-autoupdate
cask audit: check for `latest` with `auto_updates`
2018-07-14 14:29:19 +01:00
Markus Reiter
a9e109e31a Don’t expand executable path in SystemCommand. 2018-07-14 02:33:42 +02:00
Markus Reiter
232fb9721e Hbc::init does not exist anymore. 2018-07-13 23:03:18 +02:00
Mike McQuaid
060c615fae
Merge pull request #4361 from apjanke/collected-caveats
Display collected caveats at end of `install` or `upgrade`
2018-07-13 19:22:55 +01:00
Mike McQuaid
0a76c9f02e mktemp: move to Formula and compat.
Move this method away from FileUtils as it doesn't need to be on that
class.
2018-07-13 14:42:49 +01:00
Mike McQuaid
0a239372f2
messages_spec: fix brew style. 2018-07-13 10:02:39 +01:00
Mike McQuaid
62f8c96bdb test/cask/cli_spec: temporary skip some tests.
These seem to be related to a leaking RSpec double between tests and
I've verified `brew cask install` still behaves as expected so
let's skip them temporarily.
2018-07-13 09:14:40 +01:00
Andrew Janke
c644392a85 Display collected caveats at end of install or upgrade 2018-07-12 20:41:32 -04:00
Mike McQuaid
3e85afc8b7
Merge pull request #4382 from sjackman/keg_relocate
Relocate bottles on Linux using patchelf
2018-07-12 20:33:58 +01:00
Shaun Jackman
1b688a3a25 Relocate bottles on Linux using patchelf
Ensure patchelf is installed to pour bottles and build bottles.
2018-07-12 10:21:26 -07:00
commitay
ba929cd9e1 cask audit: check for latest with auto_updates 2018-07-12 19:22:47 +10:00